Re: [Fwd: MakeMaker Is DOOMED!]

2003-02-20 Thread Stas Bekman
Ask Bjoern Hansen wrote: On Tue, 18 Feb 2003, A. Bergman wrote: httpd requires make. I don't see much point in adding a requirement when we can't remove the requirement of make anyway. Well, one can get precompiled httpd for win32. That's a good point. If Module::Build makes it easier to

Re: cvs commit: modperl Makefile.PL

2003-02-20 Thread Stas Bekman
[EMAIL PROTECTED] wrote: randyk 2003/02/20 08:28:35 One more nit, please remember to log the changes that are importance to the end user into the Changes file. Certainly if you fix style, or apply some change that is of no interest to the end user, a useful cvs log commit is good enough.

Re: cvs commit: modperl-2.0/lib/ModPerl BuildOptions.pm

2003-02-20 Thread Stas Bekman
Randy Kobes wrote: On Fri, 21 Feb 2003, Stas Bekman wrote: Randy, please review http://perl.apache.org/docs/2.0/devel/core/coding_style.html#Coding_Style_Guide tabs are no-no in 2.0 code, unless this is a code that generates a makefile section. Thanks, Stas - I'll fix that up. thanks, and

Re: cvs commit: modperl-2.0/lib/ModPerl BuildOptions.pm

2003-02-20 Thread Randy Kobes
On Fri, 21 Feb 2003, Stas Bekman wrote: > Randy, please review > http://perl.apache.org/docs/2.0/devel/core/coding_style.html#Coding_Style_Guide > tabs are no-no in 2.0 code, unless this is a code that > generates a makefile section. Thanks, Stas - I'll fix that up. -- best regards, randy ---

Re: cvs commit: modperl Makefile.PL

2003-02-20 Thread Stas Bekman
[EMAIL PROTECTED] wrote: randyk 2003/02/20 08:42:46 Modified:.Makefile.PL Log: Reviewed by: stas Use Perl's touch(), in case a system touch() isn't available. Revision ChangesPath 1.208 +5 -1 modperl/Makefile.PL Index: Makefile.PL ===

Re: cvs commit: modperl-2.0/lib/ModPerl BuildOptions.pm

2003-02-20 Thread Stas Bekman
[EMAIL PROTECTED] wrote: randyk 2003/02/19 21:19:14 Modified:lib/ModPerl BuildOptions.pm Log: Reviewed by: stas Revision ChangesPath 1.17 +7 -0 modperl-2.0/lib/ModPerl/BuildOptions.pm Index: BuildOptions.pm ==

Re: [mp2] increase winnt threadsperchild?

2003-02-20 Thread Stas Bekman
Randy Kobes wrote: On Thu, 20 Feb 2003, William A. Rowe, Jr. wrote: At 01:06 AM 2/20/2003, Stas Bekman wrote: Bill, is there a relation between a number of vhosts and a number of spawned threads for the startup times? Is it a correct observation from Randy, that you need to start at least N

Re: cvs commit: modperl-2.0/t/response/TestCompat conn_authen.pm

2003-02-20 Thread Stas Bekman
Geoffrey Young wrote: Stas Bekman wrote: [EMAIL PROTECTED] wrote: geoff 2003/02/19 06:14:36 Modified:.Changes lib/Apache compat.pm t/response/TestCompat conn_authen.pm Log: fixes to Apache::compat. make $r->connection->auth_type interfac

Re: [mp2] increase winnt threadsperchild?

2003-02-20 Thread Randy Kobes
On Thu, 20 Feb 2003, William A. Rowe, Jr. wrote: > At 01:06 AM 2/20/2003, Stas Bekman wrote: > > >Bill, is there a relation between a number of vhosts and a > >number of spawned threads for the startup times? Is it a > >correct observation from Randy, that you need to start at > >least N threads,

Re: cvs commit: modperl-2.0/t/response/TestCompat conn_authen.pm

2003-02-20 Thread Geoffrey Young
Stas Bekman wrote: [EMAIL PROTECTED] wrote: geoff 2003/02/19 06:14:36 Modified:.Changes lib/Apache compat.pm t/response/TestCompat conn_authen.pm Log: fixes to Apache::compat. make $r->connection->auth_type interface with r->ap_auth_type

Re: [Fwd: MakeMaker Is DOOMED!]

2003-02-20 Thread Ask Bjoern Hansen
On Tue, 18 Feb 2003, A. Bergman wrote: > > httpd requires make. I don't see much point in adding a requirement > > when we can't remove the requirement of make anyway. > > Well, one can get precompiled httpd for win32. That's a good point. If Module::Build makes it easier to build mod_perl on W