Github user ankitsinghal commented on the pull request:
https://github.com/apache/phoenix/pull/153#issuecomment-209773123
I have done the changes in last commit.
Thanks you so much @samarthjain and @JamesRTaylor for taking time and
reviewing it. I'll just get this committed.
---
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240646#comment-15240646
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user ankitsinghal commented on
Can you not use syntax like TIMESTAMP '2016-01-01 00:00:00.123456789' for
the sql value?
On Wed, Apr 13, 2016 at 4:15 PM, Sergey Soldatov
wrote:
> Guys,
> Is there a way to set nanos for Timestamp from sql statement? The only
> way to set nanos I see at the moment is to use PrepareStatement
> to
Guys,
Is there a way to set nanos for Timestamp from sql statement? The only
way to set nanos I see at the moment is to use PrepareStatement
together with java.sun.Timestamp#setNanos() in Java. Did I miss
something?
Thanks,
Sergey
[
https://issues.apache.org/jira/browse/PHOENIX-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240189#comment-15240189
]
Nick Dimiduk commented on PHOENIX-1395:
---
Yes, these files are in /tmp on the clien
[
https://issues.apache.org/jira/browse/PHOENIX-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240174#comment-15240174
]
Samarth Jain commented on PHOENIX-1395:
---
[~ndimiduk] - are you seeing tmp files le
[
https://issues.apache.org/jira/browse/PHOENIX-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240160#comment-15240160
]
Nick Dimiduk commented on PHOENIX-1395:
---
Maybe a better solution is to advise in o
[
https://issues.apache.org/jira/browse/PHOENIX-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240149#comment-15240149
]
Nick Dimiduk commented on PHOENIX-1395:
---
Hey guys I'm still seeing this on 4.6.
>
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239885#comment-15239885
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/153#issuecomment-209605592
This looks great now @ankitsinghal. I am +1 once you have addressed the
last review comments. Thanks a lot for your patience and diligence!
---
If your project is
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239878#comment-15239878
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r59608279
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2387,8 +2452,27 @@ public Void call() throws Exce
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239874#comment-15239874
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r59607658
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
---
@@ -77,6 +79,7 @@ public SQLException newException(SQLExcept
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239865#comment-15239865
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r59607039
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/IllegalOperationException.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apach
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239587#comment-15239587
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user JamesRTaylor commented on
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/153#issuecomment-209542664
Yes, LGTM @ankitsinghal. @samarthjain - how about you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239508#comment-15239508
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user ankitsinghal commented on
Github user ankitsinghal commented on the pull request:
https://github.com/apache/phoenix/pull/153#issuecomment-209525622
@JamesRTaylor , I am done with the changes in last commit. so is it good
for commit now?
---
If your project is set up for it, you can reply to this email and hav
Github user codymarcel commented on the pull request:
https://github.com/apache/phoenix/pull/157#issuecomment-209524084
@gkanade Any updates on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239466#comment-15239466
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user JamesRTaylor commented on
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/153#issuecomment-209519420
Sounds good, @ankitsinghal. I think we'll be good to go after these minor
changes. Thanks for all your excellent work here.
---
If your project is set up for it,
Yes, we're working on HBase 1.2 support - there's a patch over
on PHOENIX-2833. Please feel free to comment. We're trying to get our 1.1
branch to work with HBase 1.1 and 1.2.
Regarding the lack of support in CDH for Phoenix, please let Cloudera know
you need this. FYI, HDP does have support.
We'
Hello everyone,
I have requirement to use transaction in my project. My requirement is - a
client starts transaction and do some upsert operation. I'll have a
coprocessor that will do few more puts. Now what I want is all these
operation should go in single transaction. Meaning if client rollbacks
[
https://issues.apache.org/jira/browse/PHOENIX-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239340#comment-15239340
]
ASF GitHub Bot commented on PHOENIX-2743:
-
Github user joshelser commented on a
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59558697
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/mapreduce/PhoenixResultWritable.java
---
@@ -0,0 +1,215 @@
+/**
+ * Licensed to the A
[
https://issues.apache.org/jira/browse/PHOENIX-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239337#comment-15239337
]
ASF GitHub Bot commented on PHOENIX-2743:
-
Github user joshelser commented on a
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59558405
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/objectinspector/PhoenixObjectInspectorFactory.java
---
@@ -0,0 +1,150 @@
+/**
+ * Lic
GitHub user Boruch28 opened a pull request:
https://github.com/apache/phoenix/pull/160
Change concat Strings in foreach to StringBuilder.
Change != to equals for Strings.
Remove unnecessary == true.
You can merge this pull request into a Git repository by running:
$ git
[
https://issues.apache.org/jira/browse/PHOENIX-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238883#comment-15238883
]
ASF GitHub Bot commented on PHOENIX-2743:
-
Github user ss77892 commented on a di
Github user ss77892 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59513925
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/objectinspector/PhoenixObjectInspectorFactory.java
---
@@ -0,0 +1,150 @@
+/**
+ * Licen
HI All,
Is there any plans to support for HBase 1.2 over phoenix.
I did tried forking phoenix 4.7-HBase-1.1 and changed the dependencies to HBase
1.2. The source code is not in compilable state when dependencies are upgraded
to Hbase1.2. So I assume that Hbase 1.2 is not supported out of box.
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238857#comment-15238857
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user ankitsinghal commented on
[
https://issues.apache.org/jira/browse/PHOENIX-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238858#comment-15238858
]
ASF GitHub Bot commented on PHOENIX-2743:
-
Github user ss77892 commented on a di
Github user ss77892 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59511702
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/mapreduce/PhoenixResultWritable.java
---
@@ -0,0 +1,215 @@
+/**
+ * Licensed to the Apa
Github user ankitsinghal commented on the pull request:
https://github.com/apache/phoenix/pull/153#issuecomment-209304973
@JamesRTaylor ,
> There are likely lots of issues if isNamespaceMapping config property
changes from true to false, no?
There will not be any pro
[
https://issues.apache.org/jira/browse/PHOENIX-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238852#comment-15238852
]
ASF GitHub Bot commented on PHOENIX-2743:
-
Github user ss77892 commented on a di
Github user ss77892 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59511383
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/ql/index/IndexPredicateAnalyzer.java
---
@@ -0,0 +1,486 @@
+/**
+ * Licensed to the Apa
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238812#comment-15238812
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user ankitsinghal commented on
Github user ankitsinghal commented on the pull request:
https://github.com/apache/phoenix/pull/153#issuecomment-209296286
@samarthjain
> Will the table T be created in the namespace S? If the feature is
disabled, it shouldn't be. Would you mind adding a test for this if it ha
41 matches
Mail list logo