Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/315
> It's just that some project using PQS wants to change configuration via
code, It wont be possible since HBaseConfiguration.create() will only read XML
on the class path
Do
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/315
> Is it fine for me to change
I'd just leave this as-is for now. I don't think it's "broken" how it is
right now (PQS doesn't try to set anyt
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/315
> Am I missing something here?
Nope, it's me :). I didn't realize that the Factory was creating a new
`Configuration` every time. The setup of `GlobalClientMetrics` just...
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/315
@karanmehta93 but in PQS, we're controlling the Configuration. Isn't this
as simple as changing `QueryServer#main(String[])` to use
`HBaseFactoryProvider.getConfigurat
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/315
One final request, @karanmehta93 -- can you set
`phoenix.client.metrics.tag` in QueryServer.java proactively, please?
You have my +1 after that.
---
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r207051474
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r207003788
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/315
Just used JVisualVM to look at these metrics via the MBeans directly.
Worked just fine.
I think naming/convention when being collected from a distributed
environment needs to be thought
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206974865
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206971126
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/315
> it looks like there are some commons-configuration issues that will need
to be worked out for GlobalPhoenixMetricsTestSink.java
Just needs to be switched to
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/315
Pulling this into `master`, it looks like there are some
commons-configuration issues that will need to be worked out for
GlobalPhoenixMetricsTestSink.java
---
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/315
> I think the only question pending in this PR is if we want JVMMetrics or
not, which are crucial from PQS POV, otherwise not really for a regular client.
Agreed. What about just makin
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/315
> All these metrics are pushed to JMX and we monitor those via OpenTSDB
tcollectors.
Cool! I was just looking for a sanity check that you are seeing all of the
metrics you expect com
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206638567
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206597366
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -204,6 +230,45 @@ private static void resetGlobalMetrics
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206598366
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206598488
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -204,6 +230,45 @@ private static void resetGlobalMetrics
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206598832
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/GlobalPhoenixMetricsTestSink.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206595985
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -204,6 +230,45 @@ private static void resetGlobalMetrics
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206598160
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206259317
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -204,6 +219,39 @@ private static void resetGlobalMetrics
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206259129
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalClientMetrics.java
---
@@ -108,40 +114,88
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206259200
--- Diff: phoenix-core/src/test/resources/hadoop-metrics2.properties ---
@@ -32,10 +32,9 @@
#[prefix].[source|sink].[instance].[options
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/318
@jimmycasey can you create a corresponding Jira issue under the PHOENIX
project using https://issues.apache.org/jira/secure/CreateIssue.jspa, please?
We do our project mgmt/release tracking on
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r205884608
--- Diff: phoenix-core/src/test/resources/hadoop-metrics2.properties ---
@@ -32,10 +32,9 @@
#[prefix].[source|sink].[instance].[options
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r205884335
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -204,6 +219,39 @@ private static void resetGlobalMetrics
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r205884792
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalClientMetrics.java
---
@@ -108,40 +114,88
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r205884048
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -204,6 +219,39 @@ private static void resetGlobalMetrics
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/311#discussion_r204818876
--- Diff: bin/traceserver.py ---
@@ -116,8 +116,10 @@
#" -Xdebug
-Xrunjdwp:transport=dt_socket,address=5005,server=y,susp
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/311#discussion_r204795871
--- Diff: bin/traceserver.py ---
@@ -116,8 +116,10 @@
#" -Xdebug
-Xrunjdwp:transport=dt_socket,address=5005,server=y,susp
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/311#discussion_r203446592
--- Diff:
phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/TraceServlet.java
---
@@ -42,14 +45,21 @@
private static
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/311#discussion_r203446437
--- Diff:
phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/Main.java
---
@@ -62,15 +63,18 @@ public int run(String[] arg0
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/311#discussion_r203447995
--- Diff:
phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/TraceServlet.java
---
@@ -98,33 +108,36 @@ protected String
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/311#discussion_r203445596
--- Diff: bin/traceserver.py ---
@@ -116,8 +116,10 @@
#" -Xdebug
-Xrunjdwp:transport=dt_socket,address=5005,server=y,susp
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/307
On the note about docker, trying to think about this, I feel like a docker
environment that can spin up all of the necessary stuff to run both of the
python tests as well as this new one will be
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/307
If there's a bright-side, it's something in my environment. Spinning up the
JDBC thin client against this setup works:
```
$ PHOENIX_OPTS="$PHOENIX_OPTS -Dsun.security.
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/307
Turning back on `KRB5_TRACE`...
```
DEBUG:phoenixdb.avatica.client:POST http://localhost:60358/
'\n?org.apache.calcite.avatica.proto.Requests$OpenConnectionRequest\x12&\n$386e
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/307
Ok, where I'm at now:
* Python 2.7.15 (installed via pyenv)
* Using virtualenv to circumvent the .sh script
* Modified the junit test to just leave it running
* Modified the
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/307
Ah, I think my issue might have been cruft sitting in
`python/requests-kerberos/`, the `build` dir and the `.egg-info` dir.
Getting a straightforward HTTP/401 error now. That I know how
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/307
> Not sure how you got MIT on Mac OS X, is it in some ports package
Yeah, homebrew has a `krb5` package which I use for running stuff locally
(e.g. I put it on the `PATH` before
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/307
Ugh, I'm getting frustrated:
I have MIT kerberos on my Mac, so I unblocked myself first by just forcing
the minikdc config file to be made instead of the if-branch you added
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/307
> If you are still unable to get .deactivate to work, remove it from the
shell script for now and we can revisit it. Again I am being overly pedantic
here, but a the shell exits, we really do
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r202108057
--- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh ---
@@ -0,0 +1,59 @@
+#/usr/bin/env bash
+
+set -u
+set -x
+set -e
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r202106445
--- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh ---
@@ -0,0 +1,59 @@
+#/usr/bin/env bash
+
+set -u
+set -x
+set -e
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/308#discussion_r201468535
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java
---
@@ -0,0 +1,155 @@
+/*
+ * Licensed
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/308#discussion_r201465583
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java
---
@@ -0,0 +1,155 @@
+/*
+ * Licensed
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/307
Tried to run the test, but it failed with:
```
2018-07-10 13:43:55,599 ERROR [main]
end2end.SecureQueryServerPhoenixDBIT(359): + . deactivate ''
2018-07-10 13:43:55,599 E
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/307
> How do we make sure requests-kerberos is built in a way that phoenixdb
will grab it? (e.g. 0.13.0.dev0-phoenixdb)
Ah, I see this is updated in
python/requests-kerbe
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r201418146
--- Diff: phoenix-queryserver/pom.xml ---
@@ -47,6 +47,11 @@
org.apache.maven.plugins
maven-failsafe-plugin
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r201078376
--- Diff: python/requests-kerberos/LICENSE ---
@@ -0,0 +1,15 @@
+ISC License
--- End diff --
Just calling out that this is allowed: ISC
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r201077800
--- Diff: python/phoenixdb-module/phoenixdb/__init__.py ---
@@ -1,11 +1,10 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r201076404
--- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh ---
@@ -0,0 +1,59 @@
+#/usr/bin/env bash
+
+set -u
+set -x
+set -e
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r201075953
--- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh ---
@@ -0,0 +1,59 @@
+#/usr/bin/env bash
+
+set -u
+set -x
+set -e
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r201077202
--- Diff:
phoenix-queryserver/src/it/java/org/apache/phoenix/end2end/SecureQueryServerPhoenixDBIT.java
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed to
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r201077355
--- Diff:
phoenix-queryserver/src/it/java/org/apache/phoenix/end2end/SecureQueryServerPhoenixDBIT.java
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed to
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r201076875
--- Diff:
phoenix-queryserver/src/it/java/org/apache/phoenix/end2end/SecureQueryServerPhoenixDBIT.java
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed to
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146973563
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3101,49 +3124,68 @@ void
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146928850
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3101,49 +3124,68 @@ void
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146902970
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3101,49 +3124,72 @@ void
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146903705
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3101,49 +3124,68 @@ void
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146902673
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3086,12 +3103,18 @@ private void
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146902373
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2526,8 +2541,14 @@ private void
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146904748
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3195,6 +3255,18 @@ public boolean
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146904346
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3101,49 +3124,68 @@ void
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146901856
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2514,7 +2529,7 @@ private void
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/275#discussion_r144414821
--- Diff: phoenix-core/src/main/java/com/force/db/i18n/OracleUpper.java ---
@@ -0,0 +1,66 @@
+/*
--- End diff --
Yup! You got it right
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/236
Thanks, Rahul. I'll add this to my list to try to merge in so we can keep
moving forward!
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/236
Thanks for the fixes in f042ca0, @rahulsIOT.
Github is telling me that you have some conflicts that need resolving. If
you can do that and file the JIRA case about firming up the ACL
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r130726475
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
---
@@ -284,14 +288,18 @@
public static final int
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/236
> The LoadBalancer.getLoadBalancer().getSingleServiceLocation() throw
exception that client needs to catch. Usually it shows that there is some issue
with connecting to zookeeper or there is
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r129067645
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
---
@@ -284,14 +288,18 @@
public static final int
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r129066492
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java ---
@@ -255,9 +255,16 @@
public static final String
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r129067705
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
---
@@ -284,14 +288,18 @@
public static final int
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r129067998
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java ---
@@ -255,9 +255,16 @@
public static final String
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r129070107
--- Diff: phoenix-queryserver/pom.xml ---
@@ -176,5 +176,10 @@
test-jar
test
+
+ org.mockito
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r129069369
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/register/Registry.java
---
@@ -0,0 +1,31 @@
+/**
+ *
+ * Licensed
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r129068996
--- Diff:
phoenix-load-balancer/src/main/java/org/apache/phoenix/queryserver/register/ZookeeperRegistry.java
---
@@ -0,0 +1,72
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r129068605
--- Diff: phoenix-load-balancer/pom.xml ---
@@ -0,0 +1,84 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi=
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/265
Woops. I forgot to close this via commit message. If you could close it at
your convenience, @Wancy, I'd appreciate it!
---
If your project is set up for it, you can reply to this email and
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/265#discussion_r124414777
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
---
@@ -273,6 +282,54 @@ public int run(String[] args
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/265#discussion_r124409282
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
---
@@ -228,7 +235,9 @@ public int run(String[] args
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/265#discussion_r124409157
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
---
@@ -273,6 +282,54 @@ public int run(String[] args
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/265#discussion_r124402049
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
---
@@ -273,6 +282,54 @@ public int run(String[] args
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/265#discussion_r124312271
--- Diff:
phoenix-queryserver/src/test/java/org/apache/phoenix/queryserver/server/PhoenixRemoteUserExtractorTest.java
---
@@ -0,0 +1,102
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/265#discussion_r124113023
--- Diff:
phoenix-queryserver/src/test/java/org/apache/phoenix/queryserver/server/PhoenixRemoteUserExtractorTest.java
---
@@ -0,0 +1,102
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/265#discussion_r124112286
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
---
@@ -274,6 +282,47 @@ public int run(String[] args
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/265#discussion_r124110879
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
---
@@ -274,6 +282,47 @@ public int run(String[] args
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/265#discussion_r124110721
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
---
@@ -274,6 +282,47 @@ public int run(String[] args
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/265#discussion_r124113153
--- Diff: phoenix-queryserver/pom.xml ---
@@ -147,6 +147,10 @@
commons-logging
commons-logging
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r123116460
--- Diff:
phoenix-load-balancer/src/main/java/org/apache/phoenix/loadbalancer/service/LoadBalancer.java
---
@@ -0,0 +1,170
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r123116500
--- Diff: phoenix-queryserver/src/it/resources/log4j.properties ---
@@ -1,63 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/236
Ok, thanks for the pointer, Rahul.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r122508226
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
---
@@ -233,16 +240,29 @@ public int run(String
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r122323098
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
---
@@ -233,16 +240,29 @@ public int run(String
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r122076328
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/QueryServer.java
---
@@ -233,16 +240,29 @@ public int run(String
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/236
Also, maybe I'm just not seeing it, but how does this load balancer get
used by clients? It seems like this is only the advertisement component, and
there is nothing for the thin client to u
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r120396712
--- Diff:
phoenix-queryserver/src/main/java/org/apache/phoenix/loadbalancer/service/PqsZookeeperConf.java
---
@@ -0,0 +1,42
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r120395606
--- Diff: pom.xml ---
@@ -953,6 +961,26 @@
joda-time
${jodatime.version}
+
+org.apache.curator
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r120395552
--- Diff: pom.xml ---
@@ -953,6 +961,26 @@
joda-time
${jodatime.version}
+
+org.apache.curator
1 - 100 of 267 matches
Mail list logo
