Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/313
Testing iss...@phoenix.apache.org.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206737818
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + C
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206737372
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2723,13 +2712,10 @@ private void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206737111
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -355,5 +355,19 @@
+ "," + C
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/313
@karanmehta93 or @ankitsinghal Can you please review the updated PR,
thanks!
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206688033
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -82,6 +82,10 @@
static final String
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206687937
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -2957,6 +3010,11 @@ MutationState dropTable(String schemaName
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206687568
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1913,6 +1940,21 @@ private PTable
createTableInternal
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206687510
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -16,8 +16,29 @@
*/
package
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206411967
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3604,6 +3681,18 @@ public MutationState addColumn(PTable table
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/317#discussion_r205953961
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java ---
@@ -204,14 +205,19 @@ private void appendPKColumnValue(StringBuilder
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/317#discussion_r205954264
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1431,11 +1438,42 @@ private PTable getTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/317#discussion_r205952155
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
@@ -1223,7 +1225,9 @@ public void readFields(DataInput input
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/317#discussion_r205952450
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -2185,7 +2223,7 @@ public void createTable
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/313
@ankitsinghal Thanks for the review. I have updated the PR to based on the
feedback. Can you please take a look?
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r205950165
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3604,6 +3675,17 @@ public MutationState addColumn(PTable table
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r205950104
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3034,6 +3088,11 @@ MutationState dropTable(String schemaName
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/313
@ankitsinghal I filed PHOENIX-4765 to not allow metadata changes on a base
table that has child views when the request is from an older client. This will
also allow us to rollback the upgraded
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/316
@m2je Thanks for the contribution. Can you please update the PR to use the
correct branch. It currently has 250+ commits, so it hard to review your
changes.
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/316
@m2je Thanks for the PR. Can you please update the PR so that it uses the
correct branch, so that we can see only your changes? This PR currently has
250+ commits.
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/313
We can't add/drop columns directly to an index on a view. Views with their
own child views will write a mutex using the physical table.
@ChinmaySKulkarni and @karanmehta93 thanks fo
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/313
@karanmehta93 I have updated the PR to use SYSTEM.MUTEX, please review.
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/313
Thanks for the suggestion, I will update the patch to use SYSTEM.MUTEX
---
GitHub user twdsilva opened a pull request:
https://github.com/apache/phoenix/pull/313
PHOENIX-4799 Write cells using checkAndMutate to prevent conflicting â¦
â¦changes
@vincentpoon @karanmehta93 @ChinmaySKulkarni Can you please review?
With this patch, when we add
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r204176116
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationTool.java
---
@@ -0,0 +1,477 @@
+/*
+ * Licensed to the Apache
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r204175638
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationTool.java
---
@@ -0,0 +1,477 @@
+/*
+ * Licensed to the Apache
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r204172869
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationTool.java
---
@@ -0,0 +1,477 @@
+/*
+ * Licensed to the Apache
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r204159396
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/mapreduce/VerifyReplicationToolIT.java
---
@@ -0,0 +1,323 @@
+/*
+ * Licensed to the Apache
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/309#discussion_r204158849
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/mapreduce/VerifyReplicationToolIT.java
---
@@ -0,0 +1,323 @@
+/*
+ * Licensed to the Apache
Github user twdsilva closed the pull request at:
https://github.com/apache/phoenix/pull/303
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r202522040
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableProperty.java ---
@@ -231,36 +231,26 @@ public Object getPTableValue(PTable table
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/303
@JamesRTaylor Thanks for the feedback, I have updated the PR. I will get
this committed shortly.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201835494
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -372,6 +378,31 @@ public void testViewAndTableAndDrop() throws Exception
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201800952
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1893,26 +1981,45 @@ public static void upgradeTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201799117
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1779,13 +2174,65 @@ public void createTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201776288
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -447,7 +447,7 @@
static
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201776204
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1809,180 +2256,97 @@ public void createTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201776174
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1488,20 +1904,19 @@ public void createTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201776136
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1457,28 +1791,110 @@ private static void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201776009
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -586,48 +590,359 @@ public void getTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201776046
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -586,48 +590,359 @@ public void getTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201776089
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1457,28 +1791,110 @@ private static void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201748315
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1957,6 +1968,17 @@ private PTable
createTableInternal
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201745438
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -3642,30 +3596,62 @@ private void dropIndexes(PTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201744675
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -2573,307 +2897,139 @@ else if (pkCount
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201741221
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -2147,46 +2566,29 @@ private MetaDataMutationResult
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r201739480
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1809,180 +2256,97 @@ public void createTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r199147322
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/coprocessor/MetaDataEndpointImplTest.java
---
@@ -0,0 +1,299 @@
+package
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r197829637
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilter.java
---
@@ -35,20 +35,18 @@
* during cluster
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/304#discussion_r194539685
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -98,14 +84,7 @@
import
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/304#discussion_r194545366
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -767,50 +748,117 @@ private void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/304#discussion_r194546247
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -767,50 +748,117 @@ private void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/304#discussion_r194544646
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java ---
@@ -651,6 +653,10 @@ public static String
getJdbcUrl
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/304
I think you is better If you add code to UpgradeUtil that runs at the next
major upgrade that checks all the tables and ensures these three property
values are in sync (see addParentToChildLinks
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192569643
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -388,51 +435,65 @@ public void
testViewAndTableInDifferentSchemas
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192460500
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -388,51 +435,65 @@ public void
testViewAndTableInDifferentSchemas
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192318659
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PColumnImpl.java ---
@@ -156,14 +209,14 @@ public String toString() {
return
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192318109
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/WhereConstantParser.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192318056
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ColumnNameTrackingExpressionCompiler.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192317572
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/DropColumnIT.java ---
@@ -522,7 +523,8 @@ public void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192317466
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1457,28 +1761,69 @@ private static void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192317262
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java ---
@@ -1253,7 +1253,9 @@ public void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192316117
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2967,6 +2982,11 @@ protected PhoenixConnection
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192316080
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
---
@@ -479,179 +498,355 @@ private void addTenantIdFilter
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192316026
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
---
@@ -293,6 +293,7 @@ public SQLException newException
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192313898
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -787,7 +787,7 @@ public MutationPlan compile(UpsertStatement
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192308276
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/coprocessor/MetaDataEndpointImplTest.java
---
@@ -0,0 +1,299 @@
+package
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192305732
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
---
@@ -479,179 +498,355 @@ private void addTenantIdFilter
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r192305114
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ExplainPlanWithStatsEnabledIT.java
---
@@ -1202,33 +1202,44 @@ private void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191948821
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -388,51 +435,65 @@ public void
testViewAndTableInDifferentSchemas
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191944295
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -2227,35 +2551,36 @@ private MetaDataMutationResult
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191941040
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1995,36 +2287,46 @@ public void dropTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191939222
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -388,51 +435,65 @@ public void
testViewAndTableInDifferentSchemas
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191938764
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -586,48 +573,336 @@ public void getTable
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/303
@vincentpoon @gjacoby126 This is the PR to support splittable
system.catalog. Please review if you have some time.
---
GitHub user twdsilva opened a pull request:
https://github.com/apache/phoenix/pull/303
PHOENIX-3534 Support multi region SYSTEM.CATALOG table
This patch adds two new LinkTypes EXCLUDED_COLUMNS (used to represent a
column that has been dropped) and VIEW_INDEX_PARENT_TABLE (used
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/296
+1
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/289#discussion_r161893623
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ChangePermissionsIT.java ---
@@ -267,4 +267,26 @@ public void testMultiTenantTables() throws
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/289
@karanmehta93
LGTM. If you want to add more test coverage for indexes you can
parameterize TableDDLPermissionsIT.testIndexAndView which currently grants
permissions directly on the table.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/283#discussion_r153685552
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -4168,4 +4176,124 @@ public MutationState useSchema
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/283#discussion_r152691915
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -0,0 +1,635 @@
+/*
+ * Licensed to the Apache Software
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/283#discussion_r152644100
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java
---
@@ -229,17 +227,12 @@ public void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/283#discussion_r152460399
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -0,0 +1,635 @@
+/*
+ * Licensed to the Apache Software
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/283
ping @ankitsinghal
Karan's patch removes the automatic grant option and always keeps the index
and data tables in sync. Can you please take a look as well.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/283#discussion_r152459739
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java ---
@@ -66,6 +68,46 @@ private void parseQueryThatShouldFail(String sql
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/283#discussion_r152459035
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -4168,4 +4176,197 @@ public MutationState useSchema
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/283#discussion_r152457942
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -4168,4 +4176,197 @@ public MutationState useSchema
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/283#discussion_r152457669
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -4168,4 +4176,197 @@ public MutationState useSchema
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/283#discussion_r152457161
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java
---
@@ -229,17 +227,12 @@ public void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/283#discussion_r152442952
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java
---
@@ -229,17 +227,12 @@ public void
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/279
+1
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/277
+1 LGTM
Thanks for the excellent work.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146998114
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2526,8 +2541,14 @@ private void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146908767
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3101,49 +3124,72 @@ void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146663164
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3101,49 +3124,68 @@ void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146662118
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2905,14 +2918,18 @@ public void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146660595
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java
---
@@ -95,6 +97,7 @@
// Key is the SYSTEM.CATALOG
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146659434
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/MigrateSystemTablesToSystemNamespaceIT.java
---
@@ -0,0 +1,399 @@
+/*
+ * Licensed
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/277
@ankitsinghal @samarthjain @joshelser
in case you guys want to take a look as well
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/241#discussion_r128055418
--- Diff: pom.xml ---
@@ -84,7 +84,7 @@
1.2
1.0
1.2.0
-13.0.1
+20.0
--- End diff --
Can you revert
1 - 100 of 289 matches
Mail list logo
