[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-03-15 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13007261#comment-13007261 ] Daniel Dai commented on PIG-1618: - +1 for NewParser-25.patch. NewParser-25.patch committed

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-03-12 Thread Alex Rovner (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006058#comment-13006058 ] Alex Rovner commented on PIG-1618: -- I am using latest trunk version:

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-03-11 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13005703#comment-13005703 ] Thejas M Nair commented on PIG-1618: bq. 1. We need to print out

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-03-11 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13005708#comment-13005708 ] Thejas M Nair commented on PIG-1618: Unit test and test-patch succeeded with

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-03-11 Thread Alex Rovner (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13005973#comment-13005973 ] Alex Rovner commented on PIG-1618: -- As of now when I import pig-trunk into eclipse I get

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-03-11 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13005987#comment-13005987 ] Xuefu Zhang commented on PIG-1618: -- Yes, Pig now requires antlr jars and the dependency is

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-03-10 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13005436#comment-13005436 ] Daniel Dai commented on PIG-1618: - Review comments for typechecker, lineage,

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-03-09 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004868#comment-13004868 ] Thejas M Nair commented on PIG-1618: Review of NewParser-24.patch - in

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-03-08 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004152#comment-13004152 ] Xuefu Zhang commented on PIG-1618: -- For NewParser-21.patch: [exec] +1 overall.

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-03-07 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003663#comment-13003663 ] Xuefu Zhang commented on PIG-1618: -- I think the behavior change was largely due to the way

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-03-02 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001790#comment-13001790 ] Daniel Dai commented on PIG-1618: - Review for NewParser-18.patch:

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-02-02 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12989940#comment-12989940 ] Thejas M Nair commented on PIG-1618: +1 NewParser-15.patch Patch committed to trunk.

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-02-01 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12989280#comment-12989280 ] Xuefu Zhang commented on PIG-1618: -- Test-patch run result for patch NewParser-15.patch:

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-01-26 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987313#action_12987313 ] Thejas M Nair commented on PIG-1618: +1 NewParser-14.patch committed to trunk. Switch

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-01-18 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983452#action_12983452 ] Thejas M Nair commented on PIG-1618: NewParser-12.patch review comment : For bag schema

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-01-14 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12981990#action_12981990 ] Thejas M Nair commented on PIG-1618: NewParser-11.patch committed to trunk with some

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2011-01-03 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12977045#action_12977045 ] Xuefu Zhang commented on PIG-1618: -- Test patch run result is below. New javacc warnings are

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2010-12-14 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12971305#action_12971305 ] Thejas M Nair commented on PIG-1618: +1 for NewParser-8.patches . I also ran the unit

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2010-11-19 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934069#action_12934069 ] Xuefu Zhang commented on PIG-1618: -- For NewParser-5.patch, the following is the test-patch

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2010-11-09 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930302#action_12930302 ] Xuefu Zhang commented on PIG-1618: -- +1 Patch looks good. Switch to new parser generator

[jira] Commented: (PIG-1618) Switch to new parser generator technology

2010-11-09 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930317#action_12930317 ] Thejas M Nair commented on PIG-1618: javadoc.patch committed to trunk. Switch to new