Tonight I wrote an introduction to Pivot blog post... this was after an
hour or so of hacking, so it might not even be good code, but hey.
http://silverfinn.net/blog/?p=192
Hi Elias,
Welcome! Nice blog entry. FYI, you'll want to subscribe to the mailing list if
you want to see any replies to your message. u...@pivot.apache.org (cc'ed) is
probably the best place for this type of content.
Greg
On Jun 20, 2011, at 9:43 PM, Elias Puurunen wrote:
Tonight I wrote an
Transferring to Dev list:
@Chris,
Just wondering what you thought of the attached patch?
It turns out the TAB character was never making it up to the
SuggestionPopup code - it was being eaten (and ignored) in the ListView
subcomponent of the skin. And I make the TAB and
Patch got dropped
Roger Whitcomb | Architect, Engineering | roger.whitc...@ingres.com|
Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 |
USA
http://www.google.com/maps?f=qhl=engeocode=q=500+Arguello+Street+%7C
Okay, inline then:
Index:
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSuggestionPopupSkin.j
ava
===
---
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSuggestionPopupSkin.j
ava (revision 1138061)
+++
Incorrect handling of TAB key in SuggestionPopup
Key: PIVOT-762
URL: https://issues.apache.org/jira/browse/PIVOT-762
Project: Pivot
Issue Type: Bug
Components: wtk-terra
Affects
[
https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Whitcomb updated PIVOT-762:
-
Attachment: suggest.patch
This patch seems to work for my test case.
Incorrect handling of TAB
Roger,
I think the mailing list accepts zipped patches if you want to try again (as
the inline one came out garbled in GMail).
But now that you have created a JIRA ticket, it might be easier to just
attacy the patch there for review.
I'll take a look tomorrow if not before.
Chris
Chris,
The patch is already attached to the JIRA ticket. Thanks.
Roger Whitcomb | Architect, Engineering | roger.whitc...@ingres.com |
Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 |
USA +1 650-587-5596 | fax: +1 650-587-5550
-Original Message-
From: Chris
I noticed a couple of other inconsistencies/gripes earlier when comparing
behaviour of all Components that I could think of which create 'pop up
windows' of one kind or another.
CalendarButton
ColorChooserButton
ListButton
MenuButton
SuggestionPopup
Mainly just focus navigation, but also general
Sounds good. Yeah, I was just focused on SuggestionPopup 'cause
that's what I've been working on, but there are other issues, as you
noticed.
Roger Whitcomb | Architect, Engineering | roger.whitc...@ingres.com |
Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 |
USA +1
Roger,
While on the subject of SuggestionPopups - do you have any opinion on this
old thread?
http://apache-pivot-developers.417237.n3.nabble.com/SuggestionPopup-Panorama-vs-ScrollPane-tp2013809p2013809.html
Chris
On 22 June 2011 02:21, Roger L. Whitcomb roger.whitc...@ingres.com wrote:
My lists are generally not very long, so Panorama seems fine to me. I
also notice that things like Firefox tab popup list is pretty much like
a Panorama and so is its Bookmarks menu (when it gets longer than the
screen size). So we are not without precedent. I think I slightly
prefer the
Add tri-state checkbox renderer for TableView row editors
-
Key: PIVOT-763
URL: https://issues.apache.org/jira/browse/PIVOT-763
Project: Pivot
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Whitcomb updated PIVOT-763:
-
Attachment: tristate.patch
This patch implements the feature. Tested in our application where we
[
https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052872#comment-13052872
]
Greg Brown commented on PIVOT-763:
--
I like the concept, but I wonder if
[
https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052875#comment-13052875
]
Roger Whitcomb commented on PIVOT-763:
--
That was the way I originally implemented it,
[
https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052879#comment-13052879
]
Roger Whitcomb commented on PIVOT-763:
--
The other thing I thought about was only
[
https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052881#comment-13052881
]
Greg Brown commented on PIVOT-763:
--
Using load() seems reasonable. It is also used by the
[
https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052884#comment-13052884
]
Roger Whitcomb commented on PIVOT-763:
--
Do you mean making a base class
[
https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052886#comment-13052886
]
Greg Brown commented on PIVOT-763:
--
I think ideally we could just get away with the one
[
https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Whitcomb updated PIVOT-763:
-
Attachment: tristate2.patch
Okay, this implements this hierarchy: base class with two subclasses.
[
https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052923#comment-13052923
]
Sandro Martini commented on PIVOT-763:
--
Hi Roger,
if you commit (of course in the
[
https://issues.apache.org/jira/browse/PIVOT-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandro Martini resolved PIVOT-687.
--
Resolution: Fixed
Hi all, thank you very much for your new tests (and comments).
Be free to
24 matches
Mail list logo
