Patch got dropped....
Roger Whitcomb | Architect, Engineering | roger.whitc...@ingres.com| Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 | USA <http://www.google.com/maps?f=q&hl=en&geocode=&q=500+Arguello+Street+%7C +Suite+200+%7C+Redwood+City+%7C+CA+%7C+94063+%7C+USA+&sll=37.0625,-95.67 7068&sspn=50.557552,73.037109&ie=UTF8&t=h&z=16&iwloc=addr> | +1 650-587-5596 | fax: +1 650-587-5550 From: Roger L. Whitcomb [mailto:roger.whitc...@ingres.com] Sent: Tuesday, June 21, 2011 11:23 AM To: dev@pivot.apache.org Subject: RE: Focus transfer when suggestion popup closes Transferring to Dev list: @Chris, Just wondering what you thought of the attached patch? It turns out the TAB character was never making it up to the SuggestionPopup code - it was being eaten (and ignored) in the ListView subcomponent of the skin. And I make the TAB and SHIFT-TAB (as well as mouse clicks outside the window) not put the focus back on the TextInput. From my testing it seems correct now. Roger Whitcomb | Architect, Engineering | roger.whitc...@ingres.com| Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 | USA <http://www.google.com/maps?f=q&hl=en&geocode=&q=500+Arguello+Street+%7C +Suite+200+%7C+Redwood+City+%7C+CA+%7C+94063+%7C+USA+&sll=37.0625,-95.67 7068&sspn=50.557552,73.037109&ie=UTF8&t=h&z=16&iwloc=addr> | +1 650-587-5596 | fax: +1 650-587-5550 From: Chris Bartlett [mailto:cbartlet...@gmail.com] Sent: Tuesday, June 21, 2011 4:35 AM To: u...@pivot.apache.org Subject: Re: Focus transfer when suggestion popup closes I just noticed that while this is how *closed* ListButtons behave, but not *opened* ones. Perhaps they should? I imagine that MenuButtons should behave the same way as ListButtons, but it looks like the popup menu does not received focus when it is opened. This can be seen in the KitchenSink demo by left clicking on one of the MenuButtons (in the Menus RollUp) and then trying to use the arrow keys to navigate within the menu, http://pivot.apache.org/demos/kitchen-sink.html Spinners, Sliders, ListViews, TableViews & TreeViews also support their selections being changed via the keyboard, and then TAB/SHIFT+TAB transferring focus. ButtonGroups (radio buttons) use TAB/SHIFT+TAB to navigate between buttons. (Obviously the Components above do not open child windows) On 21 June 2011 13:30, Chris Bartlett <cbartlet...@gmail.com> wrote: If the SuggestionPopup window is open - When the ListView has focus (and therefore a suggestion/list item is selected), TAB/SHIFT+TAB selects that suggestion, closes the window and attempts to transfers focus *from* the TextInput according to the TAB/SHIFT+TAB keycode. Note that this last one doesn't currently work as the TAB/SHIFT+TAB seems to be consumed within the keyPressed handler of the TerraListViewSkin (via a call to super.keyPressed(...)), but it could be supported with a new ComponentKeyListener on the ListView.
