Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-20 Thread Lari Hotari
Thanks for suggesting. That's a good way to prevent regressions. I made the changes to schedule a daily build with JDK 21. Please review https://github.com/apache/pulsar/pull/21410 -Lari On 2023/10/20 12:22:44 Christophe Bornet wrote: > Nice. > Would it be possible to have a daily build on JDK

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-20 Thread Christophe Bornet
Nice. Would it be possible to have a daily build on JDK 21 to ensure it runs properly ? Le ven. 20 oct. 2023 à 00:34, Lari Hotari a écrit : > > Hi all, > > I can now confirm that apache/pulsar master branch compiles and runs all > tests in Pulsar CI successfully with Java 21. Therefore, we have

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-19 Thread Lari Hotari
Hi all, I can now confirm that apache/pulsar master branch compiles and runs all tests in Pulsar CI successfully with Java 21. Therefore, we have already accomplished the first level of Java 21 support. Example of Pulsar CI build with Java 21:

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-19 Thread Christophe Bornet
+1. It's important to support the latest JDK LTS. Le mer. 18 oct. 2023 à 00:02, Lari Hotari a écrit : > > Dear Pulsar community, > > Java 21 was released on September 19th and has now become the current Java > LTS release. > > I've begun preparations in the Pulsar code base to allow for Java 21

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-19 Thread Lari Hotari
I have created https://github.com/apache/pulsar/pull/21400 which parameterizes the JDK version used for the Pulsar CI GitHub Actions workflow. When triggering the workflow manually, it's possible to choose between JDK 17 and JDK 21 from a dropdown menu. The PR contains more details, please

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-18 Thread tison
> I think Java 21 can open the door for Virtual Threads[1]. Yep. This should be a good motivation for using JDK 21. We may start a survey in the community a few months later for JDK 21 feedback (as we /will/ switch the runtime to JDK 21 in Docker) and try to switch the toolkit. Best, tison.

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-18 Thread Zixuan Liu
+1 for compatibility with Java 21. Next step: Migrating the Pulsar Server runtime to Java 21 from Java 17 in the Docker image and CI. Pulsar Client/Admin continues to use Java 8. Thanks, Zixuan Lari Hotari 于2023年10月18日周三 06:02写道: > > Dear Pulsar community, > > Java 21 was released on September

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-18 Thread Heesung Sohn
Hi, +1 for Java 21. I think Java 21 can open the door for Virtual Threads[1]. [1] https://openjdk.org/jeps/444 Thanks, Heesung On Wed, Oct 18, 2023 at 10:33 AM Lari Hotari wrote: > Yes, I agree that we don't need to rush in making Java 21 the default > runtime in docker images and the default

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-18 Thread Lari Hotari
Yes, I agree that we don't need to rush in making Java 21 the default runtime in docker images and the default JVM to run tests on in CI. It seems that supporting Java 21 for build and tests in CI is not too far away. My intention is to make the master code base compatible with Java 21 as the

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-18 Thread tison
It's different to 1. be compatible with JDK 21 2. switch the runtime to JDK 21 The latter means we can break compatibility with early JRE. I totally support to be compatible with JDK 21 and saw your PRs to upgrade mockito version for so. But perhaps it's better to wait a bit for users feedback

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-18 Thread Enrico Olivelli
I support the idea of moving to JDK21, as far as we continue to support JDK8 for the clients Thanks for bringing up this topic Enrico Il giorno mer 18 ott 2023 alle ore 13:37 mattison chao ha scritto: > > Thanks for your answer. > > > > We have the PIP, but that doesn't answer the question

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-18 Thread mattison chao
Thanks for your answer. > We have the PIP, but that doesn't answer the question about the current > schedule and plan for Pulsar 3.2 . There have been delays in past release > schedules so the PIP document doesn't really provide a great answer to > timeline. When is it time to start

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-18 Thread Lari Hotari
Hi, > 1. What are the significant benefits of upgrading? There are 2 parts to how Java 21 could be supported. One level is that we simply add support for developing and running Pulsar on Java 21 runtime without switching the language level of the Pulsar components. This is how Java 11 was

Re: [DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-17 Thread mattison chao
Hi, Lari > Do you think we can target the switch from Java 17 to Java 21 for the Pulsar > 3.2 release? I think we should consider some things: 1. What are the significant benefits of upgrading? 2. We should define some rules for using the new feature by JDK21 before upgrading. Especially for

[DISCUSS] Moving to Java 21 for development and Pulsar server component runtime

2023-10-17 Thread Lari Hotari
Dear Pulsar community, Java 21 was released on September 19th and has now become the current Java LTS release. I've begun preparations in the Pulsar code base to allow for Java 21 to be used as the development runtime for compiling the code and running tests in the master branch. This is a