Re: Review Request: QPID-4699: Modification to C++ INSTALL guide

2013-04-03 Thread Steve Huston
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10267/#review18680 --- You lost the advice for Windows users to go to the INSTALL-WINDOWS f

Re: Review Request: QPID-4699: Modification to C++ INSTALL guide

2013-04-03 Thread Robbie Gemmell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10267/#review18671 --- http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/INSTALL

[jira] [Commented] (QPID-4696) [Java Broker] QPID-4461 review changes

2013-04-03 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621411#comment-13621411 ] Robbie Gemmell commented on QPID-4696: -- Alex made changes in http://svn.apache.org/r14

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-04-03 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/ --- (Updated April 3, 2013, 10:08 p.m.) Review request for qpid, Gordon Sim and Ted

[jira] [Commented] (QPID-4700) [AMQP 1.0] 'to' field incorrectly mapped on to 'x-amqp-delivery-count' property

2013-04-03 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621369#comment-13621369 ] Justin Ross commented on QPID-4700: --- Approved for 0.22. > [AMQP 1.0] 'to

another 0.22 merge request

2013-04-03 Thread Gordon Sim
While going through the 1.0 mapping I discovered a stupid copy&paste error for which I created https://issues.apache.org/jira/browse/QPID-4700 and committed a very trivial fix in http://svn.apache.org/viewvc?view=revision&revision=1464210. If there is still time to merge to 0.22 without holdin

[jira] [Commented] (QPID-4700) [AMQP 1.0] 'to' field incorrectly mapped on to 'x-amqp-delivery-count' property

2013-04-03 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621349#comment-13621349 ] Gordon Sim commented on QPID-4700: -- Fixed on trunk by http://svn.apache.org/viewvc?view=re

[jira] [Created] (QPID-4700) [AMQP 1.0] 'to' field incorrectly mapped on to 'x-amqp-delivery-count' property

2013-04-03 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-4700: Summary: [AMQP 1.0] 'to' field incorrectly mapped on to 'x-amqp-delivery-count' property Key: QPID-4700 URL: https://issues.apache.org/jira/browse/QPID-4700 Project: Qpid

More requests for inclusion into 0.22 release

2013-04-03 Thread Oleksandr Rudyy
Hi Justin, Could you please approve the inclusion of the following into 0.22 release: JIRA: https://issues.apache.org/jira/browse/QPID-4696 Commit: http://svn.apache.org/r1464115 Description: Addresses the review comments for JIRA QPID-4661 commits (modifies broker attribute editing UI to group

Re: Request merge to 0.22: QPID-4697 Minor fixes to make distcheck

2013-04-03 Thread Justin Ross
Ken, would you review the ssl_test change? http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/ssl_test?r1=1464018&r2=1464017&pathrev=1464018 Justin - Original Message - From: "Alan Conway" To: "Justin Ross" , "Qpid Dev" Sent: Wednesday, April 3, 2013 9:57:38 AM Subject: Request

[jira] [Resolved] (QPID-4699) C++ INSTALL instructions might be clearer if the "Building from a Source Distribution" was moved to the top.

2013-04-03 Thread Fraser Adams (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fraser Adams resolved QPID-4699. Resolution: Fixed Committed updated INSTALL instructions to r1464175 > C++ INSTALL

[jira] [Commented] (QPID-4697) Minor fixes to make distcheck

2013-04-03 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621239#comment-13621239 ] Justin Ross commented on QPID-4697: --- Reviewed by Ken. Approved for 0.22.

Re: Review Request: QPID-4699: Modification to C++ INSTALL guide

2013-04-03 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10267/#review18670 --- Ship it! Ship It! - Alan Conway On April 3, 2013, 5:57 p.m., Fra

Re: Proposed Design Checklist to add to Qpid developers page

2013-04-03 Thread Alan Conway
On 04/03/2013 01:47 PM, Chuck Rolke wrote: This is a great list of considerations to which I'd add: - Platform support (C++, bindings) - HA implications Now that we have ditched the old cluster module, HA should no longer be so sensitive to changes elsewhere in the code. I don't thin

Re: Request merge to 0.22: QPID-4697 Minor fixes to make distcheck

2013-04-03 Thread Ken Giusti
+1 - Original Message - > From: "Justin Ross" > To: "Ken Giusti" > Cc: "Qpid Dev" , "Alan Conway" > Sent: Wednesday, April 3, 2013 10:06:07 AM > Subject: Re: Request merge to 0.22: QPID-4697 Minor fixes to make distcheck > > Ken, would you review the ssl_test change? > > http://svn.a

[jira] [Commented] (QPID-4689) QMF console drops object updates from local broker agent.

2013-04-03 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621188#comment-13621188 ] Ken Giusti commented on QPID-4689: -- Reviewboard: https://reviews.apache.org/r/10270/

Review Request: QMF console drops V2 object updates and heartbeat indications

2013-04-03 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10270/ --- Review request for qpid, Ted Ross and Fraser Adams. Description --- The QM

request for inclusion in 0.22 - autodelete queue quota accounting fix

2013-04-03 Thread Chuck Rolke
- Forwarded Message - > From: c...@apache.org > To: comm...@qpid.apache.org > Sent: Tuesday, April 2, 2013 1:57:00 PM > Subject: svn commit: r1463649 - /qpid/trunk/qpid/cpp/src/qpid/broker/Queue.cpp > > Author: chug > Date: Tue Apr 2 17:57:00 2013 > New Revision: 1463649 > > URL: http:

Review Request: QPID-4699: Modification to C++ INSTALL guide

2013-04-03 Thread Fraser Adams
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10267/ --- Review request for qpid. Description --- Modification to C++ INSTALL guide

Re: Proposed Design Checklist to add to Qpid developers page

2013-04-03 Thread Chuck Rolke
This is a great list of considerations to which I'd add: - Platform support (C++, bindings) - HA implications The list is a great reminder of what to address or what to seek help addressing. +1 on the rename. -Chuck - Original Message - > From: "Phil Harvey" > To: dev@qpid.apac

[jira] [Created] (QPID-4699) C++ INSTALL instructions might be clearer if the "Building from a Source Distribution" was moved to the top.

2013-04-03 Thread Fraser Adams (JIRA)
Fraser Adams created QPID-4699: -- Summary: C++ INSTALL instructions might be clearer if the "Building from a Source Distribution" was moved to the top. Key: QPID-4699 URL: https://issues.apache.org/jira/browse/QPID-46

[jira] [Commented] (QPID-4575) Support Visual Studio 2012

2013-04-03 Thread Chuck Rolke (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621054#comment-13621054 ] Chuck Rolke commented on QPID-4575: --- commit r1464104 remove template arguments from std::

Re: CMake improvements

2013-04-03 Thread Steve Huston
Great idea, Alan. Fraser, you could use this opportunity to write up a JIRA with your observation below, then use the review board to get reviews on your patch(es) for the new INSTALL file. Good opportunity to get familiar with the process. -Steve On 4/3/13 10:33 AM, "Alan Conway" wrote: >On 04

[jira] [Updated] (QPID-4650) C++ Broker could use a rebind strategy to steer messages from one queue to other queue(s)

2013-04-03 Thread Chuck Rolke (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Rolke updated QPID-4650: -- Attachment: SlowConsumerRedirect_v1.0.pdf This document describes the Redirect code posted as Diff #3 in

[jira] [Created] (QPID-4698) Fixes needed for the CMake build system when installing files.

2013-04-03 Thread Darryl L. Pierce (JIRA)
Darryl L. Pierce created QPID-4698: -- Summary: Fixes needed for the CMake build system when installing files. Key: QPID-4698 URL: https://issues.apache.org/jira/browse/QPID-4698 Project: Qpid

Re: CMake improvements

2013-04-03 Thread Alan Conway
On 04/03/2013 10:23 AM, Fraser Adams wrote: Not sure if this is the most recent mail in this thread I'm replying to, I saw a couple in a different thread relating to Rob's nss observation, but my in-box is a mess after my holiday so I'm currently trying to gain a semblance of order and catch up a

Re: CMake improvements

2013-04-03 Thread Fraser Adams
Not sure if this is the most recent mail in this thread I'm replying to, I saw a couple in a different thread relating to Rob's nss observation, but my in-box is a mess after my holiday so I'm currently trying to gain a semblance of order and catch up a bit. Anyway, Steve and Alan - you've won

[jira] [Commented] (QPID-3603) New approach to HA

2013-04-03 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620944#comment-13620944 ] Alan Conway commented on QPID-3603: --- Documentation for new HA is in qpid/doc/book/src/cpp

Request merge to 0.22: QPID-4697 Minor fixes to make distcheck

2013-04-03 Thread Alan Conway
https://issues.apache.org/jira/browse/QPID-4697 - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4697) Minor fixes to make distcheck

2013-04-03 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620933#comment-13620933 ] Alan Conway commented on QPID-4697: --- Merged to trunk, request merge to 0.22

[jira] [Created] (QPID-4697) Minor fixes to make distcheck

2013-04-03 Thread Alan Conway (JIRA)
Alan Conway created QPID-4697: - Summary: Minor fixes to make distcheck Key: QPID-4697 URL: https://issues.apache.org/jira/browse/QPID-4697 Project: Qpid Issue Type: Bug Components: Buil

[jira] [Commented] (QPID-4661) [Java Broker] Add UI into web management console to edit broker attributes

2013-04-03 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620903#comment-13620903 ] Robbie Gemmell commented on QPID-4661: -- Raised QPID-4696 to deal with review changes.

[jira] [Created] (QPID-4696) [Java Broker] QPID-4461 review changes

2013-04-03 Thread Robbie Gemmell (JIRA)
Robbie Gemmell created QPID-4696: Summary: [Java Broker] QPID-4461 review changes Key: QPID-4696 URL: https://issues.apache.org/jira/browse/QPID-4696 Project: Qpid Issue Type: Bug C

[jira] [Resolved] (QPID-4694) [Java Broker] the JSON config file is not saved after startup until promted by additional change, which can result in unecessary generation of new IDs for objects on each

2013-04-03 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-4694. -- Resolution: Fixed > [Java Broker] the JSON config file is not saved after startup until promted > b

[jira] [Commented] (QPID-4694) [Java Broker] the JSON config file is not saved after startup until promted by additional change, which can result in unecessary generation of new IDs for objects on eac

2013-04-03 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620888#comment-13620888 ] Alex Rudyy commented on QPID-4694: -- The changes look good to me. We should definitely ask

[jira] [Commented] (QPID-4694) [Java Broker] the JSON config file is not saved after startup until promted by additional change, which can result in unecessary generation of new IDs for objects on eac

2013-04-03 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620886#comment-13620886 ] Robbie Gemmell commented on QPID-4694: -- Change made in http://svn.apache.org/r1463917

[jira] [Assigned] (QPID-4694) [Java Broker] the JSON config file is not saved after startup until promted by additional change, which can result in unecessary generation of new IDs for objects on each

2013-04-03 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPID-4694: Assignee: Alex Rudyy (was: Robbie Gemmell) > [Java Broker] the JSON config file is not

[jira] [Commented] (QPID-4678) [Java Broker] add ACL to restrict new support for broker-level configuration through the management interface

2013-04-03 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620883#comment-13620883 ] Robbie Gemmell commented on QPID-4678: -- Looks good to me. We should ask to include thi

[jira] [Resolved] (QPID-4695) [Java Broker] Add configured object name and id validation to prevent the submission of invalid names and changing of IDs

2013-04-03 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-4695. -- Resolution: Fixed Looks good. Would be good to include this in 0.22. > [Java Br

[jira] [Updated] (QPID-4678) [Java Broker] add ACL to restrict new support for broker-level configuration through the management interface

2013-04-03 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4678: - Status: Ready To Review (was: In Progress) > [Java Broker] add ACL to restrict new support fo

Proposed Design Checklist to add to Qpid developers page

2013-04-03 Thread Phil Harvey
On a number of occasions, I've been involved in Qpid changes that have required rework because certain aspects of the design were not considered early on. To mitigate this, I'd like to add a Design Checklist to the Qpid web site that we can all refer to, either when designing features or reviewing

[jira] [Assigned] (QPID-4678) [Java Broker] add ACL to restrict new support for broker-level configuration through the management interface

2013-04-03 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-4678: Assignee: Robbie Gemmell (was: Alex Rudyy) Robbie, Could you please review the changes in revision

[jira] [Assigned] (QPID-4695) [Java Broker] Add configured object name and id validation to prevent the submission of invalid names and changing of IDs

2013-04-03 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-4695: Assignee: Robbie Gemmell (was: Alex Rudyy) Robbie, could you please review the changes ? http://sv

[jira] [Updated] (QPID-4695) [Java Broker] Add configured object name and id validation to prevent the submission of invalid names and changing of IDs

2013-04-03 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-4695: - Status: Ready To Review (was: In Progress) > [Java Broker] Add configured object name and id validati

[jira] [Created] (QPID-4695) [Java Broker] Add configured object name and id validation to prevent the submission of invalid names and changing of IDs

2013-04-03 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-4695: Summary: [Java Broker] Add configured object name and id validation to prevent the submission of invalid names and changing of IDs Key: QPID-4695 URL: https://issues.apache.org/jira/brows

[jira] [Created] (QPID-4694) [Java Broker] the JSON config file is not saved after startup until promted by additional change, which can result in unecessary generation of new IDs for objects on each

2013-04-03 Thread Robbie Gemmell (JIRA)
Robbie Gemmell created QPID-4694: Summary: [Java Broker] the JSON config file is not saved after startup until promted by additional change, which can result in unecessary generation of new IDs for objects on each startup Key: QP

[jira] [Reopened] (QPID-4678) [Java Broker] add ACL to restrict new support for broker-level configuration through the management interface

2013-04-03 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reopened QPID-4678: -- Assignee: Alex Rudyy (was: Robbie Gemmell) Reopening the JIRA as the ACL checks are performed twice