Re: proton 0.10 blocker

On 07/17/2015 10:04 PM, Rafael Schloming wrote: On Fri, Jul 17, 2015 at 12:47 PM, Gordon Sim wrote: On 07/17/2015 08:15 PM, Rafael Schloming wrote: On Fri, Jul 17, 2015 at 11:56 AM, Gordon Sim wrote: On 07/17/2015 07:17 PM, Rafael Schloming wrote: Given this I believe the incref/decr

Re: proton 0.10 blocker

On Fri, Jul 17, 2015 at 12:47 PM, Gordon Sim wrote: > On 07/17/2015 08:15 PM, Rafael Schloming wrote: > >> On Fri, Jul 17, 2015 at 11:56 AM, Gordon Sim wrote: >> >> On 07/17/2015 07:17 PM, Rafael Schloming wrote: >>> >>> Given this I believe the incref/decref pair is indeed running into p

Re: proton 0.10 blocker

On 07/17/2015 08:15 PM, Rafael Schloming wrote: On Fri, Jul 17, 2015 at 11:56 AM, Gordon Sim wrote: On 07/17/2015 07:17 PM, Rafael Schloming wrote: Given this I believe the incref/decref pair is indeed running into problems when being invoked from inside a finalizer. I'd be curious if an alt

Re: proton 0.10 blocker

On Fri, Jul 17, 2015 at 11:56 AM, Gordon Sim wrote: > On 07/17/2015 07:17 PM, Rafael Schloming wrote: > >> Given this I believe the incref/decref pair is indeed running into >> problems >> when being invoked from inside a finalizer. I'd be curious if an >> alternative fix would work. I suspect yo

Re: proton 0.10 blocker

On 07/17/2015 07:17 PM, Rafael Schloming wrote: Given this I believe the incref/decref pair is indeed running into problems when being invoked from inside a finalizer. I'd be curious if an alternative fix would work. I suspect you could replace the additional conditions you added to the if predic

Re: proton 0.10 blocker

Thanks, Given this I believe the incref/decref pair is indeed running into problems when being invoked from inside a finalizer. I'd be curious if an alternative fix would work. I suspect you could replace the additional conditions you added to the if predicate with this: pn_refcount(endpoint) >

Re: proton 0.10 blocker

On 07/17/2015 05:36 PM, Rafael Schloming wrote: Hi Gordon, I did my best to dump some useful info on the refcounting stuff in the other thread. I also posted a comment on the review. As I said there it would be helpful to see the stack trace from the crash in order to figure out if the fix is me

Re: proton 0.10 blocker

Hi Gordon, I did my best to dump some useful info on the refcounting stuff in the other thread. I also posted a comment on the review. As I said there it would be helpful to see the stack trace from the crash in order to figure out if the fix is merely a workaround. --Rafael On Wed, Jul 15, 201

Re: Review Request 36509: prevent unwanted finalize for links/sessions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36509/#review92100 --- Is the stack trace associated with this fix available anywhere? With

Re: Review Request 36480: DISPATCH-151: Add ability to run websockets proxy and http file server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36480/#review92099 --- Ship it! Ship It! - Ted Ross On July 14, 2015, 2:55 p.m., Ernie

[jira] [Commented] (QPIDJMS-87) make the local maxFrameSize value configurable

[ https://issues.apache.org/jira/browse/QPIDJMS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631522#comment-14631522 ] ASF subversion and git services commented on QPIDJMS-87: Commit bf

Re: Review Request 35798: PROTON-919: make the C impl behave same as Java wrt channel_max error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35798/ --- (Updated July 17, 2015, 4:10 p.m.) Review request for qpid, Andrew Stitcher and

[jira] [Created] (QPIDJMS-87) make the local maxFrameSize value configurable

Robbie Gemmell created QPIDJMS-87: - Summary: make the local maxFrameSize value configurable Key: QPIDJMS-87 URL: https://issues.apache.org/jira/browse/QPIDJMS-87 Project: Qpid JMS Issue Type:

Re: Review Request 35798: PROTON-919: make the C impl behave same as Java wrt channel_max error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35798/#review92087 --- proton-c/include/proton/transport.h (line 348)

Re: Review Request 35798: PROTON-919: make the C impl behave same as Java wrt channel_max error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35798/ --- (Updated July 17, 2015, 2:39 p.m.) Review request for qpid, Andrew Stitcher and

Re: Review Request 36509: prevent unwanted finalize for links/sessions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36509/#review92070 --- Overlooking my nearly non-existent understanding of the proton-c cod

[jira] [Assigned] (QPID-6647) Thread Leak when Connection is closed while a MessageConsumer is in a receive()

[ https://issues.apache.org/jira/browse/QPID-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey reassigned QPID-6647: - Assignee: Rob Godfrey > Thread Leak when Connection is closed while a MessageConsumer is in a > r

[jira] [Updated] (QPID-6647) Thread Leak when Connection is closed while a MessageConsumer is in a receive()

[ https://issues.apache.org/jira/browse/QPID-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated QPID-6647: -- Fix Version/s: 6.0 [Java] > Thread Leak when Connection is closed while a MessageConsumer is in a > rece

[jira] [Updated] (QPID-6647) Thread Leak when Connection is closed while a MessageConsumer is in a receive()

[ https://issues.apache.org/jira/browse/QPID-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated QPID-6647: -- Status: Reviewable (was: In Progress) > Thread Leak when Connection is closed while a MessageConsumer is

[jira] [Commented] (QPID-6647) Thread Leak when Connection is closed while a MessageConsumer is in a receive()

[ https://issues.apache.org/jira/browse/QPID-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631201#comment-14631201 ] ASF subversion and git services commented on QPID-6647: --- Commit 16915

[jira] [Commented] (QPID-6647) Thread Leak when Connection is closed while a MessageConsumer is in a receive()

[ https://issues.apache.org/jira/browse/QPID-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631202#comment-14631202 ] Rob Godfrey commented on QPID-6647: --- Hi Marty, apologies that you've run into this issue

Re: Review Request 36546: PROTON-930: extract numeric default values from AMQP xml at build-time.

> On July 16, 2015, 2:51 p.m., Andrew Stitcher wrote: > > proton-c/src/protocol.h.py, line 32 > > > > > > Perhaps the constants should have a prefix like AMQP_ ? It would make > > them a bit long though, and I don't

Re: Review Request 36546: PROTON-930: extract numeric default values from AMQP xml at build-time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36546/ --- (Updated July 17, 2015, 9:09 a.m.) Review request for qpid, Andrew Stitcher and