[jira] [Commented] (DISPATCH-2046) Panic in handle due to deleted connector.

2021-04-19 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325440#comment-17325440 ] Ganesh Murthy commented on DISPATCH-2046: - Thanks for your comment. I included your change

[jira] [Commented] (DISPATCH-2047) system_tests_one_router fails in test_43_dropped_presettled_receiver_stops

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325310#comment-17325310 ] ASF GitHub Bot commented on DISPATCH-2047: -- ganeshmurthy opened a new pull request #1137:

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1137: DISPATCH-2047: Moved setting the deliveries_ingress to qdr_link_deliv…

2021-04-19 Thread GitBox
ganeshmurthy opened a new pull request #1137: URL: https://github.com/apache/qpid-dispatch/pull/1137 …er_CT. Also fixed test to try the custom timer a few more times -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (PROTON-2321) Add benchmark for pn_data_t initialization (PROTON-2229)

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325303#comment-17325303 ] ASF GitHub Bot commented on PROTON-2321: jiridanek merged pull request #286: URL:

[jira] [Commented] (PROTON-2321) Add benchmark for pn_data_t initialization (PROTON-2229)

2021-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325302#comment-17325302 ] ASF subversion and git services commented on PROTON-2321: - Commit

[jira] [Commented] (PROTON-2229) pn_data_t initialization lead to low performance

2021-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325304#comment-17325304 ] ASF subversion and git services commented on PROTON-2229: - Commit

[GitHub] [qpid-proton] jiridanek merged pull request #286: PROTON-2321 Add benchmark for pn_data_t initialization from PROTON-2229

2021-04-19 Thread GitBox
jiridanek merged pull request #286: URL: https://github.com/apache/qpid-proton/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616151542 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325301#comment-17325301 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325300#comment-17325300 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616151542 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616151542 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325299#comment-17325299 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325297#comment-17325297 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616151542 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325295#comment-17325295 ] ASF GitHub Bot commented on PROTON-2370: codecov-commenter edited a comment on pull request

[jira] [Updated] (DISPATCH-2047) system_tests_one_router fails in test_43_dropped_presettled_receiver_stops

2021-04-19 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-2047: Fix Version/s: 1.16.0 > system_tests_one_router fails in

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325294#comment-17325294 ] ASF GitHub Bot commented on PROTON-2370: codecov-commenter edited a comment on pull request

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
codecov-commenter edited a comment on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-822450129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
codecov-commenter edited a comment on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-822450129 #

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325292#comment-17325292 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pull request #309:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616144888 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325281#comment-17325281 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616130600 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (DISPATCH-2046) Panic in handle due to deleted connector.

2021-04-19 Thread Alex Ward (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325251#comment-17325251 ] Alex Ward commented on DISPATCH-2046: - I did have one comment on your change, I added it to the

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325249#comment-17325249 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pull request #309:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616091512 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Reopened] (DISPATCH-2054) SEGV in qdr_link_cleanup_deliveries_CT during system_tests_multi_tenancy

2021-04-19 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk reopened DISPATCH-2054: -- The double-free has just manifested in main,

[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1114: Bump browserslist from 4.16.3 to 4.16.4 in /console/react

2021-04-19 Thread GitBox
dependabot[bot] commented on pull request #1114: URL: https://github.com/apache/qpid-dispatch/pull/1114#issuecomment-822641729 Looks like browserslist is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1109: Bump typescript from 4.2.3 to 4.2.4 in /console/react

2021-04-19 Thread GitBox
dependabot[bot] commented on pull request #1109: URL: https://github.com/apache/qpid-dispatch/pull/1109#issuecomment-822641665 Looks like typescript is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1109: Bump typescript from 4.2.3 to 4.2.4 in /console/react

2021-04-19 Thread GitBox
dependabot[bot] closed pull request #1109: URL: https://github.com/apache/qpid-dispatch/pull/1109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1114: Bump browserslist from 4.16.3 to 4.16.4 in /console/react

2021-04-19 Thread GitBox
dependabot[bot] closed pull request #1114: URL: https://github.com/apache/qpid-dispatch/pull/1114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1114: Bump browserslist from 4.16.3 to 4.16.4 in /console/react

2021-04-19 Thread GitBox
jiridanek commented on pull request #1114: URL: https://github.com/apache/qpid-dispatch/pull/1114#issuecomment-822641491 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1109: Bump typescript from 4.2.3 to 4.2.4 in /console/react

2021-04-19 Thread GitBox
jiridanek commented on pull request #1109: URL: https://github.com/apache/qpid-dispatch/pull/1109#issuecomment-822641231 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325158#comment-17325158 ] ASF GitHub Bot commented on DISPATCH-1878: -- codecov-commenter edited a comment on pull

[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-19 Thread GitBox
codecov-commenter edited a comment on pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#issuecomment-822536755 #

[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-19 Thread GitBox
ChugR commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615929632 ## File path: src/adaptors/tcp_adaptor.c ## @@ -630,64 +780,92 @@ static void handle_connection_event(pn_event_t *e, qd_server_t *qd_server, void

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325106#comment-17325106 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on a change in pull request

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325105#comment-17325105 ] ASF GitHub Bot commented on DISPATCH-1878: -- codecov-commenter commented on pull request

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-19 Thread GitBox
codecov-commenter commented on pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#issuecomment-822536755 #

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325104#comment-17325104 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on a change in pull request

[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-19 Thread GitBox
ChugR commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615924379 ## File path: src/adaptors/tcp_adaptor.c ## @@ -630,64 +780,92 @@ static void handle_connection_event(pn_event_t *e, qd_server_t *qd_server, void

[jira] [Commented] (DISPATCH-2033) Rare flaky failure in system_tests_qdstat: out.count('UTC') != 1

2021-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325094#comment-17325094 ] ASF subversion and git services commented on DISPATCH-2033: --- Commit

[jira] [Commented] (DISPATCH-2058) qdr_delivery_cleanup_t leak in system_tests_grpc

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325074#comment-17325074 ] ASF GitHub Bot commented on DISPATCH-2058: -- asfgit closed pull request #1130: URL:

[jira] [Resolved] (DISPATCH-2058) qdr_delivery_cleanup_t leak in system_tests_grpc

2021-04-19 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-2058. - Resolution: Fixed > qdr_delivery_cleanup_t leak in system_tests_grpc >

[GitHub] [qpid-dispatch] asfgit closed pull request #1130: DISPATCH-2058: Added code in core free to remove and free everything …

2021-04-19 Thread GitBox
asfgit closed pull request #1130: URL: https://github.com/apache/qpid-dispatch/pull/1130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (DISPATCH-2058) qdr_delivery_cleanup_t leak in system_tests_grpc

2021-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325073#comment-17325073 ] ASF subversion and git services commented on DISPATCH-2058: --- Commit

[jira] [Resolved] (DISPATCH-2048) system_tests_router_mesh failure due to leak of qd_deferred_call_t

2021-04-19 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-2048. - Assignee: Ganesh Murthy Resolution: Fixed > system_tests_router_mesh failure

[jira] [Commented] (DISPATCH-2048) system_tests_router_mesh failure due to leak of qd_deferred_call_t

2021-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325069#comment-17325069 ] ASF subversion and git services commented on DISPATCH-2048: --- Commit

[jira] [Commented] (DISPATCH-2048) system_tests_router_mesh failure due to leak of qd_deferred_call_t

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325070#comment-17325070 ] ASF GitHub Bot commented on DISPATCH-2048: -- asfgit closed pull request #1132: URL:

[GitHub] [qpid-dispatch] asfgit closed pull request #1132: DISPATCH-2048: Fix shutdown leak of qd_deferred_call_t

2021-04-19 Thread GitBox
asfgit closed pull request #1132: URL: https://github.com/apache/qpid-dispatch/pull/1132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325052#comment-17325052 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615869449 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [qpid-dispatch] kgiusti closed pull request #1120: NO-JIRA: bump proton to version 0.34.0 in travis

2021-04-19 Thread GitBox
kgiusti closed pull request #1120: URL: https://github.com/apache/qpid-dispatch/pull/1120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [qpid-dispatch] kgiusti commented on pull request #1120: NO-JIRA: bump proton to version 0.34.0 in travis

2021-04-19 Thread GitBox
kgiusti commented on pull request #1120: URL: https://github.com/apache/qpid-dispatch/pull/1120#issuecomment-822481794 Merge to main for 1.16.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325023#comment-17325023 ] ASF GitHub Bot commented on PROTON-2370: codecov-commenter edited a comment on pull request

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325022#comment-17325022 ] ASF GitHub Bot commented on PROTON-2370: codecov-commenter edited a comment on pull request

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325021#comment-17325021 ] ASF GitHub Bot commented on PROTON-2370: codecov-commenter commented on pull request #309: URL:

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
codecov-commenter edited a comment on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-822450129 #

[GitHub] [qpid-proton] codecov-commenter commented on pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
codecov-commenter commented on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-822450129 #

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
codecov-commenter edited a comment on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-822450129 #

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325016#comment-17325016 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pull request #309:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615825219 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325011#comment-17325011 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615817623 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325006#comment-17325006 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pull request #309:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615813070 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,132 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324996#comment-17324996 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pull request #309:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615806807 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,132 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324994#comment-17324994 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pull request #309:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615805220 ## File path: cpp/src/sender.cpp ## @@ -64,10 +64,18 @@ namespace { uint64_t tag_counter = 0; Review comment: Thanks, I will take a look.

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324991#comment-17324991 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pull request #309:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615804137 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,115 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324990#comment-17324990 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pull request #309:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615803509 ## File path: cpp/src/delivery.cpp ## @@ -40,6 +42,7 @@ namespace proton { delivery::delivery(pn_delivery_t* d): transfer(make_wrapper(d)) {}

[jira] [Commented] (PROTON-2321) Add benchmark for pn_data_t initialization (PROTON-2229)

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324940#comment-17324940 ] ASF GitHub Bot commented on PROTON-2321: jiridanek commented on pull request #286: URL:

[GitHub] [qpid-proton] jiridanek commented on pull request #286: PROTON-2321 Add benchmark for pn_data_t initialization from PROTON-2229

2021-04-19 Thread GitBox
jiridanek commented on pull request #286: URL: https://github.com/apache/qpid-proton/pull/286#issuecomment-822377843 Travis results https://travis-ci.com/github/apache/qpid-proton/jobs/499408632#L2988 ``` 1:

[jira] [Updated] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread Jira
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated PROTON-2370: --- Fix Version/s: proton-c-0.35.0 > [cpp] An accessor for the delivery tag >

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324782#comment-17324782 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on a change in pull request #1129:

[GitHub] [qpid-dispatch] grs commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-19 Thread GitBox
grs commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615601130 ## File path: src/adaptors/tcp_adaptor.c ## @@ -1257,13 +1489,17 @@ static void qdr_tcp_delivery_update(void *context, qdr_delivery_t *dlv, uint64_t

[jira] [Commented] (DISPATCH-1959) Update PatternFly packages for the 1.16.0 release

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324778#comment-17324778 ] ASF GitHub Bot commented on DISPATCH-1959: -- codecov-commenter edited a comment on pull

[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1133: DISPATCH-1959 Update PatternFly packages for the 1.16.0 release

2021-04-19 Thread GitBox
codecov-commenter edited a comment on pull request #1133: URL: https://github.com/apache/qpid-dispatch/pull/1133#issuecomment-821954029 #

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324755#comment-17324755 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324752#comment-17324752 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615581743 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,132 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615585457 ## File path: cpp/src/delivery.cpp ## @@ -40,6 +42,7 @@ namespace proton { delivery::delivery(pn_delivery_t* d): transfer(make_wrapper(d)) {}

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324747#comment-17324747 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615583669 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,115 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324746#comment-17324746 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615583489 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,115 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324743#comment-17324743 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull request #309:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-19 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615578902 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,132 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more