[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349342449 ## File path: c/src/core/codec.c ## @@ -655,7 +693,7 @@ int pn_data_vfill(pn_data_t *d

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349305058 ## File path: c/src/core/codec.c ## @@ -364,37 +364,72 @@ static int pn_data_inspect(v

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349282614 ## File path: c/src/core/codec.c ## @@ -364,37 +364,72 @@ static int pn_data_inspect(v

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349285749 ## File path: c/src/core/codec.c ## @@ -364,37 +364,72 @@ static int pn_data_inspect(v

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349282774 ## File path: c/src/core/codec.c ## @@ -364,37 +364,72 @@ static int pn_data_inspect(v

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349287537 ## File path: c/src/core/codec.c ## @@ -431,6 +466,9 @@ static int pni_data_grow(pn_da

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349292829 ## File path: c/src/core/data.h ## @@ -62,6 +62,8 @@ struct pn_data_t { pni_nid_t b

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349288274 ## File path: c/src/core/codec.c ## @@ -465,6 +503,9 @@ static int pni_data_intern_nod

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349294235 ## File path: c/src/core/engine.c ## @@ -2123,38 +2124,52 @@ pn_condition_t *pn_link_r

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349298718 ## File path: c/src/core/engine.c ## @@ -2299,7 +2314,11 @@ int pn_condition_copy(pn_c

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349281414 ## File path: c/src/core/codec.c ## @@ -364,37 +364,72 @@ static int pn_data_inspect(v

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349283264 ## File path: c/src/core/codec.c ## @@ -364,37 +364,72 @@ static int pn_data_inspect(v

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349301002 ## File path: c/src/core/engine.c ## @@ -203,9 +204,9 @@ pn_transport_t *pn_connection

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349295524 ## File path: c/src/core/engine.c ## @@ -2123,38 +2124,52 @@ pn_condition_t *pn_link_r

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349295766 ## File path: c/src/core/engine.c ## @@ -2123,38 +2124,52 @@ pn_condition_t *pn_link_r

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349295184 ## File path: c/src/core/engine.c ## @@ -2123,38 +2124,52 @@ pn_condition_t *pn_link_r

[GitHub] [qpid-proton] astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

2019-11-21 Thread GitBox
astitcher commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349282913 ## File path: c/src/core/codec.c ## @@ -364,37 +364,72 @@ static int pn_data_inspect(v