Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/360
LGTM! Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/359
LGTM. Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/358
Tests added. The problematic code would fail on the added tests.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/355
@hbdeshmukh Hi Harshad, can you rebase the branch so I can help merge this
PR.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/357
LGTM!
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/355
LGTM!
---
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/358
Fix a bug in HashJoinOperator
This PR fixes a bug in `HashJoinOperator` w.r.t. the swapping of
probe/build sides in a previous PR.
You can merge this pull request into a Git
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/347
LGTM! Merging.
Note that the `concretize` signature in `Physical` plans looks somehow
cumbersome, we may add a `SubstitutionContext` class to wrap these in a future
PR
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/353
LGTM! Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/354
LGTM! Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/351
The stats can be used to provide an estimation even when they are not
exact.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/350
LGTM! Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/349
LGTM! Merging.
---
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/346
Add a python script to auto fix CMakeLists files
This PR adds a script that intends to help improve developer productivity
by automatically fixing `CMakeLists.txt` files
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/344
LGTM! Merging.
---
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/343
Fix all CMakeLists.txt for automated processing
This PR fixes and adjusts the style of all `CMakeLists.txt` so that they
become stable (i.e. well-formatted) to be processed
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/342
LGTM! Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/340
LGTM! Merging.
---
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/340#discussion_r182212888
--- Diff: storage/StorageErrors.hpp ---
@@ -61,9 +61,16 @@ class BlockMemoryTooSmall : public std::exception {
**/
class
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/340#discussion_r182210127
--- Diff: storage/StorageErrors.hpp ---
@@ -61,9 +61,16 @@ class BlockMemoryTooSmall : public std::exception {
**/
class
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/339
LGTM! Merging.
---
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/334
Fix iwyu include path
This PR fixes the third-party library include paths for the iwyu
(include-what-you-use) tool.
You can merge this pull request into a Git repository by running
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/332#discussion_r170369358
--- Diff: query_optimizer/cost_model/StarSchemaSimpleCostModel.cpp ---
@@ -493,7 +493,7 @@ std::size_t
StarSchemaSimpleCostModel
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/333
Fix SeparateChainingHashTable::resize()
This PR fixes the problem that Quickstep hangs when resizing
`SeparateChainingHashTable` during the execution of `BuildHashOperator
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/332
Small adjustments in star schema cost model for # distinct values estimation
This PR has a small adjustment in star schema cost model for # of distinct
values estimation, together
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/331
Add a cmake option to handle the Travis CI timeout problem.
This PR adds a cmake option `ENABLE_COMPARISON_INLINE_EXPANSION` to allow
disabling of method specialization in various
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/329
LGTM! Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/330
LGTM! Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/319
LGTM! Merging.
---
There is no TEXT type yet and it would be good to add the type.
Also there are two issues to be improved for VARCHAR:
(A) The current varchar is restricted to be within a storage block, i.e.
2MB by default configuration.
(B) For varchar with relative large size (e.g. varchar(8192)), a storage
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/326
LGTM! Merging.
---
earch through
various documentations ...
Best,
Jianqiao
2017-11-30 17:07 GMT-06:00 Dylan Bacon <dba...@wisc.edu>:
> So NetworkCliClient should be something I'm able to include in my program
> along with the appropriate dependencies and use as the API? I was think
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/326#discussion_r154230379
--- Diff: query_optimizer/rules/ReferencedBaseRelations.hpp ---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/326#discussion_r154229622
--- Diff: query_optimizer/rules/ReferencedBaseRelations.hpp ---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation
protocol ..
Best,
Jianqiao
2017-11-30 16:49 GMT-06:00 Dylan Bacon <dba...@wisc.edu>:
> Hello,
>
> I am attempting to interface with Quickstep using its NetworkCliClient and
> it's not working as I would expect. I have the default port and IP set to
> 3000 and 0.0.0.0 and am atte
Hi Song,
It seems to be problem with higher versions of gcc/clang.
As a temporary fix please comment out (or remove) the following two lines
in incubator/CMakeLists.txt and see if it works:
https://github.com/apache/incubator-quickstep/compare/disable-flags
Best,
Jianqiao
2017-11-28 18:57 GMT
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
@zuyu Currently `HashJoinOperator` performance is sensitive to the _number
of build blocks per probe block_ due to the concurrency bottleneck within LRU
policy enforcer
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/325
The design looks good to me! It would be better to fast forward to
subsequent PRs to see the actual usage.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
@dylanpbacon Hi Dylan, I updated the LIP related stuff and put it in this
[branch](https://github.com/apache/incubator-quickstep/tree/Hash-Join-Fuse),
you may just fetch the changes
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/321
LGTM! Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/323
Merged
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/323
LGTM! Can you squash the two commits into one and then I can merge this PR.
(To squash the two commits, go to the repo, `git rebase -i HEAD~2`, change
the second `pick
GS} -Werror")
Line 588
<https://github.com/apache/incubator-quickstep/blob/master/CMakeLists.txt#L588>
: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-return-type-c-linkage")
This should fix the problem for gcc-6.3.. we may add systematic fixes for
different compiler versions la
It seems to be a problem related to C++ compiler version. Can you check its
version by using command:
gcc -v
The fix should be a few lines of changes in root directory's/glog's
CMakeLists.txt.
Best,
Jianqiao
2017-11-08 15:30 GMT-06:00 Om Jadhav <ojad...@wisc.edu>:
> Hi Jianqiao,
&
Hi Om,
It seems that your "cmake" output is okay. Can you also provide the "make"
error message?
Best,
Jianqiao
2017-11-06 11:34 GMT-06:00 Harshad Deshmukh <hars...@cs.wisc.edu>:
> Hi Om,
>
> What's your build setup? Did you download the prerequisites a
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/320
It may just be fine before `ExecutionGenerator`, I think the fix is to
revise `ExecutionGenerator::convertInsertTuple()` and do some modifications
inside `InsertOperator`.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/316
LGTM! Will merge after travis-ci's tests.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/314
LGTM! Merging.
---
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/315
[DO NOT MERGE] Refactor type system to provide better extensibility of
types and functions
This is a preliminary PR that is not ready to be merged but provides an
overall view
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/304
LGTM! Merging.
---
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/299#discussion_r140061423
--- Diff: cli/LineReader.cpp ---
@@ -171,7 +173,7 @@ std::string LineReader::getNextCommand() {
case
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/299#discussion_r140060711
--- Diff: cli/tests/command_executor/D.test ---
@@ -69,6 +71,7 @@ INSERT INTO foo3 values(5, 1, 1.0, 1.0, 'XYZZ');
col4 | Float
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/299
QUICKSTEP-104 Fix the problem that LineReader cannot recognize a command if
there are whitespaces before it.
This PR fixes a bug that the Quickstep REPL cannot recognize a command
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/298
LGTM. Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/297
LGTM. Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/271
LGTM. Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/296
LGTM. Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/293
LGTM. Merging.
---
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199350
--- Diff: relational_operators/TextScanOperator.cpp ---
@@ -82,14 +81,19 @@ static bool ValidateTextScanTextSegmentSize(const char
*flagname
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198329
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -143,6 +145,45 @@ namespace E = ::quickstep::optimizer::expressions;
namespace L
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136197963
--- Diff: query_optimizer/logical/LogicalType.hpp ---
@@ -34,6 +34,7 @@ namespace logical {
enum class LogicalType {
kAggregate
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136197848
--- Diff: query_optimizer/logical/CopyTo.hpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136180815
--- Diff: query_optimizer/logical/CopyFrom.hpp ---
@@ -66,20 +67,14 @@ class CopyFrom : public Logical {
const std::string& file_
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136178849
--- Diff: parser/ParseStatement.hpp ---
@@ -771,122 +776,135 @@ class ParseStatementInsertSelection : public
ParseStatementInsert
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199193
--- Diff: relational_operators/TableExportOperator.hpp ---
@@ -0,0 +1,268 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198182
--- Diff: query_optimizer/physical/CopyFrom.hpp ---
@@ -68,22 +69,14 @@ class CopyFrom : public Physical {
const std::string& file_
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198572
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198255
--- Diff: query_optimizer/physical/CopyTo.hpp ---
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198306
--- Diff: query_optimizer/physical/PhysicalType.hpp ---
@@ -34,6 +34,7 @@ namespace physical {
enum class PhysicalType {
kAggregate
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198462
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198547
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199047
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1595,6 +1742,19 @@ void
Resolver::appendProjectIfNeedPrecomputationAfterAggregation
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199940
--- Diff: utility/ExecutionDAGVisualizer.cpp ---
@@ -55,12 +55,15 @@ using std::to_string;
namespace quickstep {
DEFINE_bool
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199148
--- Diff: relational_operators/TableExportOperator.hpp ---
@@ -0,0 +1,268 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198676
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199029
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136178749
--- Diff: parser/ParseStatement.hpp ---
@@ -60,16 +60,16 @@ class ParseStatement : public ParseTreeNode {
* @brief The possible types
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136175863
--- Diff: parser/ParseKeyValue.hpp ---
@@ -37,14 +37,15 @@ namespace quickstep {
*/
class ParseKeyValue : public ParseTreeNode
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/291
Add "COPY TO" operator for exporting data from Quickstep.
This PR adds support for the "COPY TO" statement for exporting tables from
Quickstep. Two for
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/289
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/290
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/282
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/280
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/279
I think the PR looks good and the code structure is convenient for further
adjustment. So merge it now so that @zuyu can continue the work on
partition-aware scheduling.
---
If your
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/276
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/274
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/273
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/265
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/264
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/270
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/267
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/257
Good refactoring. LGTM! Except one place in `PhysicalGenerator.cpp`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/257#discussion_r122326409
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -176,6 +177,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/249
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/252
LGTM. Can you rebase the commit w.r.t. the current master HEAD? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/246
Improve disjunctive predicate pushdown to optimize more scenarios
This PR improves the `PushDownLowCostDisjunctivePredicate` optimization to
consider more applicable scenarios
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/244
Fix a problem in CopyGroupList + minor style fixes
This PR adjusts the implementation of `CopyGroupList::merge_contiguous()`
to handle some cases correctly.
E.g. let `R
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r113070938
--- Diff: query_optimizer/expressions/Scalar.hpp ---
@@ -65,10 +67,49 @@ class Scalar : public Expression {
const std::unordered_map
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r113070668
--- Diff: query_optimizer/expressions/Scalar.hpp ---
@@ -65,10 +67,49 @@ class Scalar : public Expression {
const std::unordered_map
1 - 100 of 233 matches
Mail list logo
