Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
@shroman
what are your recommendations on how to treat the storage module? Should I
create a JIRA issue if I find a problem, but not work on it?
yeah, if you find some
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
Ok, guys, I set the fix version of the JIRA issue to 4.1.0 then ð
@vongosling what are your recommendations on how to treat the storage
module? Should I create a JIRA issue if I fin
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user lollipopjin commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/22
@lizhanhui Could you please verify mentioned problem, no matter using unit
or other ways. At last, please fix the conflict problem.
---
If your project is set up for it, you can reply
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user lollipopjin commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/18
@dongeforever Thanks for you PR, we will add some notes in the example to
eliminate confuse. :-)
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/22
[ROCKETMQ-25] Possible data race while query msg by key
Refer to JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-25
You can merge this pull request into a Git repository by running
Github user lollipopjin commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/17
@Zhang-Ke Thanks for your PR, Could you please verify mentioned problem, no
matter using unit or other ways. At last, please fix the conflict problem.
---
If your project is set up fo
Github user lollipopjin commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/6
@shroman Could you please squash your commits and fix conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lollipopjin commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/3
@shroman Could you please squash your commits and fix conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/21
That's ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/19
IMO, we could close this pr without any more works @lollipopjin
thanks @Jaskey
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
We must keep cautious about storage polish, although some minor rename.
IMO, Could we optimize here in the 4.1.0 or more later version :-)
---
If your project is set up for it, you ca
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103833
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -68,10 +68,10 @@ private void syncTopicConfig() {
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103841
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -85,9 +85,9 @@ private void syncConsumerOffset() {
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103642
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/filtersrv/FilterServerUtil.java
---
@@ -26,9 +26,9 @@ public static void callShell(fi
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103929
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java
---
@@ -247,6 +248,7 @@ public void exec
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103845
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -106,12 +106,12 @@ private void syncDelayOffset() {
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103933
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java
---
@@ -258,6 +260,7 @@ public void exec
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103915
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java
---
@@ -228,6 +228,7 @@ public void subs
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103864
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -134,10 +134,10 @@ private void syncSubscriptionGro
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103499
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java ---
@@ -497,7 +497,7 @@ private void printMasterAndSlaveDiff() {
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103857
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -106,12 +106,12 @@ private void syncDelayOffset() {
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/8
please modify you PR subject and fix conflict problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94101719
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -1150,15 +1150,15 @@ public AppendMessageResult doAppend(final long
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
@zhouxinyu I made changes according to your comments, and added more tests.
In {{CommitLog.FlushRealTimeService#run()}}, we will try to flush as long
as the data is available or {{MAX_F
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94101409
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -1134,10 +1131,10 @@ public ConsumerRunningI
Github user lollipopjin commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/21
@lizhanhui
`
1.7
1.7
` Already
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94101345
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -469,6 +467,7 @@ private void onExceptionImpl(final St
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/21
@zhouxinyu This PR introduces grammar of Java 7, say diamond. Do you plan
to upgrade the language compatible version?
---
If your project is set up for it, you can reply to this email
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/21
It seems ok for me. @lollipopjin please review this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Von,
The JIRA issue for which you provided the link is actually about updating
the package path, not the git commit history. I was referring to the git
commit history of the code base from the Github repo. I think it's best to
bring in the Github commit history along with the actual source code.
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94050231
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -964,9 +964,11 @@ public void run() {
boolean result
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94046163
--- Diff:
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
@@ -39,11 +39,15 @@
private final int mappedFileS
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94045874
--- Diff:
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
@@ -39,11 +39,15 @@
private final int mappedFileSiz
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94045317
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -964,9 +964,11 @@ public void run() {
boolean resul
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94045250
--- Diff:
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
@@ -191,7 +199,7 @@ public long howMuchFallBehind() {
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
please @vongosling @lollipopjin review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94043543
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -964,9 +964,11 @@ public void run() {
boolean result
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94043135
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -964,9 +964,11 @@ public void run() {
boolean resul
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94042593
--- Diff:
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
@@ -191,7 +199,7 @@ public long howMuchFallBehind() {
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94042046
--- Diff:
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
@@ -39,11 +39,15 @@
private final int mappedFileS
Dear podling,
This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.
The board meeting is scheduled for Wed, 18 January 2017, 10:30 am PDT.
The report for your podling will form
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
Hi, the github says "This branch has no conflicts with the base branch"
I think conflicts are resolved.
Reviewing it by several committers is already being cautious, isn't it? ;
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
Hi, shroman
Could you please resolve conflicts in this pr?
And we will remain cautious about the changes of rocketmq-store module, so
this pr may be won't merge quickly.
GitHub user dongeforever opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/21
[ROCKETMQ-18]Clean code prompted by IntelliJ
Clean code prompted by IntelliJ for branch 'ROCKETMQ-18'.
@vongosling @zhouxinyu please take a time to review it.
You can merge
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
@vongosling Does `RETRY_TIMES_OVER` here means retries on failures, or the
number of times to flush on success? I think the former, but need to be sure I
understand the intentions of the p
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/20
[ROCKETMQ-23] MappedFileQueue#flush should return true when flushing â¦
â¦is successful.
Jira issue: https://issues.apache.org/jira/browse/ROCKETMQ-23
You can merge this pull r
51 matches
Mail list logo
