Re: Review Request 34085: SENTRY-733: Update notification handler for grant user to role

2016-03-31 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34085/#review126556 --- Ship it! Ship It! - Dapeng Sun On 五月 12, 2015, 3:08 p.m., Co

Re: Review Request 34087: SENTRY-735: Update AuthorizationProvider and e2e test for grant user to role

2016-03-31 Thread Jerry Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34087/#review126549 --- sentry-provider/sentry-provider-common/src/main/java/org/apache/s

Re: Review Request 34083: SENTRY-731: Update provider-backend for grant user to role

2016-03-31 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34083/#review126550 --- Thank Colin, some comments left. sentry-provider/sentry-provider

Re: Review Request 34082: SENTRY-730: Update policy engine for grant user to role

2016-03-31 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34082/#review126548 --- sentry-policy/sentry-policy-common/src/main/java/org/apache/sentr

Re: Review Request 34081: SENTRY-729: Update binding-hive for grant user to role

2016-03-31 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34081/#review126547 --- sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentr

Re: Review Request 34080: SENTRY-728: Update audit log for grant user to role

2016-03-31 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34080/#review126533 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 34086: SENTRY-734: Update SentryPolicyStoreProcessor for grant user to role

2016-03-31 Thread Jerry Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34086/#review126529 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 34079: SENTRY-727: Update jdo model for grant user to role

2016-03-31 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34079/#review126520 --- Thank Colin for your contribution, I left some comments. sentry-

Re: Review Request 34085: SENTRY-733: Update notification handler for grant user to role

2016-03-31 Thread Jerry Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34085/#review126527 --- LGTM - Jerry Chen On May 12, 2015, 7:08 a.m., Colin Ma wrote: >

Re: Review Request 34084: SENTRY-732: Update sentry plugin for grant user to role

2016-03-31 Thread Jerry Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34084/#review126522 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 34083: SENTRY-731: Update provider-backend for grant user to role

2016-03-31 Thread Jerry Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34083/#review126517 --- sentry-provider/sentry-provider-cache/src/main/java/org/apache/se

Re: Review Request 34082: SENTRY-730: Update policy engine for grant user to role

2016-03-31 Thread Jerry Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34082/#review126515 --- sentry-policy/sentry-policy-common/src/main/java/org/apache/sentr

Re: Review Request 34078: SENTRY-726: Update thrift API for grant user to role

2016-03-31 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34078/#review126513 --- sentry-provider/sentry-provider-db/src/main/resources/sentry_poli

Re: Review Request 34081: SENTRY-729: Update binding-hive for grant user to role

2016-03-31 Thread Jerry Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34081/#review126514 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoo

Re: Review Request 34078: SENTRY-726: Update thrift API for grant user to role

2016-03-31 Thread Jerry Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34078/#review126512 --- sentry-provider/sentry-provider-db/src/main/resources/sentry_poli

Re: Review Request 34080: SENTRY-728: Update audit log for grant user to role

2016-03-31 Thread Jerry Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34080/#review126509 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 34079: SENTRY-727: Update jdo model for grant user to role

2016-03-31 Thread Jerry Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34079/#review126284 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 45221: Add a test run to exclude slow and not thread safe tests. It could be used for pre-commit jobs

2016-03-31 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45221/ --- (Updated April 1, 2016, 12:03 a.m.) Review request for sentry and Hao Hao. Ch

Re: Review Request 45502: SENTRY-1164: fix one e2e test failure on a real cluster; improved concurrent tests to be able to run locally.

2016-03-31 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45502/ --- (Updated March 31, 2016, 11:19 p.m.) Review request for sentry and Hao Hao. C

Re: Review Request 45502: SENTRY-1164: fix one e2e test failure on a real cluster; improved concurrent tests to be able to run locally.

2016-03-31 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45502/#review126433 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te

Re: Review Request 45502: SENTRY-1164: fix one e2e test failure on a real cluster; improved concurrent tests to be able to run locally.

2016-03-31 Thread Anne Yu
> On March 31, 2016, 7:06 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java, > > line 323 > > > > > > Will the URI scheme be chan

Re: Review Request 45502: SENTRY-1164: fix one e2e test failure on a real cluster; improved concurrent tests to be able to run locally.

2016-03-31 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45502/#review126407 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te

Review Request 45550: Fix some "major" issues identified by Sonarqube

2016-03-31 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45550/ --- Review request for sentry. Repository: sentry Description --- Fix some "