Re: [DISCUSS] Merging Sentry HA branch with master

2017-04-04 Thread Alexander Kolbasov
I would like to make a more concrete proposal and I am interested in opinion from Sentry PMC members on this. I would propose the following approach for merging Sentry HA into Sentry master: Cherry-pick any commits that happened since sentry-ha-redesign was forked, except a few described below

Re: Review Request 58166: SENTRY-1692 ZK namespace configuration doesn't work

2017-04-04 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58166/#review171080 --- Ship it! Ship It! - Na Li On April 4, 2017, 5:03 a.m.,

Sentry-jdk-1.7 - Build # 773 - Failure

2017-04-04 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7 (build #773) Status: Failure Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/773/ to view the results.

Sentry-jdk-1.7-v2 - Build # 74 - Still Failing

2017-04-04 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #74) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/74/ to view the results.

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-04-04 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review171052 --- Ship it! Ship It! - Alexander Kolbasov On April 4, 2017,

Re: Review Request 58069: SENTRY-1670 Expose current HMS notification ID as a Sentry gauge (metric)

2017-04-04 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58069/#review171038 --- Ship it! Ship It! - Hao Hao On April 4, 2017, 8:33 p.m.,

Re: Review Request 58069: SENTRY-1670 Expose current HMS notification ID as a Sentry gauge (metric)

2017-04-04 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58069/ --- (Updated April 4, 2017, 8:33 p.m.) Review request for sentry, Hao Hao and

Re: Review Request 58069: SENTRY-1670 Expose current HMS notification ID as a Sentry gauge (metric)

2017-04-04 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58069/ --- (Updated April 4, 2017, 8:21 p.m.) Review request for sentry, Hao Hao and

Re: Review Request 58121: SENTRY-1677 Add metrics to measure how much time to get Delta Path/Perm Updates

2017-04-04 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58121/#review171033 --- Ship it! Ship It! - Na Li On March 31, 2017, 9:53 p.m.,

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-04-04 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review171020 --- Fix it, then Ship it! Ship It!

Re: Review Request 58069: SENTRY-1670 Expose current HMS notification ID as a Sentry gauge (metric)

2017-04-04 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58069/#review171021 --- Ship it! Ship It! - Na Li On March 30, 2017, 5:25 a.m.,

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-04 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171008 --- For tables that are new in sentry-ha-redesign branch, shouldn't

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-04 Thread Hao Hao
> On April 4, 2017, 4:40 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql > > Lines 1 (patched) > > > > > > Why create a new file for create notification id

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-04 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171003 ---

Re: Review Request 58131: SENTRY-1680: Removed MetastoreCacheInitializer

2017-04-04 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58131/#review170998 --- Ship it! Ship It! - Alexander Kolbasov On April 4, 2017,

Re: Review Request 58069: SENTRY-1670 Expose current HMS notification ID as a Sentry gauge (metric)

2017-04-04 Thread Hao Hao
> On April 4, 2017, 6:31 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 3167 (original), 3187 (patched) > > > > > >

Re: Review Request 58069: SENTRY-1670 Expose current HMS notification ID as a Sentry gauge (metric)

2017-04-04 Thread Alexander Kolbasov
> On April 4, 2017, 6:31 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 3167 (original), 3187 (patched) > > > > > >

Re: Review Request 58166: SENTRY-1692 ZK namespace configuration doesn't work

2017-04-04 Thread Alexander Kolbasov
> On April 4, 2017, 6:07 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java > > Line 96 (original) > > > > > > Not quite follow the

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-04 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review170983 --- - kalyan kumar kalvagadda On April 4, 2017, 5:05 p.m., kalyan

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-04 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 4, 2017, 5:05 p.m.) Review request for sentry, Alexander

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-04 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review170981 ---

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-04 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 4, 2017, 3:57 p.m.) Review request for sentry, Alexander

Re: Review Request 58131: SENTRY-1680: Removed MetastoreCacheInitializer

2017-04-04 Thread Jan Hentschel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58131/ --- (Updated April 4, 2017, 1:59 p.m.) Review request for sentry. Changes

Re: Review Request 58069: SENTRY-1670 Expose current HMS notification ID as a Sentry gauge (metric)

2017-04-04 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58069/#review170958 ---

Re: Review Request 58166: SENTRY-1692 ZK namespace configuration doesn't work

2017-04-04 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58166/#review170957 ---