Re: Review Request 58284: SENTRY-1687 FullUpdateInitializer can be more efficient

> On April 10, 2017, 3:56 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestFullUpdateInitializer.java > > Line 125 (original), 214 (patched) > > > > > > can we have the t

Re: Review Request 58284: SENTRY-1687 FullUpdateInitializer can be more efficient

> On April 10, 2017, 3:56 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java > > Line 128 (original), 221 (patched) > > > > > > should retries = i +

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review171517 --- Why do you want to actually recreate a new instance of HMSFollower

Re: Review Request 58267: SENTRY-1629 sql changed needed for MAuthzPathsMapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58267/#review171509 --- Fix it, then Ship it! Ship It! sentry-provider/sentry-provide

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review171256 --- Ship it! Ship It! - Alexander Kolbasov On April 7, 2017, 5:2

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/ --- (Updated April 10, 2017, 3:47 p.m.) Review request for sentry. Bugs: SENTRY-1

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

> On April 10, 2017, 12:58 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java > > Lines 75 (patched) > > > > > >

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

> On April 10, 2017, 2:57 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2592 (patched) > > > > > >

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/#review171494 --- Fix it, then Ship it! Ship It! sentry-provider/sentry-provide

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

> On April 10, 2017, 12:58 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java > > Lines 87 (patched) > > >

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 10, 2017, 6:50 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Line 312 (original), 317 (patched) > > > > > > Should we h

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 6, 2017, 7:04 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 310 (patched) > > > > > > Why not directly shutdown and

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/#review171464 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/ --- (Updated April 10, 2017, 12:54 p.m.) Review request for sentry. Bugs: SENTRY-

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

> On April 10, 2017, 11:37 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2581 (patched) > > > > > > Can you

Re: Review Request 58267: SENTRY-1629 sql changed needed for MAuthzPathsMapping.

> On April 7, 2017, 9:43 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Line 31 (original), 32 (patched) > > >

Re: Review Request 58267: SENTRY-1629 sql changed needed for MAuthzPathsMapping.

> On April 10, 2017, 5:42 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.postgres.sql > > Lines 15 (patched) > > > > > > If we want to store unique "PATH_Name" only once,

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review171459 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/#review171458 --- Fix it, then Ship it! sentry-provider/sentry-provider-db/src/t

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/#review171454 --- Ship it! Ship It! - Na Li On April 8, 2017, 12:38 a.m., Lei

Re: Review Request 58267: SENTRY-1629 sql changed needed for MAuthzPathsMapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58267/#review171451 --- sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

> On April 10, 2017, 9:25 a.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java > > Lines 87 (patched) > > > > > > Is it po

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/#review171444 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58284: SENTRY-1687 FullUpdateInitializer can be more efficient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58284/#review171443 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 58267: SENTRY-1629 sql changed needed for MAuthzPathsMapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58267/ --- (Updated April 10, 2017, 12:44 p.m.) Review request for sentry, Alexander Kolba