Sentry-jdk-1.7 - Build # 842 - Unstable

The Apache Jenkins build system has built Sentry-jdk-1.7 (build #842) Status: Unstable Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/842/ to view the results.

Sentry-jdk-1.7-v2 - Build # 142 - Still Failing

The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #142) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/142/ to view the results.

Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

> On Sept. 7, 2017, 2:20 a.m., Vamsee Yarlagadda wrote: > > IMPORTANT: > > http://github.mtv.cloudera.com/CDH/sentry/blob/cdh5-1.5.1/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java#L307-L312 > > We should handle the case when the HDFSSync is also

Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/#review184776 --- IMPORTANT: http://github.mtv.cloudera.com/CDH/sentry/blob/cdh5-1.5

Re: Review Request 62136: SENTRY-1928: HMSFollower should close HMS connections when an error to HMS occurs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62136/ --- (Updated Sept. 7, 2017, 1:37 a.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62136: SENTRY-1928: HMSFollower should close HMS connections when an error to HMS occurs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62136/#review184771 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 7, 2017, 1:2

Re: Review Request 62136: SENTRY-1928: HMSFollower should close HMS connections when an error to HMS occurs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62136/#review184770 --- Ship it! Ship It! - Vamsee Yarlagadda On Sept. 7, 2017, 1:24

Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/#review184769 --- Ship it! Ship It! - Vamsee Yarlagadda On Sept. 7, 2017, 1:27

Re: Review Request 62136: SENTRY-1928: HMSFollower should close HMS connections when an error to HMS occurs

> On Sept. 6, 2017, 11:37 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 98 (patched) > > > > > > Why can't

Re: Review Request 62136: SENTRY-1928: HMSFollower should close HMS connections when an error to HMS occurs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62136/#review184767 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/ --- Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamse

Re: Review Request 62136: SENTRY-1928: HMSFollower should close HMS connections when an error to HMS occurs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62136/ --- (Updated Sept. 7, 2017, 1:24 a.m.) Review request for sentry, Alexander Kolbaso

Sentry-jdk-1.7-v2 - Build # 141 - Still Failing

The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #141) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/141/ to view the results.

Sentry-jdk-1.7 - Build # 840 - Fixed

The Apache Jenkins build system has built Sentry-jdk-1.7 (build #840) Status: Fixed Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/840/ to view the results.

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

> On Sept. 5, 2017, 9:02 p.m., Vamsee Yarlagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Line 115 (original), 122 (patched) > > > > > > What would pr

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

> On Sept. 6, 2017, 11:10 a.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 86-90 (patched) > > > > > > This code is repeated twice. Sho

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184760 --- Of note, there is no reason to be concerned about concurrency with

Re: Review Request 62136: SENTRY-1928: HMSFollower should close HMS connections when an error to HMS occurs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62136/#review184757 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 6, 2017, 6:33 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62136: SENTRY-1928: HMSFollower should close HMS connections when an error to HMS occurs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62136/#review184752 --- Fix it, then Ship it! Ship It! sentry-provider/sentry-provide

Review Request 62136: SENTRY-1928: HMSFollower should close HMS connections when an error to HMS occurs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62136/ --- Review request for sentry, Alexander Kolbasov and Vamsee Yarlagadda. Bugs: sent

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

> On Sept. 6, 2017, 7:09 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2760 (patched) > > > > > > Do we need to i

Re: Review Request 62107: Post review changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184747 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

> On Sept. 6, 2017, 7:09 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2760 (patched) > > > > > > Do we need to i

Sentry-jdk-1.7-v2 - Build # 140 - Still Failing

The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #140) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/140/ to view the results.

Sentry-jdk-1.7 - Build # 839 - Still Failing

The Apache Jenkins build system has built Sentry-jdk-1.7 (build #839) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/839/ to view the results.

Sentry-jdk-1.7 - Build # 838 - Failure

The Apache Jenkins build system has built Sentry-jdk-1.7 (build #838) Status: Failure Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/838/ to view the results.

Re: Review Request 62131: Sentry should not store paths outside of the prefix

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62131/#review184730 --- Ship it! Ship It! - Mat Crocker On Sept. 6, 2017, 7:28 p.m.,

Re: Review Request 62131: Sentry should not store paths outside of the prefix

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62131/#review184718 --- Ship it! Ship It! - Vamsee Yarlagadda On Sept. 6, 2017, 7:26

Re: Review Request 62107: Post review changes

> On Sept. 6, 2017, 2:02 a.m., Vamsee Yarlagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Line 115 (original), 122 (patched) > > > > > > What would pr

Review Request 62131: Sentry should not store paths outside of the prefix

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62131/ --- Review request for sentry and Alexander Kolbasov. Repository: sentry Descript

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62112/#review184715 --- Ship it! Ship It! - Sergio Pena On Sept. 6, 2017, 6:48 p.m.,

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62112/#review184713 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

> On Sept. 6, 2017, 3:46 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceProcessor.java > > Line 80 (original), 83 (patched) > > > > > > If we ret

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62112/ --- (Updated Sept. 6, 2017, 6:48 p.m.) Review request for sentry, Arjun Mishra, Bri

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

> On Sept. 6, 2017, 3:46 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > > Line 86 (original) > > > > > > Should we keep these metrics here?

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

> On Sept. 6, 2017, 3:46 p.m., Sergio Pena wrote: > > Should we do the same change on PermImageRetriever as well? It is doing the > > same thing as PathImageRetriever. > > Alexander Kolbasov wrote: > Possibly, but I think it is much less important - it is usual to have > lots and lots of p

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

> On Sept. 6, 2017, 3:46 p.m., Sergio Pena wrote: > > Should we do the same change on PermImageRetriever as well? It is doing the > > same thing as PathImageRetriever. > > Alexander Kolbasov wrote: > Possibly, but I think it is much less important - it is usual to have > lots and lots of p

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

> On Sept. 6, 2017, 3:46 p.m., Sergio Pena wrote: > > Should we do the same change on PermImageRetriever as well? It is doing the > > same thing as PathImageRetriever. Possibly, but I think it is much less important - it is usual to have lots and lots of partitions, but not as usual to have th

Sentry-jdk-1.7 - Build # 837 - Unstable

The Apache Jenkins build system has built Sentry-jdk-1.7 (build #837) Status: Unstable Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/837/ to view the results.

Re: Review Request 62107: Post review changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184692 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 62107: Post review changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184691 --- I added an additional unit test for a missed case - Brian Towles

Re: Review Request 62107: Post review changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 6, 2017, 10:52 a.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 62107: Post review changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 6, 2017, 10:52 a.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62112/#review184689 --- Should we do the same change on PermImageRetriever as well? It is

Sentry-jdk-1.7-v2 - Build # 139 - Still Failing

The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #139) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/139/ to view the results.

Sentry-jdk-1.7 - Build # 836 - Failure

The Apache Jenkins build system has built Sentry-jdk-1.7 (build #836) Status: Failure Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/836/ to view the results.

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184681 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 6, 2017, 9:24 a.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

> On Sept. 6, 2017, 12:28 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 297 (patched) > > > > > > Can you add check (

Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62112/ --- Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamse