Re: Inconsistent commit messages

Sasha, I agree we should have consistent format. It is better to include author, then followed by reviewer. So we can have all information at a glance. Lina On Wed, Nov 1, 2017 at 8:04 PM, Alexander Kolbasov wrote: > Hello, > > I noticed that recently our commit messages

Inconsistent commit messages

Hello, I noticed that recently our commit messages became veru inconsistent: The format we used to have: SENTRY-2014: incorrect handling of HDFS paths with multiple forward slashes (Vadim Spector, reviewed by Sergio Pena and Arjun Mishra) SENTRY-2015 - Refactor Command implementations -

Review Request 63488: SENTRY-2029: Unit test fails consistently for org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63488/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/#review189849 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 1,

Review Request 63335: SENTRY-2018: Remove SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63335/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2018

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/#review189823 --- These are my comments in initial pass. I'm still reviewing the

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

> On Nov. 1, 2017, 7:25 p.m., kalyan kumar kalvagadda wrote: > > Your description here is not in-line with the comments in jira. Jira states > > that intent of your change is to be in-line with the hive char set. Doing > > so it would solve another issue you may see. Please confirm. I have

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/ --- (Updated Nov. 1, 2017, 7:32 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/#review189827 --- Your description here is not in-line with the comments in jira.