Re: Review Request 63335: SENTRY-2018: Remove SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63335/ --- (Updated Nov. 9, 2017, 2:58 p.m.) Review request for sentry, Na Li and Sergio P

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/#review190589 --- What is the issue we are observing when this id is not set? - kal

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63415/ --- (Updated Nov. 9, 2017, 3:32 p.m.) Review request for sentry and Colm O hEigeart

Re: Sentry as a library

Hi Sasha, What problems do you think would solve or does this make things simpler in some way ? On Wed, Nov 8, 2017 at 11:50 PM, Alexander Kolbasov wrote: > What do you think about providing a ‘sentry service as a library’ which is > a wrapper that can run inside HMS and other consumers that wi

Re: Please add me as a contributor

PMC, Stephen Moist username is @moist, but I cannot add him to the JIRA as contributor (it does not find it). Anyone knows how to find him? On Wed, Nov 8, 2017 at 5:09 PM, Sergio Pena wrote: > Great, I can help on that. Btw, what is you Apache username? > > On Wed, Nov 8, 2017 at 4:18 PM, Steph

Re: Review Request 63667: SENTRY-2037: Remove not needed sentry-binding-hive-v2 dependency from the main pom.xml

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63667/#review190600 --- should we remove the definition of profile hive-authz2 as well? -

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

> On Nov. 9, 2017, 2:56 p.m., kalyan kumar kalvagadda wrote: > > What is the issue we are observing when this id is not set? When timeout exception occurs, id is not set. This is a mandatory field, so Thrift creates its own exception which replaces the original timeout exception. As a result,

Re: Review Request 63667: SENTRY-2037: Remove not needed sentry-binding-hive-v2 dependency from the main pom.xml

> On Nov. 9, 2017, 4:18 p.m., Na Li wrote: > > should we remove the definition of profile hive-authz2 as well? Not yet. The idea is to keep this profile for a little while until we make sure the transition is completely (without issues). There is still code and tests that could have been forgo

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/ --- (Updated Nov. 9, 2017, 4:34 p.m.) Review request for sentry. Changes ---

Review Request 63704: SENTRY-1662 Constants java uses mutable collection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63704/ --- Review request for sentry. Bugs: SENTRY-1662 https://issues.apache.org/jira

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/#review190613 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 63667: SENTRY-2037: Remove not needed sentry-binding-hive-v2 dependency from the main pom.xml

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63667/#review190614 --- Ship it! Ship It! - Na Li On Nov. 8, 2017, 3 p.m., Sergio Pe

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

> On Nov. 9, 2017, 5:27 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1164 (patched) > > > > > > Can w

Re: Please add me as a contributor

Done Stephen. The issue was that I had to write the complete account email to find you. On Thu, Nov 9, 2017 at 10:14 AM, Sergio Pena wrote: > PMC, > > Stephen Moist username is @moist, but I cannot add him to the JIRA as > contributor (it does not find it). Anyone knows how to find him? > > On

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/#review190617 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 7, 2017,

Re: Review Request 63335: SENTRY-2018: Remove SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63335/#review190624 --- Ship it! Ship It! - Sergio Pena On Nov. 9, 2017, 2:58 p.m.,

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/#review190627 --- sentry-core/sentry-core-common/src/test/java/org/apache/sentry/co

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/ --- (Updated Nov. 9, 2017, 6:51 p.m.) Review request for sentry. Bugs: sentry-203

Re: Review Request 63704: SENTRY-1662 Constants java uses mutable collection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63704/ --- (Updated Nov. 9, 2017, 7:32 p.m.) Review request for sentry. Bugs: SENTRY-166

Re: Review Request 63704: SENTRY-1662 Constants java uses mutable collection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63704/#review190635 --- Ship it! Ship It! - Alexander Kolbasov On Nov. 9, 2017, 7:32

Re: Review Request 63704: SENTRY-1662 Constants java uses mutable collection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63704/#review190637 --- Ship it! Ship It! - Na Li On Nov. 9, 2017, 7:32 p.m., Steve

Re: Review Request 63704: SENTRY-1662 Constants java uses mutable collection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63704/ --- (Updated Nov. 9, 2017, 9:03 p.m.) Review request for sentry. Bugs: SENTRY-166

Review Request 63709: SENTRY-2041: Change Index name in Package.jdo to match index name in SQL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63709/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pen

Re: Review Request 63667: SENTRY-2037: Remove not needed sentry-binding-hive-v2 dependency from the main pom.xml

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63667/#review190651 --- Ship it! Ship It! - Alexander Kolbasov On Nov. 8, 2017, 3 p.

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/ --- (Updated Nov. 9, 2017, 11:44 p.m.) Review request for sentry. Bugs: sentry-20

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/#review190654 --- Fix it, then Ship it! Ship It! sentry-core/sentry-core-common

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/#review190657 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co