Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

2018-08-23 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review207847 ---

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

2018-08-23 Thread Brian Towles via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/ --- (Updated Aug. 23, 2018, 8:15 p.m.) Review request for sentry, Anthony

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

2018-08-23 Thread Brian Towles via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/ --- (Updated Aug. 23, 2018, 3:26 p.m.) Review request for sentry, Anthony

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving entities by other entity types

2018-08-23 Thread Arjun Mishra via Review Board
> On Aug. 22, 2018, 5:37 p.m., kalyan kumar kalvagadda wrote: > > Arjun, > > > > I see you added fetching groups in a lot of API's. Do we know if there wil > > be performence benifit in all the cases to to have fetch plan and avoid > > loose fetching? > > Na Li wrote: > I have worked

Re: Review Request 68487: SENTRY-2366: Exclude jackson transitive dependencies

2018-08-23 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68487/ --- (Updated Aug. 23, 2018, 7:20 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

2018-08-23 Thread Brian Towles via Review Board
> On Aug. 23, 2018, 1:48 p.m., Na Li wrote: > > sentry-dist/src/license/THIRD-PARTY.properties > > Line 32 (original), 32 (patched) > > > > > > do we need to commit this file? Nope didnt mean to, will pull from

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

2018-08-23 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review207825 --- sentry-dist/src/license/THIRD-PARTY.properties Line 32

Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

2018-08-23 Thread Brian Towles via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/ --- Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na

Re: Review Request 68487: SENTRY-2366: Exclude jackson transitive dependencies

2018-08-23 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68487/#review207819 --- sentry-solr/solr-sentry-handlers/pom.xml Lines 94-103 (patched)

Re: Review Request 68487: SENTRY-2366: Exclude jackson transitive dependencies

2018-08-23 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68487/#review207817 --- Just make sure I understand the patch. This patch avoids the

Review Request 68487: SENTRY-2366: Exclude jackson transitive dependencies

2018-08-23 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68487/ --- Review request for sentry. Bugs: sentry-2366