Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171885 --- Ship it! Ship It! - Na Li On April 7, 2017, 9:56 p.m.,

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171847 --- Ship it! Ship It! - Hao Hao On April 7, 2017, 9:56 p.m.,

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

> On April 6, 2017, 12:41 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql > > Lines 5 (patched) > > > > > > Am I missing something? why is still

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 7, 2017, 9:56 p.m.) Review request for sentry, Alexander

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171237 ---

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 6, 2017, 2:17 p.m.) Review request for sentry, Alexander

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

> On April 4, 2017, 4:40 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql > > Lines 1 (patched) > > > > > > Why create a new file for create notification id

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171013 ---

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 6, 2017, 1:38 p.m.) Review request for sentry, Alexander

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 6, 2017, 12:49 a.m.) Review request for sentry, Alexander

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171184 ---

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171182 --- Ship it! Ship It! - Alexander Kolbasov On April 6, 2017,

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

> On April 4, 2017, 4:33 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java > > Line 30 (original), 30 (patched) > > > > > > I

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

> On April 6, 2017, 12:01 a.m., Alexander Kolbasov wrote: > > I don't see any changes to package.jdo announced at the header - are they > > missing? Updated the header > On April 6, 2017, 12:01 a.m., Alexander Kolbasov wrote: > >

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

> On April 4, 2017, 6:29 p.m., Alexander Kolbasov wrote: > > For tables that are new in sentry-ha-redesign branch, shouldn't we just > > update the initial creation scripts rather then add new scripts to fix the > > tables? If we need to that we need to move all the other commits done in

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 6, 2017, 12:05 a.m.) Review request for sentry, Alexander

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171172 --- I don't see any changes to package.jdo announced at the header -

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171008 --- For tables that are new in sentry-ha-redesign branch, shouldn't

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

> On April 4, 2017, 4:40 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql > > Lines 1 (patched) > > > > > > Why create a new file for create notification id

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171003 ---

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review170983 --- - kalyan kumar kalvagadda On April 4, 2017, 5:05 p.m., kalyan

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 4, 2017, 5:05 p.m.) Review request for sentry, Alexander

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review170981 ---

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 4, 2017, 3:57 p.m.) Review request for sentry, Alexander