Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

> On Sept. 7, 2017, 4:34 p.m., Sergio Pena wrote: > > The SQL files for derby and DB2 do have 4000 characters long on the fields > > you just modified. Should we change those as well? > > Na Li wrote: > I know that. Changing those will require changing sql files. Since they > are not

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

> On Sept. 7, 2017, 4:34 p.m., Sergio Pena wrote: > > The SQL files for derby and DB2 do have 4000 characters long on the fields > > you just modified. Should we change those as well? > > Na Li wrote: > I know that. Changing those will require changing sql files. Since they > are not

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

> On Sept. 8, 2017, 6:05 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Line 122 (original) > > > > > > This change

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/#review184946 ---

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

> On Sept. 7, 2017, 4:34 p.m., Sergio Pena wrote: > > The SQL files for derby and DB2 do have 4000 characters long on the fields > > you just modified. Should we change those as well? I know that. Changing those will require changing sql files. Since they are not causing any issue, I will

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/#review184838 --- The SQL files for derby and DB2 do have 4000 characters long on

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/ --- (Updated Sept. 1, 2017, 9:53 p.m.) Review request for sentry, Alexander

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

> On Aug. 28, 2017, 5:03 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Line 135 (original), 126 (patched) > > > > > >

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/ --- (Updated Aug. 28, 2017, 11:09 p.m.) Review request for sentry, Alexander

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

> On Aug. 28, 2017, 5:16 p.m., Alexander Kolbasov wrote: > > For MySQL I see this: > > > > ALTER TABLE `SENTRY_DB_PRIVILEGE` > > ADD UNIQUE `SENTRY_DB_PRIV_PRIV_NAME_UNIQ` > > (`SERVER_NAME`,`DB_NAME`,`TABLE_NAME`,`COLUMN_NAME`,`URI`(250),`ACTION`,`WITH_GRANT_OPTION`); > > > > Does it

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

> On Aug. 28, 2017, 5:16 p.m., Alexander Kolbasov wrote: > > For MySQL I see this: > > > > ALTER TABLE `SENTRY_DB_PRIVILEGE` > > ADD UNIQUE `SENTRY_DB_PRIV_PRIV_NAME_UNIQ` > > (`SERVER_NAME`,`DB_NAME`,`TABLE_NAME`,`COLUMN_NAME`,`URI`(250),`ACTION`,`WITH_GRANT_OPTION`); > > > > Does it

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

> On Aug. 28, 2017, 5:03 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Line 135 (original), 126 (patched) > > > > > >

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/#review183955 --- For MySQL I see this: ALTER TABLE `SENTRY_DB_PRIVILEGE`

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/#review183954 ---

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/ --- (Updated Aug. 25, 2017, 7:25 p.m.) Review request for sentry, Alexander

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/#review183383 ---

Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/ --- Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vamsee