Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review204197 --- Ship it! Ship It! - Sergio Pena On June 1, 2018, 6:13 p.m.,

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/ --- (Updated June 1, 2018, 6:13 p.m.) Review request for sentry, Alexander

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 22, 2018, 6:56 p.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 146 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/ --- (Updated Feb. 23, 2018, 5:16 p.m.) Review request for sentry, Alexander

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/ --- (Updated Feb. 23, 2018, 7 a.m.) Review request for sentry, Alexander Kolbasov,

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/ --- (Updated Feb. 23, 2018, 6:56 a.m.) Review request for sentry, Alexander

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 22, 2018, 6:56 p.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 146 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 22, 2018, 6:56 p.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 146 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 22, 2018, 7:43 p.m., Steve Moist wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 157 (patched) > > > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 22, 2018, 7:43 p.m., Steve Moist wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 141 (patched) > > > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 22, 2018, 6:56 p.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Line 96 (original), 98 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 22, 2018, 6:56 p.m., Alexander Kolbasov wrote: > > Does the test show the problem before the fix? The original test did not fail because the HMSFollower polling interval was configured to be 50 ms. I increased it to be 2 seconds, and the test failed with and without the fix. Then I

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 21, 2018, 5:13 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 135 (patched) > > > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 22, 2018, 5:52 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2412-2413 (patched) > > > > > > Is

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review198135 ---

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review198133 --- Does the test show the problem before the fix?

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/ --- (Updated Feb. 22, 2018, 6:55 p.m.) Review request for sentry, Alexander

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review198129 ---

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 22, 2018, 5:52 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 135-136 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review198124 ---

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 21, 2018, 5:13 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 137-140 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 21, 2018, 5:13 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 137-140 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/ --- (Updated Feb. 22, 2018, 1:28 a.m.) Review request for sentry, Alexander

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 21, 2018, 5:13 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 137-140 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review197995 --- I'm not sure if sentry has a test that performs a table rename

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 21, 2018, 7:01 p.m., kalyan kumar kalvagadda wrote: > > I'm not sure if sentry has a test that performs a table rename and > > immediatly peforms an hive operation that uses the new table name. I did a > > quick search and did not find any. > > If sentry doesn't have them we need to

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 21, 2018, 5:13 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 137-140 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review197936 ---

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/ --- (Updated Feb. 21, 2018, 4:52 p.m.) Review request for sentry, Alexander

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 18, 2018, 5:29 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Line 96 (original), 96 (patched) > >

Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/ --- Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and