Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review208463 --- Ship it! Ship It! - Na Li On Aug. 31, 2018, 4:03 p.m.,

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review208318 --- Ship it! Ship It! - Steve Moist On Aug. 31, 2018, 4:03

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review208179 --- sentry-spi/pom.xml Lines 45 (patched)

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 27, 2018, 8:32 p.m., Steve Moist wrote: > > pom.xml > > Lines 410 (patched) > > > > > > Why is this provided? > > Brian Towles wrote: > Lombok only hooks on the compile and modified the output classes

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 27, 2018, 3:32 p.m., Steve Moist wrote: > > pom.xml > > Lines 410 (patched) > > > > > > Why is this provided? > > Brian Towles wrote: > Lombok only hooks on the compile and modified the output classes

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 29, 2018, 3:29 p.m., Steve Moist wrote: > > lombok.config > > Lines 1 (patched) > > > > > > In introducing lombok into sentry. Will the configs for the existing > > sl4j need to be updated or modified? > >

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/ --- (Updated Aug. 31, 2018, 11:03 a.m.) Review request for sentry, Anthony

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 27, 2018, 8:32 p.m., Steve Moist wrote: > > pom.xml > > Lines 410 (patched) > > > > > > Why is this provided? > > Brian Towles wrote: > Lombok only hooks on the compile and modified the output classes

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 29, 2018, 3:29 p.m., Steve Moist wrote: > > lombok.config > > Lines 1 (patched) > > > > > > In introducing lombok into sentry. Will the configs for the existing > > sl4j need to be updated or modified? > >

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 29, 2018, 8:29 p.m., Steve Moist wrote: > > lombok.config > > Lines 1 (patched) > > > > > > In introducing lombok into sentry. Will the configs for the existing > > sl4j need to be updated or modified? > >

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 27, 2018, 3:32 p.m., Steve Moist wrote: > > pom.xml > > Lines 410 (patched) > > > > > > Why is this provided? Lombok only hooks on the compile and modified the output classes directly. You dont need to

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review207990 --- pom.xml Lines 410 (patched)

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 23, 2018, 8:54 p.m., Alexander Kolbasov wrote: > > sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java > > Lines 27 (patched) > > > > > > What is this file - where does it come from?

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review207847 ---

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/ --- (Updated Aug. 23, 2018, 8:15 p.m.) Review request for sentry, Anthony

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/ --- (Updated Aug. 23, 2018, 3:26 p.m.) Review request for sentry, Anthony

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 23, 2018, 1:48 p.m., Na Li wrote: > > sentry-dist/src/license/THIRD-PARTY.properties > > Line 32 (original), 32 (patched) > > > > > > do we need to commit this file? Nope didnt mean to, will pull from

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review207825 --- sentry-dist/src/license/THIRD-PARTY.properties Line 32

Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/ --- Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na