Failing to connect to https server through gadget

2011-10-12 Thread Tony Chan (tchan2)
Hi everyone, I'm having trouble connecting to an https server through my gadget. I'm not sure if it's because I've installed the self-signed certificate incorrectly in the cacerts file or because I'm doing my makeRequest incorrectly. If I do a keytool -list -keystore I can definitely see my

Re: Review Request: minor fix to allow EE and Action/Selection Sample to run under any context root out of box

2011-10-12 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2052/ --- (Updated 2011-10-12 20:54:19.017987) Review request for shindig, Paul Lindner, H

Re: OAuth 2.0 Commit Date

2011-10-12 Thread Henry Saputra
Cool! Thanks guys, awesome contributions. - Henry On Wed, Oct 12, 2011 at 1:17 PM, Eric Woods wrote: > Even better.  Both patches have been applied.  OAuth 2.0 is now supported in > Apache Shindig! > > Thanks everyone! > - Eric W.

Re: OAuth 2.0 Commit Date

2011-10-12 Thread Eric Woods
Even better. Both patches have been applied. OAuth 2.0 is now supported in Apache Shindig! Thanks everyone! - Eric W.

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-10-12 Thread Eric Woods
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/#review2540 --- Ship it! Patch applied! - Eric On 2011-10-10 20:41:02, Eric Woods

Re: Review Request: OAuth2.0 client implementation in Apache Shindig.

2011-10-12 Thread Eric Woods
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1947/#review2539 --- Ship it! Patch applied. Thanks Li & Adam! - Eric On 2011-10-12 14

Re: Review Request: Use injected config for rpc endpoint in common container service as defaults if not provided.

2011-10-12 Thread Dan Dumont
> On 2011-10-12 19:10:08, Paul Lindner wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js, > > line 36 > > > > > > for readability can you assign these to l

Re: Review Request: Use injected config for rpc endpoint in common container service as defaults if not provided.

2011-10-12 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2348/#review2537 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: Use injected config for rpc endpoint in common container service as defaults if not provided.

2011-10-12 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2348/#review2536 --- Dan, Thanks for the fix! it works and looks good to me. thanks, li -

Re: Review Request: Use injected config for rpc endpoint in common container service as defaults if not provided.

2011-10-12 Thread daviesd
Dan, Fix looks good and works for me. Thanks! doug On 10/11/11 3:00 PM, "Dan Dumont" wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2348/ > --

Re: Review Request: OAuth2.0 client implementation in Apache Shindig.

2011-10-12 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1947/#review2533 --- Ship it! Looks good for a drop. +1 - Henry On 2011-10-12 14:52:23,

Re: OAuth 2.0 Commit Date

2011-10-12 Thread Paul Lindner
I'd be fine with committing sooner. Code reviews are great and all, but if the code is in trunk then I can propose patches on top. On Wed, Oct 12, 2011 at 8:07 AM, Eric Woods wrote: > Updated patches have been posted for the OAuth 2.0 implementations, both > client and service provider. > > Cli

Re: Proposal: Moving PHP codebase to namespaces

2011-10-12 Thread Bastian Hofmann
Since there is no one opposing the proposal, I'll start to work on migrating our code base then. I recently wrote a tool to automate this for ResearchGate (will be OpenSource once I cleaned it up a bit and added a readme), so it should not take me too much time. On Wed, Sep 14, 2011 at 8:07 PM, Ag

Re: Review Request: Introduce abstract LockedDomainService implementation to enable easier customization

2011-10-12 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2333/ --- (Updated 2011-10-12 16:11:47.242307) Review request for shindig, Ryan Baxter and

Review Request: The sample Media.xml gadget does not support multiple instances in IE8

2011-10-12 Thread Michael Beaver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2358/ --- Review request for shindig. Summary --- The Media.xml gadget directly calls

OAuth 2.0 Commit Date

2011-10-12 Thread Eric Woods
Updated patches have been posted for the OAuth 2.0 implementations, both client and service provider. Client: https://reviews.apache.org/r/1947/ Documentation: http://docs.opensocial.org/display/OSD/OAuth+2.0+Consumer+Implementation+in+Apache+Shindig Service provider: https://reviews.apache.org

Re: Review Request: OAuth2.0 client implementation in Apache Shindig.

2011-10-12 Thread li xu
> On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java, > > line 24 > > > > > > Make sure the javadoc is complete agreed > On 20

Re: Review Request: OAuth2.0 client implementation in Apache Shindig.

2011-10-12 Thread li xu
--- Features included in this patch: 1. updated the patch to work with 20111012 trunk 2. minor fix to make it work with java15 as well 3. added back OAuth2 demo gadgets with Shindig Provider and verified with Shindig Service Provider patch (https://reviews.apache.org/r/1940/) Passed junit tests