Re: Proposal: Moving PHP codebase to namespaces

2011-12-08 Thread Bastian Hofmann
Hi, I just merged the refactoring back to trunk (see http://svn.apache.org/viewvc?limit_changes=0&view=revision&revision=1212179). Next things I'll be working on then on the PHP side is OAuth2 support for accessing the APIs and ActivityStrea.ms. Hopefully one of these should be ready before chris

Re: Changes To OAuth.json

2011-12-08 Thread Bastian Hofmann
Hi Ryan, sorry about that. This are some test credentials that I'm using to test Shindig locally which never should have been committed. I just removed them again (since this were no live credentials but just some from my local status.net instance, no harm is done by them becoming public and being

Changes To OAuth.json

2011-12-08 Thread Ryan J Baxter
Hi Bastian, I was looking at the oauth.json file and saw you added an entry for http://localhost:8080/statusnet_gadget_2nd/statusnet_gadget.xml, however I don't see that gadget checked in, is this entry actually used? -Ryan Email: rjbax...@us.ibm.com Phone: 978-899-3041 developerWorks Profile

Re: OAUTH2 ClientAuthenticationHandler: No access to security token

2011-12-08 Thread daviesd
We were having the same discussion here. Stayed tune... I have my project for tomorrow. :) doug On 12/8/11 3:50 PM, "Li Xu" wrote: > I see. Just a thought, Inject an OAuth2RequestParameterGenerator here might > be helpful...It could provide a function to generate parameter based on > HttpRequ

Re: OAUTH2 ClientAuthenticationHandler: No access to security token

2011-12-08 Thread Li Xu
I see. Just a thought, Inject an OAuth2RequestParameterGenerator here might be helpful...It could provide a function to generate parameter based on HttpRequest. The default implemenation doesn't have to generate any parameter. thanks, li > >

Re: OAUTH2 ClientAuthenticationHandler: No access to security token

2011-12-08 Thread daviesd
I guess my disconnect is that OUR implementation of the GrantRequestHandler used the security token to PULL OUT the value we needed. In other words our container had set the security token with trustedJson that held the extra parameters we needed. Thus when the intial makeRequest happened, the 's

Re: OAUTH2 ClientAuthenticationHandler: No access to security token

2011-12-08 Thread Li Xu
Hi Doug, Sure, np. Yes, it's hard to filter the parameter. Maybe all the query parameters as a first step? NO need to say sorry... we have all been new to Shindig once before. Let's still use the same issue and review request to keep track of this. When a new patch is ready, please just upload the

Re: OAUTH2 ClientAuthenticationHandler: No access to security token

2011-12-08 Thread A Clarke
I agree with Li's suggested approach. Making the request parameters available on the OAuth2Accessor means they'll be generally available to all the different handlers/phases of the OAuth2 flow. Plus it doesn't require signature changes on the handler interfaces, which is nice. On Thu, Dec 8, 2

Re: OAUTH2 ClientAuthenticationHandler: No access to security token

2011-12-08 Thread daviesd
Thanks Li. That was my initial implementation (to add something to the accessor). However I backed off because I was trying to be the least intrusive. Mike and I will go back and see if there is a better way to do this. Just not sure how you'd make it generic enough to figure out what request p

Re: OAUTH2 ClientAuthenticationHandler: No access to security token

2011-12-08 Thread Li Xu
Hi, Mike Thanks for the usecase. It makes sense to me and it could be quite common to have vendor specific extension parameters. Just think we may need a generic way to support that for both authorization endpoint and token endpoint... Here's a suggestion... Pass in real request parameters from H

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/#review3747 --- Ship it! LGTM - Ryan On 2011-12-07 16:53:27, Dan Dumont wrote: >

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Ryan Baxter
> On 2011-12-07 23:13:36, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, > > line 33 > > > > > > I thought we were going to allot

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Dan Dumont
> On 2011-12-07 23:13:36, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, > > line 33 > > > > > > I thought we were going to allot

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

2011-12-08 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/ --- (Updated 2011-12-08 17:58:33.234403) Review request for shindig, Dan Dumont and

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Ryan Baxter
> On 2011-12-07 23:13:36, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, > > line 33 > > > > > > I thought we were going to allot

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

2011-12-08 Thread Ryan Baxter
> On 2011-12-08 15:24:35, Jesse Ciancetta wrote: > > Sorry for being late to the review -- this is the first chance I've had to > > really look this over. I have a few concerns with this approach that make > > me wonder if an alternate approach might be more appropriate -- although > > the al

Re: OAUTH2 ClientAuthenticationHandler: No access to security token

2011-12-08 Thread Michael Matthews
Hi Li. Doug and I work at the same organization. We have an application where users authenticate and are associated with an organization. There is contextual data that our application puts in Shindig's SecurityToken via it's trustedJson field. One of these fields is an identifier for the user's

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/#review3740 --- Spec change: http://code.google.com/p/opensocial-resources/issues/deta

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

2011-12-08 Thread Jesse Ciancetta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/#review3739 --- Sorry for being late to the review -- this is the first chance I've ha

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

2011-12-08 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/ --- (Updated 2011-12-08 15:07:59.683892) Review request for shindig, Dan Dumont and

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Dan Dumont
> On 2011-12-07 23:13:36, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, > > line 33 > > > > > > I thought we were going to allot