Re: Review Request: Enable access to OS Templates defined in template libraries from client API

2012-06-27 Thread Chris Geer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/ --- (Updated June 28, 2012, 1:01 a.m.) Review request for shindig. Changes ---

Re: Review Request: Enable access to OS Templates defined in template libraries from client API

2012-06-27 Thread Chris Geer
> On June 27, 2012, 9:55 p.m., Ryan Baxter wrote: > > /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml, > > line 7 > > > > > > Where is this library? That file is already in the folder with this g

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-27 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/#review8679 --- Ship it! LGTM. Thanks for going through the work of writing the extr

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-27 Thread Stanton Sievers
> On June 27, 2012, 4:38 p.m., Stanton Sievers wrote: > > Matt, please update the JIRA with the latest patch and grant ASF license. > > I'll get this committed once that is done. > > Matthew Reiter wrote: > I'll add the patch to the bug once the unit tests I've added are > approved. Am I

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-27 Thread Matthew Reiter
> On June 27, 2012, 4:38 p.m., Stanton Sievers wrote: > > Matt, please update the JIRA with the latest patch and grant ASF license. > > I'll get this committed once that is done. I'll add the patch to the bug once the unit tests I've added are approved. Am I correct in assuming that I should

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-27 Thread Matthew Reiter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/ --- (Updated June 27, 2012, 10:44 p.m.) Review request for shindig. Changes --

Re: Review Request: Enable access to OS Templates defined in template libraries from client API

2012-06-27 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/#review8670 --- I noticed in the JIRA you removed the patch...please keep the patch an

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-27 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/#review8669 --- Ship it! Ship It! - Ryan Baxter On June 26, 2012, 5:59 p.m., Matth

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-27 Thread Stanton Sievers
> On June 27, 2012, 4:54 p.m., Stanton Sievers wrote: > > Please update the JIRA and I'll get this committed. Thanks. Sorry. Update the JIRA with the patch and grant ASF. - Stanton --- This is an automatically generated e-mail. To rep

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-27 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/#review8658 --- Ship it! Please update the JIRA and I'll get this committed. Thanks.

Re: Review Request: Additional OAuth2 Logging Filters

2012-06-27 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5592/#review8657 --- Adam, I'm seeing some test failures when I applied and built this patc

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-27 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/#review8656 --- Matt, please update the JIRA with the latest patch and grant ASF licen

Re: Review Request: Additional OAuth2 Logging Filters

2012-06-27 Thread Brian Lillie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5592/#review8654 --- Ship it! LGTM - Brian Lillie On June 27, 2012, 12:02 p.m., Adam Cl

Re: Review Request: Additional OAuth2 Logging Filters

2012-06-27 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5592/ --- (Updated June 27, 2012, 12:02 p.m.) Review request for shindig, Stanton Sievers

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-27 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/#review8650 --- Ship it! Ship It! - Adam Clarke On June 26, 2012, 8:33 p.m., Brian