Hi Alexandre,
You should try tracing with FINEST, at least for
org.apache.shindig.gadgets.oauth2.* and
org.apache.shindig.gadgets.servlet.OAuth2CallbackServlet
Your exception is strange to me ...
org.apache.shindig.social.core.oauth2.OAuth2Exception , that's coming from
the OAuth2 provider.
If
---
All unit tests pass
Thanks,
Adam Clarke
/oauth2/handler/OAuth2HandlerErrorTest.java
1386626
Diff: https://reviews.apache.org/r/6436/diff/
Testing
---
All existing JUnits pass
Thanks,
Adam Clarke
it here?
I just don't want to forget about it.
- superddumont
On Sept. 17, 2012, 2:41 p.m., Adam Clarke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6436
/OAuth2HandlerErrorTest.java
1382074
Diff: https://reviews.apache.org/r/6436/diff/
Testing
---
All existing JUnits pass
Thanks,
Adam Clarke
/src/test/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerErrorTest.java
1376889
Diff: https://reviews.apache.org/r/6436/diff/
Testing
---
All existing JUnits pass
Thanks,
Adam Clarke
---
On Aug. 24, 2012, 1:04 p.m., Adam Clarke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6436
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6436/#review10425
---
On Aug. 24, 2012, 1:04 p.m., Adam Clarke wrote:
---
This is an automatically
/oauth2/handler/OAuth2HandlerErrorTest.java
1372387
Diff: https://reviews.apache.org/r/6436/diff/
Testing
---
All existing JUnits pass
Thanks,
Adam Clarke
generated e-mail. To reply, visit:
https://reviews.apache.org/r/6436/#review10023
---
On Aug. 13, 2012, 12:33 p.m., Adam Clarke wrote:
---
This is an automatically generated e-mail
/OAuthRequest.java
1363028
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java
1363028
Diff: https://reviews.apache.org/r/6035/diff/
Testing
---
All JUnits pass.
Thanks,
Adam Clarke
/FilteredLoggerTest.java
1355349
Diff: https://reviews.apache.org/r/5592/diff/
Testing
---
all units pass
Thanks,
Adam Clarke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5497/#review8650
---
Ship it!
Ship It!
- Adam Clarke
On June 26, 2012, 8:33 p.m
Diffs (updated)
-
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLogger.java
1354123
Diff: https://reviews.apache.org/r/5592/diff/
Testing
---
all units pass
Thanks,
Adam Clarke
/main/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLogger.java
1354123
Diff: https://reviews.apache.org/r/5592/diff/
Testing
---
all units pass
Thanks,
Adam Clarke
://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
1352576
Diff: https://reviews.apache.org/r/5420/diff/
Testing
---
All unit tests pass
Thanks,
Adam Clarke
implements several OpenSocial APIs:
OpenSocial REST: for server to server communication
OpenSocial JSON-RPC: for gadget to server communication
Javascript: for gadgets
Having to generate a security token to make this request isn't feeling
quite
right.
doug
On 6/21/12 3:52 PM, A Clarke cla
(updated)
-
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
1352576
Diff: https://reviews.apache.org/r/5420/diff/
Testing
---
All unit tests pass
Thanks,
Adam Clarke
:
https://reviews.apache.org/r/5420/#review8387
---
On June 21, 2012, 3:53 p.m., Adam Clarke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5420/#review8395
---
On June 21, 2012, 3:53 p.m., Adam Clarke wrote:
---
This is an automatically
/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
1352576
Diff: https://reviews.apache.org/r/5420/diff/
Testing
---
All unit tests pass
Thanks,
Adam Clarke
Generally speaking there was nothing done to address the management of
gadget bindings and clients externally.
On Thu, Jun 21, 2012 at 2:38 PM, Matthew G Marum mgma...@us.ibm.com wrote:
Client Credentials flow was implemented in OAuth 2.0 service provider and
the OAuth 2.0 consumer within
set the
encrypted secret to be the unencrypted secret that was passed in. The
persistence layer should be storing the encrypted secret, so if that was null
the information would be lost.
- Adam Clarke
On June 21, 2012, 6:03 p.m., Brian Lillie wrote
/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
1351704
Diff: https://reviews.apache.org/r/5420/diff/
Testing
---
All unit tests pass
Thanks,
Adam Clarke
/OAuth2Store.java
1346021
Diff: https://reviews.apache.org/r/5419/diff/
Testing
---
All unit tests pass
Thanks,
Adam Clarke
Looks like I forgot to update the interface javadoc.
The intention is to use milliseconds now, this made it easier for other
teams to persist and compare values as timestamps.
On Tue, Jun 12, 2012 at 8:23 AM, Ryan J Baxter rjbax...@us.ibm.com wrote:
Doug, this was intentional I believe,
Yes.
On Tue, Jun 12, 2012 at 9:36 AM, Ryan J Baxter rjbax...@us.ibm.com wrote:
Adam is it just the javadoc for OAuth2Token.getIssueAt and
OAuth2Token.getExpiresAt that needs to be updated?
-Ryan
From: A Clarke cla...@gmail.com
To: dev@shindig.apache.org,
Date: 06/12/2012 09
://reviews.apache.org/r/4947/#review7754
---
Ship it!
Committed revision 1336461
Please close the review.
- Stanton
On 2012-05-04 14:31:05, Adam Clarke wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5330/
---
Review request for shindig and Stanton Sievers.
Summary
---
Spec did
Mike,
Your OAuthStore is responsible for encrypting/decrypting the secrets.
The OAuth2Encrypter interface is there because of the lessons learned from
writing custom OAuth 1 stores.
On Tue, May 22, 2012 at 2:43 PM, Michael Matthews matth...@oclc.org wrote:
I'm adding an OAuth 1.0 OAuthStore
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5162/
---
(Updated 2012-05-21 13:27:18.757970)
Review request for shindig.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4947/
---
(Updated 2012-05-04 14:31:05.271804)
Review request for shindig, Ryan Baxter
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4947/
---
(Updated 2012-05-01 15:12:43.842304)
Review request for shindig, Ryan Baxter
Doug,
There's three options you can try out easily, none of these worked for us
so we did option 4 and extended the OAuth2 Consumer and Provider to
seamlessly suppress the dance.
1) Client Credentials. The authorization code flow hinges on the dance
occuring, but client credentials works
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4291/
---
(Updated 2012-04-11 14:55:54.729162)
Review request for shindig, Ryan Baxter
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4291/
---
(Updated 2012-04-10 15:00:53.484791)
Review request for shindig, Ryan Baxter
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4291/
---
(Updated 2012-04-09 20:02:38.850154)
Review request for shindig, Ryan Baxter
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4291/
---
Review request for shindig, Ryan Baxter and li xu.
Summary
---
Allows
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4291/
---
(Updated 2012-03-11 17:43:19.266570)
Review request for shindig, Ryan Baxter
/
---
(Updated 2012-03-09 19:23:05)
Review request for shindig, Dan Dumont and Adam Clarke.
Summary
---
Currently I can use gadgets.io.makeRequest to do a PUT but the PUT body does
not reach the destination. This works today for POST, it simply seems that
PUT was left out
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4202/#review5653
---
Ship it!
LGTM
- Adam
On 2012-03-06 19:29:51, li xu wrote:
, visit:
https://reviews.apache.org/r/3987/
---
(Updated 2012-02-21 21:40:31)
Review request for shindig, li xu and Adam Clarke.
Summary
---
From JIRA:
If the url to which a gadget is doing a makeRequest doesn't exist, i.e
Doug,
Both in-memory and non-caching options could be acceptable. You could even
provide your own OAuth2Store implementation that doesn't even use the
OAuth2Persistence and OAuth2Cache interfaces. It's not really possible to
make a recommendation without knowing all the variables in your
I agree with Li's suggested approach.
Making the request parameters available on the OAuth2Accessor means they'll
be generally available to all the different handlers/phases of the OAuth2
flow. Plus it doesn't require signature changes on the handler interfaces,
which is nice.
On Thu, Dec 8,
On 2011-09-20 08:41:49, Paul Lindner wrote:
thanks!
Addressed in the second patch for
https://reviews.apache.org/r/1947/
- Adam
---
This is an automatically generated e-mail. To reply, visit:
45 matches
Mail list logo
