---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5592/#review8654
---
Ship it!
LGTM
- Brian Lillie
On June 27, 2012, 12:02 p.m., Adam
/OAuth2TokenPersistence.java
1347033
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistenceTest.java
1348118
Diff: https://reviews.apache.org/r/5497/diff/
Testing
---
Tests pass
Thanks,
Brian Lillie
ava
<https://reviews.apache.org/r/5592/#comment18267>
Seems like this could be removed, and filterSecrets used where filteredMsg
is called. filteredParam uses filterSecrets directly, but filteredParams does
the extra indirect to filteredMsg
- Brian Lillie
On June 26, 2012, 6:50 p
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5568/#review8572
---
LGTM
- Brian Lillie
On June 25, 2012, 10:07 p.m., Stanton Sievers
accessor
and uses that as the appUrl for the AnonymousSecurityToken associated with the
subsequent request. For the shared token state, because we are using that
value, we have lost the associability to the gadget that is making the request.
- Brian Lillie
On June 22, 2012, 11:18 a.m., Adam
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5497/#review8462
-------
On June 21, 2012, 6:03 p.m., Brian Lillie wrote:
>
> ---
&g
Diff: https://reviews.apache.org/r/5497/diff/
Testing
---
Tests pass
Thanks,
Brian Lillie
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/5422/#review8400
-------
On June 20, 2012, 12:32 p.m., Brian Lillie wrote:
>
> ---
> This is an automatically generated e
/DefaultServiceFetcherTest.java
1347033
Diff: https://reviews.apache.org/r/5422/diff/
Testing
---
Tests pass. EndToEndTest passes with allowUnauthenticated=false, and with
secure tokens enabled
Thanks,
Brian Lillie
/5422/diff/
Testing
---
Tests pass. EndToEndTest passes with allowUnauthenticated=false, and with
secure tokens enabled
Thanks,
Brian Lillie
Doug,
We are running with secure tokens and though I tried it and it appeared to
be working, it couldn't work and its failing for me now ..
I'll post a revision shortly for review
brian
From: daviesd
To: ,
Date: 06/14/2012 12:04 PM
Subject:Re: Pass token on listMethods to e
al should be passed if
specified.
brian
From: "Ciancetta, Jesse E."
To: "dev@shindig.apache.org" ,
Date: 02/01/2012 06:51 AM
Subject:RE: makeRequest with 0 refresh interval
>-----Original Message-
>From: Brian Lillie [mailto:brian...@us.ibm.com]
There seems to me to be a mismatch in expectations between gadget and
server if the makeRequest REFRESH param is set to 0, resulting in incorrect
caching of the request on the server.
If a gadget uses makeRequest and sets the REFRESH param = 0, then the
request is issued as a POST to the server,
ly generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3006/
> ---
>
> (Updated 2011-12-04 21:04:16)
>
>
> Review request for shindig, Jesse Ciancetta and Brian Lillie.
>
>
> Summary
> ---
&
:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2572/
> ---
>
> (Updated 2011-10-26 13:51:59)
>
>
> Review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1960/
---
Review request for shindig.
Summary
---
If the OAuthResponseParms code call
Ryan was referring to a specific gadget blacklist capability available in
the container, not necessarily to allowing the allow/deny on the features
list, though of course it could be used in any of the cases.
It would seem that if you want to add additional administrative attributes
to a generaliz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1692/
---
Review request for shindig.
Summary
---
There are at least two cases where
In the CssResponseWriter rewriting path, a stub gadget is created to assist
with the rewriting of the URLs in the CSS file. The stub gadget's URI,
rather than referring to an actual gadget URI, ends up referring to the
resource that was being loaded, such that the rewritten urls include as a
pa
19 matches
Mail list logo
