---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4216/#review5728
---
Ship it!
Thanks for the patch! committed with revision 1298423.
- l
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4202/
---
Review request for shindig.
Summary
---
As part of the release cycle in our
> On 2012-02-22 03:03:25, li xu wrote:
> > LGTM. Thanks!
Sorry,missed previous comments. Second thought after reading it and checking a
few web links, I agree more thoughts on "403" will be needed. The reason about
"403" may not be token related...it's co
>
> Review request for shindig, li xu and Adam Clarke.
>
>
> Summary
> ---
>
> From JIRA:
> If the url to which a gadget is doing a makeRequest doesn't exist, i.e.,
> returns a 404 to the Shindig server, the access token is being removed from
Stanton,
Doesn't seem like it can workaround without a fix this time...Here's what I
think how we may fix this:
cfg[osapi.container.ServiceConfig.PROXY_URI] = "http://localhost:8181/proxy
";
cfg[osapi.container.ServiceConfig.API_HOST] = "http://localhost:8080/cre";;
cfg[osapi.container.ServiceCon
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3764/
---
(Updated 2012-02-06 21:47:43.400978)
Review request for shindig and Eric Woods.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3764/
---
Review request for shindig and Eric Woods.
Summary
---
We have a use case
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3064/#review4752
---
Ship it!
Looks good. Thanks. This is the better place to flow additio
gt; Review request for shindig, Henry Saputra, Ryan Baxter, li xu, Jesse
> Ciancetta, and Stanton Sievers.
>
>
> Summary
> ---
>
> Initial review of 1st change. Allowing common container to manage container
> token refreshes. Also, refresh of gadget security tokens will
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3180/
> ---
>
> (Updated 2012-01-10 20:53:59)
>
>
> Review request for shindig, Henry Saputra, Ryan Baxter,
>
> Sorry for the late reply. yes, please do. Please close the review and JIRA
> issue.
>
Thanks,
Li
ah, I see, no worry. I can clean up the code style when committing it.
thanks.
Thanks for the patch, Doug! It looks pretty good to me. only a few minor
things I have added to the review.
Thanks!
li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3064/#review3849
---
Ship it!
It looks pretty good to me, thanks for the patch! I can help
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3064/#review3850
---
Ship it!
It looks pretty good to me, thanks for the patch! I can help
I see. Just a thought, Inject an OAuth2RequestParameterGenerator here might
be helpful...It could provide a function to generate parameter based on
HttpRequest. The default implemenation doesn't have to generate any
parameter.
thanks,
li
>
>
Hi Doug,
Sure, np.
Yes, it's hard to filter the parameter. Maybe all the query parameters as a
first step?
NO need to say sorry... we have all been new to Shindig once before. Let's
still use the same issue and review request to keep track of this. When a
new patch is ready, please just upload the
Hi, Mike
Thanks for the usecase. It makes sense to me and it could be quite common
to have vendor specific extension parameters. Just think we may need a
generic way to support that for both authorization endpoint and token
endpoint...
Here's a suggestion...
Pass in real request parameters from H
Doug,
Thanks for submit the review request.
Would you please elaborate your usecase why you need to pass additional
parameter to authorization url? would like to understand how common is the
usecase.
thanks,
li
Thanks, Doug! Please remove the demo code from the patch and create a
review request. Thanks!
li
>
> Yeah, that's a good point. It would be nice to define an extension as a
> Set here to allows Multibinder to define
> multiple binding.
>
Hi, Doug
To my understanding, yes, it need to overwrite OAuth2HandlerModule to
provide the new AuthenticationHandler list.
Thanks for the catch about typo, will fix it.
thanks,
li
On Tue, Dec 6, 2011 at 10:02 AM, daviesd wrote:
> I didn¹t notice that the request coming into addOAuth2Authenticat
Exactly, most still true in OAuth2.0 Consumer implementation. Just would
like to point out a few things that's added for OAuth2.0 consumer
implementation.
1. Gadget developer could still define provider information in gadget xml
like follows.
https://www.google.com/m8/feeds/";>
https://account
+1.
I use Eclipse IDE and see these META-INF dir created too.
thanks,
li
Thanks, Henry. I submitted the patch for review.
https://reviews.apache.org/r/2851/
thanks,
li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2851/
---
Review request for shindig and Henry Saputra.
Summary
---
Right now extende
Hi, Paul
Please add me to the PMC list too.
thanks,
li
Hi, all
I noticed that extended javascript features is always loaded first than
default javascript features.
This is okay for normal case. However if we'd like an extended feature to
overwrite an default feature, this would become a problem.
Is there any objection to update the order to load defau
Ryan,
Replacing guice module(eg. OAuth2PersistenceModule in this case ) is an
alternative depending on the requirements. Eg. there's a production need to
use Shindig as an OAuth2 consumer. then a more sophisticated persister is
recommended than the default json implementation.
thanks,
li
I see, probably you just took the jar but not the whole shindig war in your
deployment? It should also be in classes folder of shindig war file.
The patch should fix this, it would copy the json file into jar file during
build process. So you don't need to manually copy it over for your deployed
i
Doug,
I submitted a patch here...https://reviews.apache.org/r/2793/
thanks,
li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2793/
---
Review request for shindig, Matt Marum, Eric Woods, and Adam Clarke.
Summary
---
Doug,
thanks for catching this. It looks like it needs to be explicitly called
out in pom.xml so it would get copied into shindig-gadget during build
process.
However I don't have any problem starting shindig server and running Oauth2
gadgets on common container test page...
What error did you get?
+1
+1 !
+1!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/
---
(Updated 2011-10-14 18:01:40.220430)
Review request for shindig, Paul Lindner, H
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/
---
(Updated 2011-10-12 20:54:19.017987)
Review request for shindig, Paul Lindner, H
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2348/#review2536
---
Dan, Thanks for the fix! it works and looks good to me.
thanks,
li
-
7
> > <https://reviews.apache.org/r/1947/diff/3/?file=45562#file45562line27>
> >
> > Make sure the javadoc is compelte
agreed
> On 2011-09-27 17:46:35, Ryan Baxter wrote:
> > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java,
> > line 41
> > <htt
anks!
Summary
---
OAuth 2.0 client implementation in Apache Shindig from Adam Clarke, Eric Woods,
Jeff Hoy, Li Xu and Matthew Marum.
Documentation wiki:
http://docs.opensocial.org/display/OSD/OAuth+2.0+Consumer+Implementation+in+Apache+Shindig
JIRA issue: https://issues.apache.org/jira/browse/SHIND
---
Features included in this patch:
1. junit test cases -- great work from Adam!
2. javadoc improvement
3. updates upon Ryan's comments
It's a big patch, thanks for reviewing!
Summary
---
OAuth 2.0 client implementation in Apache Shindig from Adam Clarke, Eric Woods,
Jeff Hoy,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/
---
(Updated 2011-09-28 14:42:55.071479)
Review request for shindig, Paul Lindner, H
Thanks, Henry. SHINDIG-1627 seems to be the right issue for the feature Dan
or I plan to work on when we find time.
Ryan,
I just would like to fix the issue before the other patch is available so we
can have some buffer to wait for the the other patch ( it may take some time
to do that ).
Also th
you can also set the values in web.xml.
shindig.host=
shindig.port=
thanks,
li
On Tue, Sep 27, 2011 at 11:40 AM, Jasha Joachimsthal <
j.joachimst...@onehippo.com> wrote:
> On 27 September 2011 17:09, Tomer G. wrote:
>
> > I'm using Shindig 2.0 with its default container. When the container
> >
OT register an api path if it is not explicitly
> > provided.
> >
> > Let me know if you want to go after it, otherwise it's on my to do list.
>
> Ryan Baxter wrote:
> +1
>
> li xu wrote:
> Dan, that's good information. Would you please point
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2086
-----------
On 2011-09-26 21:22:35, li xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/
---
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Summar
for "mac" token type (draft version 5) and hmac_sha_1
signing**
Appreciate if review can be given and help to make progress on the patch!
thanks,
li
Summary
---
OAuth 2.0 client implementation in Apache Shindig from Adam Clarke, Eric Woods,
Jeff Hoy, Li Xu and Mat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
---
(Updated 2011-09-23 19:48:55.195325)
Review request for shindig.
Changes
--
6) General improvements to error handling/reporting/translating
7) Some javadoc improvements
- li
On 2011-09-21 14:54:57, li xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
6) General improvements to error handling/reporting/translating
7) Some javadoc improvements
- li
On 2011-09-21 14:54:57, li xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
al improvements to error handling/reporting/translating
7) Some javadoc improvements
Summary
---
OAuth 2.0 client implementation in Apache Shindig from Adam Clarke, Eric Woods,
Jeff Hoy, Li Xu and Matthew Marum.
Documentation wiki:
http://docs.opensocial.org/display/OSD/OAuth+2.0+Consumer
t:
https://reviews.apache.org/r/1947/#review1958
-------
On 2011-09-17 13:54:52, li xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1947/
>
---
link to related shindig issue.
https://issues.apache.org/jira/browse/SHINDIG-1624
Summary
---
OAuth 2.0 client implementation in Apache Shindig from Adam Clarke, Eric Woods,
Jeff Hoy, Li Xu and Matthew Marum.
Documentation wiki:
http://docs.opensocial.org/display/OSD/OAuth+2.0
Hey, Ryan
thanks for the tip. Would you please suggest how we can drive this
requirements to open social spec?
thanks,
li
Hey, All
I created a patch based on this thought and it works fine.
But would like to get any comments/thoughts regarding the overall approach
before submitting the patch.
thanks,
li
d 2011-08-29 23:14:02)
>
>
> Review request for shindig and li xu.
>
>
> Summary
> ---
>
> Currently the code inject BasicAuthorityProvider to allow Shindig Java to be
> deploy in non root environment.
>
> However this is not necessary since the BasicAuthority
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1676/
> ---
>
> (Updated 2011-08-29 23:14:02)
>
>
> Review request for shindig and li xu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1663/
---
(Updated 2011-08-25 22:20:42.737962)
Review request for shindig, Paul Lindner, H
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1616/
---
(Updated 2011-08-24 20:14:29.491196)
Review request for shindig, Paul Lindner, H
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1616/
---
(Updated 2011-08-23 21:47:22.758827)
Review request for shindig, Paul Lindner, H
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1616/
---
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Summar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1578/
---
(Updated 2011-08-18 15:29:38.309795)
Review request for shindig, Paul Lindner, H
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1578/
---
Review request for shindig, Paul Lindner, Henry Saputra, johnfargo, and Eric
Wood
thanks!
- li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1526/#review1478
---
On 2011-08-16 17:03:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1526/
---
Review request for shindig, Paul Lindner, Henry Saputra, Ryan Baxter, and
Matthew
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1305/
---
Review request for shindig, Paul Lindner, Henry Saputra, johnfargo, and Eric
Wood
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1152/
---
Review request for shindig, Paul Lindner, Henry Saputra, and Eric Woods.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/939/#review871
---
Ship it!
LGTM. thanks for addressing it.
- li
On 2011-06-21 15:15:51
h yes... apologize... I did not see any bad side-effect after removing
the
scheme from defaultShindigTestHost. Only endPoints as you suggested.
doug
On 6/20/11 5:55 PM, "Li Xu" wrote:
> Hi, Doug
> Thanks for the comments.
> There were two properties I have seen the exception only
need to be changed to tack on the current
scheme
of the servlet request.
doug
On 6/20/11 4:26 PM, "Li Xu" wrote:
> Hello, all
>
> Can we remove scheme from "defaultShindigTestHost" in container.js?
> eg
> "defaultShindigTestHost":"//%authority%&quo
Hello, all
Can we remove scheme from "defaultShindigTestHost" in container.js?
eg
"defaultShindigTestHost":"//%authority%",
insteadof
"defaultShindigTestHost":"http://%authority%";,
Right now it's not convenient. Each time we need to modify container.js if
scheme needs to be updated.
Another a
Doug,
Thanks for bringing this up. This fix doesn't address the scheme
configuration. You will still need to do the change in container.js to get
around the problem...
Please try following two configuration:
"defaultShindigTestHost":"http://%authority%";,
or
"defaultShindigTestHost":"//%authorit
Thanks a lot, Doug. UrlRewriteFilter works!
- Forwarded by Li Xu/Raleigh/IBM on 06/10/2011 03:09 PM -
From:
daviesd
To:
Li Xu/Raleigh/IBM@IBMUS
Date:
06/09/2011 10:49 AM
Subject:
Re: problem resolving "%host%" in jsonrpctransport.js when separating
server and web page contai
|daviesd
|
>--|
|>
| To:|
|>
>------|
|, Li Xu/Raleigh/IB
sport.js when separating server
and web page container |
>--|
We use option 1 via urlrewriteproxy. Works fine.
On 6/2/11 10:54 AM, "Li Xu" wrote:
> Stanton and Henry, thanks so much for all the suggestions!
>
> I listed all the 4 possible
objection.
>>
>> - Henry
>>
>> On Wed, Jun 8, 2011 at 12:40 PM, John Hjelmstad
>> wrote:
>>
>> > @Henry or @Paul, can you patch and commit this? LGTM but I'm swamped @
>> the
>> > moment :\
>> >
>> >
>> > O
rom: |
|>
>------|
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
---
(Updated 2011-06-06 14:45:37.546647)
Review request for shindig.
Changes
--
extended) {
I also see this style in other java code.
still need 2 space here?
- li
-----------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/#review762
-
file20135line39>
> >
> > Interesting, so you're just using the jetty values as a fallback in the
> > default impl? Suppose that's fine.
yes. system properties first, values in request 2nd, fallback to jetty if
neither is available. test cases works with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
---
(Updated 2011-06-03 21:37:58.289676)
Review request for shindig.
Changes
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
---
(Updated 2011-06-01 20:23:51.068414)
Review request for shindig.
Summary
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
---
(Updated 2011-06-01 20:20:12.988099)
Review request for shindig.
Changes
--
affected since
properties are resolved on server.
- li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/#review726
---
On 2011-0
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
---
Review request for shindig.
Summary
---
This is a follow up for Issue 1534:
guraton initialization
> --
>
>
>
> Hi Li,
>
> In most cases, yes, the values initialized via init.js will be
overridden.
> However, when you call gadgets.config.init it actually merges the given
> configuration with the new configuration using
Yes, substitution is fine. However it doesn't like "gadget=...", "url=..."
works fine.
eg. background.jpg in todo gadget can't be resolved in this case.
thanks,
li
new configuration using the "foldConfig" method.
Thus if container.js doesn't have core.io and rpc configuration, the
default values passed in init.js will still be there.
I'm assuming that the initializeConfig function is either there for
testing or as a fail-safe to make
Hi, all
We found configuration is actually initialized with values defined in
container.js but not initialized with init.js.
Since configuration defined in container.js is always injected, the value
initialized by init.js got overwritten by the value defined in
container.js.
Is this a bug? can we
We're moving "shindig.signing.global-callback-uri" into container.js as
part of context root patch. We found there's already a similar property in
container.js called "gadgets.uri.oauth.callbackTemplate". The value of
these two property is the same. Is there any reason we can't use
gadgets.uri.
Mon, May 2, 2011 at 8:00 AM, Li Xu wrote:
>
> It builds fine with JRE1.6. anyone have seen sth. similar?
>
> The error I got is this:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile
> (default-compile) on project shin
.gmane.org/gmane.comp.web.shindig.devel/6601
From: Li Xu/Raleigh/IBM@IBMUS
To: dev@shindig.apache.org
Date: 05/02/2011 10:59 AM
Subject:latest shindig doesn't build with JRE1.5 anymore
It builds fine with JRE1.6. anyone have seen sth. similar?
The error I got is this:
[ERROR] Failed
/java/org/apache/shindig/gadgets/parse/GadgetHtmlParser.java:[70,7]
method does not override a method from its superclass
[ERROR] -> [Help 1]
thanks,
li
==
Li Xu
IBM Lotus Project Vulcan
Phone: 919-486-1558(T/L) 526-1558
Email:
95 matches
Mail list logo
