Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review4362 --- Ship it! Committed r1231211. Thanks everyone for the reviews! - Dan

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review4361 --- Ship it! Thanks! - li On 2012-01-13 16:44:45, Dan Dumont wrote: >

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/ --- (Updated 2012-01-13 16:44:45.741871) Review request for shindig, Henry Saputra,

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review4360 --- Ship it! LGTM Thanks Dan! - Jesse On 2012-01-13 16:20:24, Dan Dum

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/ --- (Updated 2012-01-13 16:20:24.912530) Review request for shindig, Henry Saputra,

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2012-01-12 23:25:46, Ryan Baxter wrote: > > Looks like you added some additional methods to gadget site and container > > util, do you want to also make the corresponding changes in the feature.xml > > files as well? I think I've declared all of the ones I wanted to be public in the featu

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review4354 --- Looks good. The new interface is neat. One minor comment, please see b

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review4339 --- Looks like you added some additional methods to gadget site and contai

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review4335 --- I'd like to commit this by EOD tomorrow (Friday). Please let me know

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/ --- (Updated 2012-01-10 20:53:59.258090) Review request for shindig, Henry Saputra,

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2012-01-10 18:48:26, Jesse Ciancetta wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, > > line 911 > > > > > > In the patch I was working on for

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review4298 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/ --- (Updated 2012-01-10 14:59:57.500691) Review request for shindig, Henry Saputra,

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/ --- (Updated 2012-01-10 14:08:09.496346) Review request for shindig, Henry Saputra,

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2012-01-10 13:00:45, Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js, > > line 1 > > > > > > Whether for this review or not, I

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review4291 --- Overall this looks good to me. I have some questions about setting th

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/ --- (Updated 2012-01-09 21:18:06.698353) Review request for shindig, Henry Saputra,

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/ --- (Updated 2011-12-23 21:20:36.791685) Review request for shindig, Henry Saputra,

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-23 14:36:01, Jesse Ciancetta wrote: > > I'm trying to respond to the questions Dan posted with his last update but > > I dont see a way to comment there -- so I guess I'll just put my comments > > here... Going to copy/paste Dan's questions and respond to them inline > > below. >

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review4105 --- I'm trying to respond to the questions Dan posted with his last update

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/ --- (Updated 2011-12-22 21:00:32.001973) Review request for shindig, Henry Saputra,

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/ --- (Updated 2011-12-22 19:58:30.507072) Review request for shindig, Henry Saputra,

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-19 18:23:54, Dan Dumont wrote: > > So far I have 1 vote for splitting the update function into 2 parts (from > > Jesse), and 1 for leaving it as 1 function (from Henry, I think on the dev > > list). > > > > Are there any other opinions on the matter? > > Ryan Baxter wrote: >

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-19 18:23:54, Dan Dumont wrote: > > So far I have 1 vote for splitting the update function into 2 parts (from > > Jesse), and 1 for leaving it as 1 function (from Henry, I think on the dev > > list). > > > > Are there any other opinions on the matter? > > Ryan Baxter wrote: >

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-19 18:23:54, Dan Dumont wrote: > > So far I have 1 vote for splitting the update function into 2 parts (from > > Jesse), and 1 for leaving it as 1 function (from Henry, I think on the dev > > list). > > > > Are there any other opinions on the matter? > > Ryan Baxter wrote: >

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-19 18:23:54, Dan Dumont wrote: > > So far I have 1 vote for splitting the update function into 2 parts (from > > Jesse), and 1 for leaving it as 1 function (from Henry, I think on the dev > > list). > > > > Are there any other opinions on the matter? > > Ryan Baxter wrote: >

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-19 18:23:54, Dan Dumont wrote: > > So far I have 1 vote for splitting the update function into 2 parts (from > > Jesse), and 1 for leaving it as 1 function (from Henry, I think on the dev > > list). > > > > Are there any other opinions on the matter? > > Ryan Baxter wrote: >

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-19 18:23:54, Dan Dumont wrote: > > So far I have 1 vote for splitting the update function into 2 parts (from > > Jesse), and 1 for leaving it as 1 function (from Henry, I think on the dev > > list). > > > > Are there any other opinions on the matter? > > Ryan Baxter wrote: >

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-19 18:23:54, Dan Dumont wrote: > > So far I have 1 vote for splitting the update function into 2 parts (from > > Jesse), and 1 for leaving it as 1 function (from Henry, I think on the dev > > list). > > > > Are there any other opinions on the matter? I agree with Jesse on this on

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review3976 --- So far I have 1 vote for splitting the update function into 2 parts (f

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-15 00:07:05, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, > > line 233 > > > > > > Shouldnt this call happen? The defau

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review3911 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

I actually like the original idea of having one function to update/ initiate the container token. Because it doesnt really matter from container page point of view whether common container doing init or updating exisitng token - Henry On Wed, Dec 14, 2011 at 9:58 AM, Jesse Ciancetta wrote: > > -

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-14 17:58:55, Jesse Ciancetta wrote: > > Some observations after a first pass: > > > > IMO the API would make more sense and be a little more intuitive if we > > broke it up into a couple of more specific public functions instead of > > having just one multi-purpose function. Righ

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-14 17:58:55, Jesse Ciancetta wrote: > > Some observations after a first pass: > > > > IMO the API would make more sense and be a little more intuitive if we > > broke it up into a couple of more specific public functions instead of > > having just one multi-purpose function. Righ

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review3908 --- Some observations after a first pass: IMO the API would make more sen

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/ --- (Updated 2011-12-14 16:35:00.374342) Review request for shindig, Ryan Baxter, li