Re: @Adapter methods, ready to integrate in trunk, WDYT?

For now I'm against committing this to trunk, as previously mentioned I would prefer having a build time annotation. If this is not possible, then the annotation and the AdapterProvider should be in the same package as there is no use case for using one without the other. One solution for a build

Re: SLING-2803 validation module, hierarchical structures and extensible types

As I wrote, a hierarchy is only supported by a single implementation for reading - not for writing, so it doesn't make sense to me to support this in validation as this can't be written through the resource api in the same way. The post servlet is splitting paths and creates a resource for each par

Re: SLING-2803 validation module, hierarchical structures and extensible types

Hi, Found what Alex was talking about in the org.apache.sling.jcr.resource.JcrPropertyMap class. I'm sorry for my previous answer. The implementation wasn't that obvious at first. What do you think the best approach would be given the hierarchical structures problem and the currently proposed val

[jira] [Commented] (SLING-2939) 3rd-party based implementation of discovery.api

[ https://issues.apache.org/jira/browse/SLING-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699411#comment-13699411 ] Robert Munteanu commented on SLING-2939: [~egli] - JGroups can function well with

Re: SLING-2803 validation module, hierarchical structures and extensible types

2013/7/3 Alexander Klimetschek > On 03.07.2013, at 17:34, Radu Cotescu wrote: > > > 1. Currently there's no support for hierarchical structures. ValueMap > > doesn't provide this kind of support. > > Yes, the jcr property value map implementation supports relative paths. > This should definitely

Re: Issue Adding GPG Key

Justin, Thanks for the response, I was able to check out the code there, but when I tried to check my changes back in a received the following error: dklco@dk6d-laptop:~/Development/6ddev/workspaces/sling/sling$ svn ci -m "Adding my GPG key" SendingKEYS svn: E195023: Commit failed (detail

Re: SLING-2803 validation module, hierarchical structures and extensible types

On 03.07.2013, at 17:34, Radu Cotescu wrote: > 1. Currently there's no support for hierarchical structures. ValueMap > doesn't provide this kind of support. Yes, the jcr property value map implementation supports relative paths. This should definitely be supported, as you very quickly have a ne

Re: Sling Posthandling - thougts about the current behavior

On 03.07.2013, at 14:58, Justin Edelson wrote: > IMHO :operation is an aspect of the current default POST servlet. If we are > going to move more POST-specific handling into the engine, then we should > be using selectors. Yes, my main point was to have only one. You are right, selector is the b

Build failed in Jenkins: sling-trunk-1.6 #1712

See Changes: [cziegeler] SLING-2943 : Classloader might not be invalidated in a cluster -- [...truncated 6356 lines...] [INFO] Apache Sling JCR ClassLoader .. SUCCESS [1:45.8

Build failed in Jenkins: sling-trunk-1.6 » Apache Sling Jackrabbit Embedded Repository #1712

See -- [INFO] [INFO] -

Jenkins build is unstable: sling-trunk-1.7 #82

See

Jenkins build is back to normal : sling-trunk-1.7 » Apache Sling Engine Implementation #82

See

Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #82

See

Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #82

See

Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing WAR version #82

See

Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Sample Integration Tests #82

See

[jira] [Resolved] (SLING-2943) Classloader might not be invalidated in a cluster

[ https://issues.apache.org/jira/browse/SLING-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-2943. - Resolution: Fixed Fixed in revision 1499459 > Classloader might not be i

[jira] [Created] (SLING-2943) Classloader might not be invalidated in a cluster

Carsten Ziegeler created SLING-2943: --- Summary: Classloader might not be invalidated in a cluster Key: SLING-2943 URL: https://issues.apache.org/jira/browse/SLING-2943 Project: Sling Issue T

Re: SLING-2803 validation module, hierarchical structures and extensible types

Hi Bertrand, 1. Currently there's no support for hierarchical structures. ValueMap doesn't provide this kind of support. I see two solutions here (the first is your idea from the private chat we had earlier): a. create a HierarchicalValueMap and perform validation on top of this; this also imp

Build failed in Jenkins: sling-trunk-1.7 #81

See Changes: [cziegeler] SLING-2925 : Wasted work in InternalQueueConfiguration.checkIsValid(). Apply patch from Adrian Nistor -- [...truncated 5708 lines...] [INFO] Sling JCRInstall Bundle Archet

[jira] [Commented] (SLING-2803) Create a Validation module capable of validating POST requests or Resources

[ https://issues.apache.org/jira/browse/SLING-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699066#comment-13699066 ] Radu Cotescu commented on SLING-2803: - Thanks for the review, Bertrand! I tried to bi

Jenkins build is unstable: sling-trunk-1.6 #1711

See

Build failed in Jenkins: sling-trunk-1.7 » Apache Sling Engine Implementation #81

See -- [INFO] [INFO] --

Jenkins build is unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing WAR version #1711

See

Jenkins build is back to normal : sling-trunk-1.6 » Apache Sling JSON Library #1711

See

Jenkins build is back to normal : sling-trunk-1.6 » Apache Sling Maven Plugin to create Jackrabbit OCM descriptors #1711

See

Jenkins build is back to normal : sling-trunk-1.6 » Sling Adapter Annotations #1711

See

Jenkins build is unstable: sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #1711

See

SLING-2803 validation module, hierarchical structures and extensible types

Hi Radu, I've briefly reviewed your SLING-2803 code and it looks quite good to me! I'm wondering if it supports the following use cases: 1) Validating hierarchical structures Say I'm POSTing a small tree of resources rooted at /foo, can you validate for example that /foo/customer/email is presen

[jira] [Commented] (SLING-2803) Create a Validation module capable of validating POST requests or Resources

[ https://issues.apache.org/jira/browse/SLING-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698982#comment-13698982 ] Bertrand Delacretaz commented on SLING-2803: I briefly reviewed the validation

Re: Wrong handling of service.ranking property in Sling Filter ordering

On Wed, Jul 3, 2013 at 4:00 PM, Carsten Ziegeler wrote: > ...In general, when there is a doubt and it's not clearly a bug, I would think > that the implementation is right and the docs are wrong... yes, yes, yes, +1 ! People have been running our code, not our docs...changing the former has much

Re: Wrong handling of service.ranking property in Sling Filter ordering

I'm more in the camp of fix-the-docs :) One could argue that higher priority means they have the most power and therefore are run last and can overrule everything previous filters have done - this again would be somehow in line with service ranking in general. In general, when there is a doubt and

Re: @Adapter methods, ready to integrate in trunk, WDYT?

Just read the answer in the issue :) I like the general intention - however it feels a little bit strange to register a AdapterProvider, annotate a method and then this gets picked up at runtime and a new AdapterFactory is registered. Can't we make this annoation build time only - as an extensions

Re: @Adapter methods, ready to integrate in trunk, WDYT?

On Wed, Jul 3, 2013 at 3:26 PM, Carsten Ziegeler wrote: > ...could you please elaborate a little bit on who is > processing this annotation and when?... As I said in SLING-2938: The @Adapter annotation is processed at runtime, all the "magic" is in http://svn.apache.org/repos/asf/sling/whiteboar

Re: Sling Posthandling - thougts about the current behavior

Rereading my post: you always trigger exactly one :operation, so this is not an aspect, this is wat actualy is done to perform the post. On Wed, Jul 3, 2013 at 3:27 PM, Dominik Süß wrote: > If I got the implementation right you always trigger exactly one, so this > is not an aspect, this is wat

Re: Sling Posthandling - thougts about the current behavior

If I got the implementation right you always trigger exactly one, so this is not an aspect, this is wat actualy is done to perform the post. Aspects are handled via PostProcessors. On Wed, Jul 3, 2013 at 2:58 PM, Justin Edelson wrote: > Hi, > > > On Tue, Jul 2, 2013 at 2:38 PM, Alexander Klimets

Re: @Adapter methods, ready to integrate in trunk, WDYT?

Hi, sounds interesting - could you please elaborate a little bit on who is processing this annotation and when? Thanks Carsten 2013/7/3 Bertrand Delacretaz > On Wed, Jul 3, 2013 at 3:07 PM, Justin Edelson > wrote: > ... > > @Adapter(condition="if the resource type is slingbucks/list"). > ...

[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service

[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698948#comment-13698948 ] Bertrand Delacretaz commented on SLING-2938: The @Adapter annotation is proces

[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service

[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698943#comment-13698943 ] Carsten Ziegeler commented on SLING-2938: - Who is processing this annotation and w

[jira] [Updated] (SLING-2925) Wasted work in InternalQueueConfiguration.checkIsValid()

[ https://issues.apache.org/jira/browse/SLING-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-2925: Component/s: (was: Scripting) Extensions > Wasted work in Internal

[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service

[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698933#comment-13698933 ] Bertrand Delacretaz commented on SLING-2938: TODOs after integration in trunk:

[jira] [Updated] (SLING-2925) Wasted work in InternalQueueConfiguration.checkIsValid()

[ https://issues.apache.org/jira/browse/SLING-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-2925: Fix Version/s: Extensions Event 3.2.0 > Wasted work in InternalQueueConfiguration.check

[jira] [Resolved] (SLING-2925) Wasted work in InternalQueueConfiguration.checkIsValid()

[ https://issues.apache.org/jira/browse/SLING-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-2925. - Resolution: Fixed Thanks for your patch Adrian, it's applied > Wasted wo

[jira] [Assigned] (SLING-2925) Wasted work in InternalQueueConfiguration.checkIsValid()

[ https://issues.apache.org/jira/browse/SLING-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-2925: --- Assignee: Carsten Ziegeler > Wasted work in InternalQueueConfiguration.checkIsVal

Re: @Adapter methods, ready to integrate in trunk, WDYT?

On Wed, Jul 3, 2013 at 3:07 PM, Justin Edelson wrote: ... > @Adapter(condition="if the resource type is slingbucks/list"). ... Makes sense, noted in SLING-2938 -Bertrand

Re: @Adapter methods, ready to integrate in trunk, WDYT?

Hi Bertrand, On Wed, Jul 3, 2013 at 8:55 AM, Bertrand Delacretaz wrote: > hi Justin, > > On Wed, Jul 3, 2013 at 2:41 PM, Justin Edelson > wrote: > >...I would like to see condition metadata provided > > in the @Adapter annotation... > > I'm generating that, see the bottom of this SLING-2938 scr

Re: [Discovery] missing features and 3rd party implementation of discovery.api

Thanks for taking this up, Stefan. I think we should also try to close down the first version of the discovery api and release this, so other parts of our code can really rely on this api. Apart from that, I don't have a strong preference, although it would be nice to just use Apache stuff :) Re

Re: Sling Posthandling - thougts about the current behavior

On Wed, Jul 3, 2013 at 2:58 PM, Justin Edelson wrote: > ...Why wouldn't you register by resource type + method + selector? After all, > that's what you do now. For pipeline components, we could add a "phase" > registration property (or maybe ranking is enough) And phase could be just a fake s

Re: Sling Posthandling - thougts about the current behavior

Hi, On Tue, Jul 2, 2013 at 2:38 PM, Alexander Klimetschek wrote: > Ack on the overall goal. > > The way I see it, it boils down to having the sling post servlet (or more > specifically that new POST-pipeline) not "just" one special servlet out of > many, but an integral part of Sling. > > Regi

Re: Sling Posthandling - thougts about the current behavior

On Wed, Jul 3, 2013 at 2:53 PM, Dominik Süß wrote: > ...I bet a bunch of > scripts/servlet currently check the contentpath first and react on this... Those servlets should die ;-) -Bertrand

Re: @Adapter methods, ready to integrate in trunk, WDYT?

hi Justin, On Wed, Jul 3, 2013 at 2:41 PM, Justin Edelson wrote: >...I would like to see condition metadata provided > in the @Adapter annotation... I'm generating that, see the bottom of this SLING-2938 screenshot which describes an Adapter method: https://issues.apache.org/jira/secure/attachme

Re: Sling Posthandling - thougts about the current behavior

As said before - I would never register a Servlet by path, but a Servlet serving a specific ResourceType might just be valid for a specific path. (like extension or selector can filter the selection of the matching Servlet/Script). I agree that in contrast to Servlets and Extensions it's not feasib

Re: Sling Posthandling - thougts about the current behavior

On Wed, Jul 3, 2013 at 2:38 PM, Justin Edelson wrote: >... Wouldn't a ResourceDecorator be a better solution in those case? I.e. if a > resource is of type app/foo and is under /content/bar, decorate the > resource to app/bar ?... Note that we already have something like that in http://svn.apache

Re: [DISCUSS] SLING-2936 - passing selector as POST parameter

Hi, On Tue, Jul 2, 2013 at 5:39 AM, Bertrand Delacretaz wrote: > Hi, > > On Thu, Jun 27, 2013 at 5:46 PM, Justin Edelson > wrote: > >...I think there is a significant need to be able to "select" > > amongst multiple POST servlets for a particular resource. Thus, I propose > > that we allow for

Re: @Adapter methods, ready to integrate in trunk, WDYT?

Bertrand- This all looks good to me. I would like to see condition metadata provided in the @Adapter annotation. But this can be added after you commit (just ideally before the release). Regards, Justin On Tue, Jul 2, 2013 at 10:09 AM, Bertrand Delacretaz wrote: > Hi, > > As this touches the s

Re: Sling Posthandling - thougts about the current behavior

Hi Dominik, Wouldn't a ResourceDecorator be a better solution in those case? I.e. if a resource is of type app/foo and is under /content/bar, decorate the resource to app/bar ? The fact that you can register servlets by path should *not* in my opinion be a reason to extend behavior-by-path to othe

Re: Sling Posthandling - thougts about the current behavior

Hi Bertrand, while I agree that paths should not drive the app they might build a scope for the logic, since the content is organized in a tree structure and not in by it's resourceType hierarchy, Therefore you often do have pathspecific operations (just think of workflows and workflowlaunchers in

Re: Sling Posthandling - thougts about the current behavior

Hi, On Wed, Jul 3, 2013 at 12:55 PM, Dominik Süß wrote: > ...why do you think registering logic by path is bad. Especially if I look at > potential for multitenantsupport it would be great to be able to register > postbehavior that is tenantspecific. And the tenantsupport of Sling is > completely

Re: Sling Posthandling - thougts about the current behavior

Hi Alex, why do you think registering logic by path is bad. Especially if I look at potential for multitenantsupport it would be great to be able to register postbehavior that is tenantspecific. And the tenantsupport of Sling is completely based on paths. Regarding usage of Servlet Filters as pip

[jira] [Commented] (SLING-2002) Migrate the Sling website to the ASF CMS

[ https://issues.apache.org/jira/browse/SLING-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698716#comment-13698716 ] Felix Meschberger commented on SLING-2002: -- I have added more hints yet in Revs 1

Re: FYI, working on @AdapterMethod

On Tue, Jul 2, 2013 at 7:39 PM, Alexander Klimetschek wrote: > Felix wrote: >>> ...(3) Maybe we can find a better name for the AdapterMethodProvider >>> interface -- something >>> which is more in line with the AdapterFactory service name. >> > What about simply "AdapterProvider"?... Good idea,

Re: [Status Update] Apache Cassandra backend for Sling

Hi Dishara, On Tue, Jul 2, 2013 at 6:51 PM, Dishara Wijewardana wrote: > ...Does each bundle in sling made to run their junit tests separately at build > time... Could you start new threads with new subject lines when you start a new question or discussion? Otherwise it's very hard to find thin