Hi all
Sling Thread Support (aka Commons Threads) uses an underlying
java.util.concurrent.ThreadPoolExecutor. By default this leads to
thread names like "pool-1-thread-5".
I was wondering whether we should change the thread names so it is
clear they are being managed by Sling Thread Support.
I’m in favour for changing the thread names to the format "Apache Sling - -Thread #”
Konrad
> On 01 Dec 2015, at 10:15, Julian Sedding wrote:
>
> Hi all
>
> Sling Thread Support (aka Commons Threads) uses an underlying
> java.util.concurrent.ThreadPoolExecutor. By default
It would be better to keep it short as it get used in logs/stacktrace
etc. So something like "sling--"
Chetan Mehrotra
On Tue, Dec 1, 2015 at 2:48 PM, Konrad Windszus wrote:
> I’m in favour for changing the thread names to the format "Apache Sling -
> -Thread #”
> Konrad
>
>
On Tue, Dec 1, 2015 at 10:35 AM, Chetan Mehrotra
wrote:
> ...It would be better to keep it short as it get used in logs/stacktrace
> etc. So something like "sling--" ...
+1
-Bertrand
Julian Sedding created SLING-5343:
-
Summary: Meaningful thread names
Key: SLING-5343
URL: https://issues.apache.org/jira/browse/SLING-5343
Project: Sling
Issue Type: Improvement
Are we "allowed" to abbreviate "Apache Sling" to "sling"?
The pool name can be set by configuration or by a consuming bundle,
e.g. "Apache Sling Job Thread Pool" is set by the EventingThreadPool
implementation. Therefore I lean to a mixed-case format (despite the
fact that I normally prefer all
[
https://issues.apache.org/jira/browse/SLING-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding updated SLING-5343:
--
Attachment: SLING-5343.patch
Proposed patch. Let's wait which format we finally decide to use
FYI, I created https://issues.apache.org/jira/browse/SLING-5343 with a
proposed patch attached.
Regards
Julian
On Tue, Dec 1, 2015 at 11:12 AM, Julian Sedding wrote:
> Are we "allowed" to abbreviate "Apache Sling" to "sling"?
>
> The pool name can be set by configuration or
[
https://issues.apache.org/jira/browse/SLING-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-5026:
---
Description:
Currently each {{Validator}} can only set one error message through the String
On Tue, Dec 1, 2015 at 11:12 AM, Julian Sedding wrote:
> ...Are we "allowed" to abbreviate "Apache Sling" to "sling"?...
For technical names yes, of course...if you see "sling" in a system
that's running Apache Sling there's no possible confusion ;-)
-Bertrand
>It would be better to keep it short as it get used in logs/stacktrace
>etc. So something like "sling--"
+1
+1
On Dec 1, 2015 5:55 AM, "Stefan Seifert" wrote:
> >It would be better to keep it short as it get used in logs/stacktrace
> >etc. So something like "sling--"
>
> +1
>
Jon Ekdahl created SLING-5344:
-
Summary: Request log format string %D
Key: SLING-5344
URL: https://issues.apache.org/jira/browse/SLING-5344
Project: Sling
Issue Type: Bug
Components:
[
https://issues.apache.org/jira/browse/SLING-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033660#comment-15033660
]
Julian Sedding edited comment on SLING-5343 at 12/1/15 2:39 PM:
Fixed in
Hi Bertrand
I just added more tests to also cover the refactored priority logic
(https://svn.apache.org/r1717440).
Regards
Julian
On Tue, Dec 1, 2015 at 2:43 PM, Bertrand Delacretaz
wrote:
> Hi,
>
> On Tue, Dec 1, 2015 at 2:38 PM, Bertrand Delacretaz
>
On Tue, Dec 1, 2015 at 2:20 PM, Julian Sedding wrote:
> Thanks for your inputs. I went ahead and committed the change
> (https://svn.apache.org/r1717425).
That's https://svn.apache.org/r1717424 actually.
-Bertrand
[
https://issues.apache.org/jira/browse/SLING-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso reassigned SLING-5345:
Assignee: Antonio Sanso
> StreamRendererServlet return no content-type
>
Julian Sedding wrote
> Thanks for your inputs. I went ahead and committed the change
> (https://svn.apache.org/r1717425).
>
> The format is "Sling - #". If someone has a
> strong preference for an alternative, please go ahead and change it.
> It uses String#format().
>
Maybe I'm the only one,
[
https://issues.apache.org/jira/browse/SLING-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033680#comment-15033680
]
Bertrand Delacretaz commented on SLING-5269:
Sorry for the delay, I have now created the IP
Antonio Sanso created SLING-5345:
Summary: StreamRendererServlet return no content-type
Key: SLING-5345
URL: https://issues.apache.org/jira/browse/SLING-5345
Project: Sling
Issue Type: Bug
Hi,
On Tue, Dec 1, 2015 at 2:38 PM, Bertrand Delacretaz
wrote:
> ...That's https://svn.apache.org/r1717424 actually...
That revision includes changes to the
ExtendedThreadFactory.convertPriority method, is that on purpose?
Looks unrelated to the thread name change.
[
https://issues.apache.org/jira/browse/SLING-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033660#comment-15033660
]
Julian Sedding edited comment on SLING-5343 at 12/1/15 1:17 PM:
Fixed in
[
https://issues.apache.org/jira/browse/SLING-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding resolved SLING-5343.
---
Resolution: Fixed
Fixed in [1717425|https://svn.apache.org/1717425].
I opted for the
[
https://issues.apache.org/jira/browse/SLING-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding updated SLING-5343:
--
Fix Version/s: Commons Threads 3.2.4
> Meaningful thread names
> ---
>
>
Thanks for your inputs. I went ahead and committed the change
(https://svn.apache.org/r1717425).
The format is "Sling - #". If someone has a
strong preference for an alternative, please go ahead and change it.
It uses String#format().
Regards
Julian
On Tue, Dec 1, 2015 at 11:57 AM, Daniel Klco
[
https://issues.apache.org/jira/browse/SLING-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033660#comment-15033660
]
Julian Sedding edited comment on SLING-5343 at 12/1/15 2:20 PM:
Fixed in
Thanks for catching the revision error.
The priority related changes don't change behaviour. In order to
de-clutter the constructor I moved the switch statement to the new
convertPriority method and slightly simplified it at the same time.
Regards
Julian
On Tue, Dec 1, 2015 at 2:43 PM, Bertrand
On Tue, Dec 1, 2015 at 2:58 PM, Carsten Ziegeler wrote:
> Julian Sedding wrote
>> Thanks for your inputs. I went ahead and committed the change
>> (https://svn.apache.org/r1717425).
>>
>> The format is "Sling - #". If someone has a
>> strong preference for an alternative,
On Tue, Dec 1, 2015 at 2:58 PM, Carsten Ziegeler wrote:
> ...I would prefer a name without spaces. Makes
> parsing the log files easier...
+1
Maybe just replace spaces in pool names with a dash.
-Bertrand
29 matches
Mail list logo