Thanks Gaston,
I think the PR is good to go, waiting for others to chime in
A PR for the feature model README with links back to the How-Tos landing
page sounds great!
Afaik, we don't have concrete plans for downloads of feature models or
archives, but thats certainly something we could do.
Carsten Ziegeler created SLING-9525:
---
Summary: Create repoinit analyser
Key: SLING-9525
URL: https://issues.apache.org/jira/browse/SLING-9525
Project: Sling
Issue Type: New Feature
Hi Bertrand, I did just that (moved the code up to the public package) and
submitted a PR for it:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/5
Let me know what you think.
Carlos
On Thu, Jun 11, 2020 at 8:24 AM Bertrand Delacretaz
wrote:
> Hi,
>
> On Thu, Jun 11, 2020
carlosmunoz opened a new pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/5
By promoting impl/operations.AbstractPostOperation to the exported package.
This has a minor implication: all extensions of `AbstractPostOperation` will
now require
sonarcloud[bot] commented on pull request #3:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/3#issuecomment-645608844
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=3=false=BUG)
taestell commented on pull request #3:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/3#issuecomment-645604196
@rombert - Okay, I think it should be ready to merge now. Let me know if any
other changes are needed.
Hi All,
I updated the PR with your feedback. If there is anything else that requires
changes, please let me know.
A couple of questions on my end:
Would you like me to create a PR that links the Feature Model README back to
the main How-To landing page?
Are there plans to create an official
GastonGonzalez commented on pull request #48:
URL: https://github.com/apache/sling-site/pull/48#issuecomment-645505183
> Thank you for this great contribution! I like the howto pages a lot (in
general - haven't checked all the details but they can evolve anyway), with
just a few tweaks:
GastonGonzalez commented on a change in pull request #48:
URL: https://github.com/apache/sling-site/pull/48#discussion_r441700502
##
File path: src/main/jbake/content/documentation/development/feature-model.md
##
@@ -11,4 +11,74 @@ standard. It has been created in Sling as
Dan Klco created SLING-9524:
---
Summary: Add Support for Bundle URL References
Key: SLING-9524
URL: https://issues.apache.org/jira/browse/SLING-9524
Project: Sling
Issue Type: New Feature
bdelacretaz edited a comment on pull request #48:
URL: https://github.com/apache/sling-site/pull/48#issuecomment-645416337
Thank you for this great contribution! I like the howto pages a lot (in
general - haven't checked all the details but they can evolve anyway), with
just a few tweaks:
bdelacretaz commented on pull request #48:
URL: https://github.com/apache/sling-site/pull/48#issuecomment-645416337
Thank you for this great contribution! I like the howto pages a lot (in
general - haven't checked all the details but they can evolve anyway), with
just a few tweaks:
*
It is in no way duplicate but additional - if someone wants to move that
content to the plugin site documentation, that's fine.
Still, the site deployment requires extra steps and they get easily
forgotten as we can see on our web site. For example for the feature
model plugin, latest
Getting back to the real topic :)
I think the howtos could be part of the site - most of them are about
more than one module.
As commented on the PR, maybe the introduction can be shortened to
reduce duplication with what is already in the feature model git repository.
But that's more a
cziegeler commented on a change in pull request #48:
URL: https://github.com/apache/sling-site/pull/48#discussion_r441570672
##
File path: src/main/jbake/content/documentation/development/feature-model.md
##
@@ -11,4 +11,74 @@ standard. It has been created in Sling as that's
Maintaining all mojos with parameters correctly manually in the README is a lot
of overhead (IMHO more than generating the site).
This information comes for free from the code!
Strongly recommend to remove that duplicate info from the readme and instead
start generating the site :-)
The steps
Releasing the site requires extra steps which easily gets forgotten.
Right now, the majority of the documentation is in the README in git and
the site points to that file
Carsten
Am 17.06.2020 um 15:38 schrieb Konrad Windszus:
For the maven-plugins let us rely on the generated site (which
For the maven-plugins let us rely on the generated site (which evaluates
javadoc and other metainformation already nicely) and allows to use MD for
additional pages.
I prefer that for maven-plugins over a big readme as generating the site is a
no-brainer during the release and has a standard
Hi Bertrand,
no, it's me that totally missed it was, cool!
and sorry for the waste of your time
Nicolas
Le mer. 17 juin 2020 à 12:17, Bertrand Delacretaz
a écrit :
> Hi Nicolas,
>
> On Mon, Jun 15, 2020 at 4:29 PM Nicolas Peltier
> wrote:
> > ...i'd be grateful to have sling-pipes too please
Thanks Bertrand,
that definitely works for me - and is inline with my thoughts as well :)
Regards
Carsten
Am 17.06.2020 um 11:00 schrieb Bertrand Delacretaz:
Hi,
On Wed, Jun 17, 2020 at 7:50 AM Carsten Ziegeler wrote:
...Now, I don't want to open a big box here and I don't want to block
[
https://issues.apache.org/jira/browse/SLING-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138317#comment-17138317
]
Bertrand Delacretaz commented on SLING-9519:
Thank you and you're right about the second
Hi Nicolas,
On Mon, Jun 15, 2020 at 4:29 PM Nicolas Peltier wrote:
> ...i'd be grateful to have sling-pipes too please (
> https://github.com/apache/sling-org-apache-sling-pipes) ...
It looks like it's already configured correctly,
[
https://issues.apache.org/jira/browse/SLING-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138312#comment-17138312
]
Fabrice Bellingard commented on SLING-9519:
---
Hello [~bdelacretaz]!
Done for GraphQL-Core =>
Hi,
On Wed, Jun 17, 2020 at 7:50 AM Carsten Ziegeler wrote:
> ...Now, I don't want to open a big box here and I don't want to block such
> great contributions, but it would be great if we can agree on a single
> place where to document these things...
Given the long history of our more than 300
Nicolas Peltier created SLING-9523:
--
Summary: package pipe should not pass bad init
Key: SLING-9523
URL: https://issues.apache.org/jira/browse/SLING-9523
Project: Sling
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SLING-9521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert reassigned SLING-9521:
-
Assignee: A. J. David Bosschaert
> Packages exported in earlier API
rombert commented on pull request #3:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/3#issuecomment-645214923
@taestell - can you please:
- squash the two commits into a single one
- reference the Jira issue in the title ( e.g. SLING-7731 - Call to
rombert commented on pull request #3:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/3#issuecomment-645204692
@cziegeler - I think you are the original author of the code, can you
please review?
This
[
https://issues.apache.org/jira/browse/SLING-7331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-7331.
---
> Set up Maven aggregator project for all regular modules
>
[
https://issues.apache.org/jira/browse/SLING-7331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-7331.
-
Resolution: Done
[~rombert], [~bdelacretaz], Closing this issue as the Python script works for
30 matches
Mail list logo
