[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784161#comment-17784161
]
Rob McDougall commented on SLING-12131:
---
So, at this point, I think no-one is arguing that the
[
https://issues.apache.org/jira/browse/SLING-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding closed SLING-11935.
--
> JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows
>
[
https://issues.apache.org/jira/browse/SLING-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding closed SLING-12126.
--
> Update o.a.s.repoinit.parser to 1.9.0 in feature model analyzer
>
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387262475
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -152,7 +154,9 @@ private static void setAcl(Session session, List
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784213#comment-17784213
]
Julian Sedding edited comment on SLING-12131 at 11/8/23 9:49 PM:
-
bq.
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784213#comment-17784213
]
Julian Sedding edited comment on SLING-12131 at 11/8/23 9:49 PM:
-
jsedding merged PR #145:
URL: https://github.com/apache/sling-site/pull/145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsedding merged PR #144:
URL: https://github.com/apache/sling-site/pull/144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387259771
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclVisitor.java:
##
Review Comment:
I did this refactoring so that
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387260516
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -152,7 +154,9 @@ private static void setAcl(Session session, List
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387260196
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -420,7 +419,7 @@ private static boolean isValidPath(@NotNull Session
+1 - all checks ok
Regards
Julian
On Wed, Nov 8, 2023 at 3:40 PM Daniel Klco wrote:
>
> My +1
>
> On Wed, Nov 8, 2023 at 8:20 AM Robert Munteanu wrote:
>
> > On Sun, 2023-11-05 at 23:22 -0500, Daniel Klco wrote:
> > > Please vote to approve this release:
> >
> > +1
> > Robert
> >
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784146#comment-17784146
]
Julian Sedding commented on SLING-12131:
If migration is the goal, then it may make sense to
renovate-bot opened a new pull request, #144:
URL: https://github.com/apache/sling-site/pull/144
[](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing |
renovate-bot opened a new pull request, #145:
URL: https://github.com/apache/sling-site/pull/145
[](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing |
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1802381013
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784163#comment-17784163
]
Rob McDougall commented on SLING-12131:
---
{quote}A quick google turned up that the OpenRewrite
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387009917
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -152,7 +154,9 @@ private static void setAcl(Session session, List
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387262981
##
src/main/java/org/apache/sling/jcr/repoinit/impl/DoNothingVisitor.java:
##
@@ -66,7 +66,7 @@ protected DoNothingVisitor(Session s) {
[
https://issues.apache.org/jira/browse/SLING-12127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding closed SLING-12127.
--
> Update o.a.s.repoinit.parser to 1.9.0 in slingfeature-maven-plugin
>
[
https://issues.apache.org/jira/browse/SLING-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding closed SLING-11985.
--
> Add report about imported packages
> --
>
>
[
https://issues.apache.org/jira/browse/SLING-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding closed SLING-12009.
--
> Report errors and warnings at the end of the scan
>
[
https://issues.apache.org/jira/browse/SLING-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding closed SLING-9883.
-
> ApisJarMojo: Provide-Capability should be collected from all contained
> bundles and exposed
>
[
https://issues.apache.org/jira/browse/SLING-11987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding closed SLING-11987.
--
> Allow report into a single file
> ---
>
> Key:
[
https://issues.apache.org/jira/browse/SLING-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding closed SLING-11948.
--
> Get rid of legacy maven-compat dependency
> -
>
>
[
https://issues.apache.org/jira/browse/SLING-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding closed SLING-11947.
--
> Convert Plexus to JSR330 components
> ---
>
>
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784213#comment-17784213
]
Julian Sedding commented on SLING-12131:
bq. I've used this before and it works well, [...]
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387263538
##
src/test/java/org/apache/sling/jcr/repoinit/GeneralAclTest.java:
##
@@ -270,9 +270,9 @@ private void verifyRegisterNamespace(String
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387262981
##
src/main/java/org/apache/sling/jcr/repoinit/impl/DoNothingVisitor.java:
##
@@ -66,7 +66,7 @@ protected DoNothingVisitor(Session s) {
sonarcloud[bot] commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1802976809
Kudos, SonarCloud Quality Gate passed! [](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age |
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784238#comment-17784238
]
Julian Sedding commented on SLING-12131:
We have {{org.apache.sling.testing.osgi-mock}} and
sonarcloud[bot] commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1803106704
SonarCloud Quality Gate failed. [![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-11853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco closed SLING-11853.
> CMS - Editor Submit Buttons Sporadically Un-selectable in Mobile
>
[
https://issues.apache.org/jira/browse/SLING-11810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco closed SLING-11810.
> CMS - Reference Component Escaping Issues
> -
>
>
[
https://issues.apache.org/jira/browse/SLING-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco closed SLING-12011.
> CMS - Use LazyBindings
> --
>
> Key: SLING-12011
> URL:
[
https://issues.apache.org/jira/browse/SLING-11808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco closed SLING-11808.
> Cannot run SlingCMS 1.1.2+ on Windows
> -
>
> Key:
[
https://issues.apache.org/jira/browse/SLING-12121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco closed SLING-12121.
> Repository Path Substitution Incorrect
> --
>
> Key:
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784231#comment-17784231
]
Rob McDougall commented on SLING-12131:
---
{quote}So I think we're finding common ground :) I'm
sonarcloud[bot] commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1803076700
SonarCloud Quality Gate failed. [![Quality Gate
jsedding commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1803003694
@anchela thank you for the review! I have tried to address the issues you
pointed out, and I have tried to simplify the diff of the AclVisitor class,
without
[
https://issues.apache.org/jira/browse/SLING-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco closed SLING-12012.
> CMS - Add Recent Drafts List
>
>
> Key: SLING-12012
>
[
https://issues.apache.org/jira/browse/SLING-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco closed SLING-12120.
> Align Feature Structure with Starter
>
>
> Key:
[
https://issues.apache.org/jira/browse/SLING-12119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco closed SLING-12119.
> Remove Dependency on Guava from CMS
> ---
>
> Key:
Carsten Ziegeler created SLING-12134:
Summary: Don't log error message if analyser results has only
warnings
Key: SLING-12134
URL: https://issues.apache.org/jira/browse/SLING-12134
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-12134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-12134.
--
Resolution: Fixed
rmcdouga commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1801999485
OK, will do. I have some other tasks at work, so it may not happen until
the weekend.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784085#comment-17784085
]
Rob McDougall commented on SLING-12131:
---
> Also, there is virtually no value in doing so, because
+1
On Wed, Nov 8, 2023 at 10:31 AM Julian Sedding wrote:
> +1 - all checks ok
>
> Regards
> Julian
>
> On Wed, Nov 8, 2023 at 2:01 PM Robert Munteanu wrote:
> >
> > On Tue, 2023-11-07 at 10:24 +0100, Timothee Maret wrote:
> > > Please vote to approve this release:
> >
> > +1
> > Robert
>
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784022#comment-17784022
]
Julian Sedding commented on SLING-12131:
bq. Let us please just import the JUnit BOM [...]
+1
On Sun, 2023-11-05 at 23:22 -0500, Daniel Klco wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
+1
Regards
Julian
On Sun, Nov 5, 2023 at 12:39 PM Jörg Hoh wrote:
>
> +1
>
> Am Sa., 4. Nov. 2023 um 16:07 Uhr schrieb Julian Sedding >:
>
> > Hi,
> >
> > We solved 9 issues in these releases:
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12352907=Text
> >
>
+1 - all checks ok
Regards
Julian
On Wed, Nov 8, 2023 at 2:01 PM Robert Munteanu wrote:
>
> On Tue, 2023-11-07 at 10:24 +0100, Timothee Maret wrote:
> > Please vote to approve this release:
>
> +1
> Robert
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784018#comment-17784018
]
Konrad Windszus commented on SLING-12131:
-
Let us please just import the JUnit BOM in the
Hi,
The vote has passed with the following result:
+1 (binding): Carsten Ziegeler, Joerg Hoh, Julian Sedding
+1 (non-binding): none
I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.
Regards
Julian
On Wed, Nov 8, 2023 at 3:11 PM
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784105#comment-17784105
]
Konrad Windszus edited comment on SLING-12131 at 11/8/23 3:53 PM:
--
My +1
On Wed, Nov 8, 2023 at 8:20 AM Robert Munteanu wrote:
> On Sun, 2023-11-05 at 23:22 -0500, Daniel Klco wrote:
> > Please vote to approve this release:
>
> +1
> Robert
>
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784113#comment-17784113
]
Rob McDougall commented on SLING-12131:
---
> Testing dependencies are never transitive and therefore
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784113#comment-17784113
]
Rob McDougall edited comment on SLING-12131 at 11/8/23 4:19 PM:
>
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784016#comment-17784016
]
Julian Sedding commented on SLING-12131:
AFAIK the latest maven-surefire-plugin automatically
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784105#comment-17784105
]
Konrad Windszus commented on SLING-12131:
-
Testing dependencies are never transitive and
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784016#comment-17784016
]
Julian Sedding edited comment on SLING-12131 at 11/8/23 12:35 PM:
--
On Tue, 2023-11-07 at 10:24 +0100, Timothee Maret wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
[
https://issues.apache.org/jira/browse/SLING-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12062:
--
Description:
The LazyBindings support the lazy evaluation of values to avoid the potential
costly
[
https://issues.apache.org/jira/browse/SLING-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashok Pelluru updated SLING-12064:
--
Fix Version/s: Context-Aware Configuration Impl 1.6.2
> Migrate sling.caconfig.impl to
apelluru merged PR #7:
URL: https://github.com/apache/sling-org-apache-sling-caconfig-impl/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SLING-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashok Pelluru resolved SLING-12064.
---
Resolution: Fixed
> Migrate sling.caconfig.impl to jakarta.json
>
sagarmiglani commented on PR #40:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/40#issuecomment-1801517879
@cziegeler Updated the code, can you please have a look. Now it does not
change the computation of selectors and selector string.
--
This is an automated
69 matches
Mail list logo
