Thank you, all.
Build passed!
On Thu, Nov 23, 2023 at 12:50 AM David Smiley
wrote:
> Mikhail,
>
> This is tracked here: https://issues.apache.org/jira/browse/SOLR-17081
> (thanks Christine) and I've updated it with further details.
> I've been in contact with UV. The build image has been
Mikhail,
This is tracked here: https://issues.apache.org/jira/browse/SOLR-17081
(thanks Christine) and I've updated it with further details.
I've been in contact with UV. The build image has been updated with fonts
and recent builds have succeeded proof:
Hello Yuvraaj,
Recently Crave became prone to specific bug.
https://github.com/apache/solr/actions/runs/6909103380/job/18849339883?pr=2046
java.lang.RuntimeException: Fontconfig head is null, check your fonts or
fonts configuration
at
On 3/10/23 06:49, Kevin Risden wrote:
So in the case of https://github.com/apache/solr/pull/571 that would be
concretely:
git fetch origin pull/571/head:pr-571
git checkout pr-571
This would work if https://github.com/apache/solr is cloned. There should
be no need to try to find a merge base
Disclaimer: technical details that aren't strictly about Solr coming up ahead:
Crave builds and tests the Solr code on a remote server.
The first step to doing that is to "clone the exact sources on the remote
system".
A brute-force way to do that would be rsync the sources from the Github
I guess I'm not quite sure why Crave is trying to find the merge base...
The PR is actually a branch in git - it has the full state of the repo that
should be tested. This is accomplished basically by the following [1]
git fetch origin pull/ID/head:BRANCH_NAME
git checkout BRANCH_NAME
So in the
Upvote for Mikhail's suggestion: That's the root cause of the problem: The PR
has drifted too much for Crave to get a correct git merge base.
Evidence : The PR is at most 8 files. Crave seems to thing it is 42 files and
thousands of changes:
Run ./crave run --clean
42 files changed, 1032
Hello Kevin,
It happened to me too. I fixed it with rebasing pr branch.
$git pull --rebase origin main
$git push -f myfork PR-branch
On Thu, Mar 9, 2023 at 5:50 PM Kevin Risden wrote:
> I've noticed failures like this on PRs quite a few times when github
> actions for `./gradlew check` pass no
I've noticed failures like this on PRs quite a few times when github
actions for `./gradlew check` pass no issue.
https://github.com/apache/solr/actions/runs/4375627158/jobs/7656583100
Setting up workspace (this could take some time)...
> Pulling container image...
> Finished pulling container
Looks like crave test (in github actions) is still somewhat unstable, sometimes
failing to allocate resoources?
Also, question regarding how to inspect crave failed tests. How to access the
full log, it just says it is at file:///tmp/... but is there a way for crave to
generate a URL where one
Updated default command to
./gradlew localSettings && ./gradlew --max-workers=`nproc` -Ptests.jvms=96 test
Thanks,
-Uv
On Jan 29 2023, at 5:00 am, Ishan Chattopadhyaya
wrote:
> Thanks to Crave! Seems like there's Dual XEON 24 core processors
> available on the system.
>
> I pushed the
Thanks to Crave! Seems like there's Dual XEON 24 core processors
available on the system.
I pushed the parallelism to 96, and times reduced from 8.5 min to ~5.5 min.
~/crave run -- './gradlew localSettings && ./gradlew
--max-workers=`nproc` -Ptests.jvms=96 test'
The slowest tests (exceeding
Fantastic!
> On Jan 27, 2023, at 10:36 PM, Yuvraaj Kelkar wrote:
>
> Hurray!
>
> On Fri, Jan 27, 2023, 19:27 David Smiley wrote:
>
>> The PR is merged. Henceforth, all java based tests will run on PRs.
>> Also "crave run" now has the defaults so you can run that at your terminal
>>
Hurray!
On Fri, Jan 27, 2023, 19:27 David Smiley wrote:
> The PR is merged. Henceforth, all java based tests will run on PRs.
> Also "crave run" now has the defaults so you can run that at your terminal
> without adding all the extra args :-)
>
> I did an experiment[1] wondering how long it
The PR is merged. Henceforth, all java based tests will run on PRs.
Also "crave run" now has the defaults so you can run that at your terminal
without adding all the extra args :-)
I did an experiment[1] wondering how long it would take a typical GitHub
Action machine to run all these Solr
@Ishan - not necessarily, a committer has to explicitly approve running the
GHA checks for first time contributors. So a random person with a drive-by
PR won't be automatically handed the keys to our infra. I believe we can
set that to needing approval for each run by a non-committer, or maybe
Non-committers’ PRs do not have Github Actions run automatically. A
committer has to press a button to allow the tests to run. So unless a
committer is malicious, there shouldnt be a problem there.
On Thu, Jan 26, 2023 at 10:18 AM Ishan Chattopadhyaya <
ichattopadhy...@gmail.com> wrote:
>
Though, if a malicious user creates a PR that executes harmful code, that
PR will also get executed (via "gradlew test"), right?
On Thu, 26 Jan, 2023, 8:36 pm Yuvraaj Kelkar, wrote:
> Hm. I see your point. The first solution I thought of is a bit blunt, but
> it will work: We disable command
Hm. I see your point. The first solution I thought of is a bit blunt, but it
will work: We disable command line arguments when using ZeroConf. Only preset
commands are allowed.
Also, to allow the Solr GHA to run whatever commands needed not just for now,
but also for any future changes, we set
Having massive infrastructure to run PRs is pretty cool.
I'm worried about letting arbitrary people run code on these
machines though - a single 'crave run -- mine_bitcoin.exe' would ruin the
system for everybody, or it's not hard to imagine a slightly more indirect
case where an attacker adds a
This is very cool. Thanks for working on this, David. Can multiple
developers execute their tests at the same time?
On Thu, 26 Jan, 2023, 5:07 am Noble Paul, wrote:
> This is interesting.
>
> So, if the PR is merged , we will have the full test running on crave.io
> for every PR raised?
>
> On
This is interesting.
So, if the PR is merged , we will have the full test running on crave.io
for every PR raised?
On Thu, Jan 26, 2023 at 9:22 AM David Smiley wrote:
> We haven't been running all our tests in GitHub Actions (i.e. PR
> validation) because it was too time consuming to do so. I
This looks awesome. Is Crave really prepared for anyone in the world to run
this build on their hardware whenever they want? or does it require
membership/paid? If there is a limit is it per person or per project?
I don't mind a command of that length so much. That's what bash history is
for (or
We haven't been running all our tests in GitHub Actions (i.e. PR
validation) because it was too time consuming to do so. I don't recall how
slow it was when someone last tried; it's probably better now but still
slow. To make up for this, there is a GHA only for SolrJ if a PR touches
SolrJ.
24 matches
Mail list logo
