[GitHub] storm pull request: STORM-625: don't leak netty clients when worke...

2015-03-12 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/455#issuecomment-78082542 Turns out that @kishorvpatil found a bug in this during some testing and should be putting up a fixed pull request shortly. --- If your project is set up for it, you can

[jira] [Commented] (STORM-625) Netty context never forgets about a Client.

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357075#comment-14357075 ] ASF GitHub Bot commented on STORM-625: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-638:UI should show up process-id of the ...

2015-03-12 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/396#issuecomment-78354003 @revans2 not quite comfortable with exposing pid on UI. UI is supposed to be available for all the users. In non-secure env it can be run without any filter so I am again

Re: New Committer/PMC Member: Thomas Becker

2015-03-12 Thread Michael G. Noll
Welcome aboard, Thomas! :-) --Michael > On 10.03.2015, at 19:07, P. Taylor Goetz wrote: > > Please join me in welcoming Thomas Becker (wurstmeister) as a new Apache > Storm Committer/PMC member. > > Thomas has made significant contributions to the Storm codebase, particularly > in the area

[jira] [Updated] (STORM-643) KafkaUtils repeat fetch messages which offset is out of range

2015-03-12 Thread Xin Wang (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Wang updated STORM-643: --- Priority: Minor (was: Critical) > KafkaUtils repeat fetch messages which offset is out of range >

[GitHub] storm pull request: STORM-689. SimpleACLAuthorizer should provide ...

2015-03-12 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/445#issuecomment-78291244 @revans2 pinging for a review. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] storm pull request: STORM-689. SimpleACLAuthorizer should provide ...

2015-03-12 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/445#issuecomment-78300710 +1. I think most users would much rather define a nimbus.groups m e can probably file a separate jira for that. --- If your project is set up for it, you can rep

[jira] [Commented] (STORM-689) SimpleACLAuthorizer should provide a way to restrict who can submit topologies

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357139#comment-14357139 ] ASF GitHub Bot commented on STORM-689: -- Github user Parth-Brahmbhatt commented on the

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-03-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/414#discussion_r26229576 --- Diff: storm-core/src/clj/backtype/storm/converter.clj --- @@ -0,0 +1,200 @@ +(ns backtype.storm.converter --- End diff -- I think it is OK

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357176#comment-14357176 ] ASF GitHub Bot commented on STORM-634: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-03-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/414#discussion_r26231202 --- Diff: storm-core/src/storm.thrift --- @@ -243,6 +244,55 @@ struct SubmitOptions { 2: optional Credentials creds; } +struct SupervisorI

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-03-12 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/414#issuecomment-78313719 For the most part it looks good. I had a few minor comments. My only real concern is about maintaining backwards compatibility for clients. I didn't see much that would

[GitHub] storm pull request: [STORM-681] Auto insert license header with ge...

2015-03-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/436#discussion_r26235414 --- Diff: storm-core/src/genthrift.sh --- @@ -17,6 +17,16 @@ rm -rf gen-javabean gen-py py rm -rf jvm/backtype/storm/generated thrift7 --gen java

[jira] [Commented] (STORM-469) Storm UI Last Error Detail Insufficient for debugging

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357307#comment-14357307 ] ASF GitHub Bot commented on STORM-469: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-469

2015-03-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357376#comment-14357376 ] ASF GitHub Bot commented on STORM-638: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: STORM-638:UI should show up process-id of the ...

2015-03-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/396#discussion_r26242766 --- Diff: storm-core/src/ui/public/templates/component-page-template.html --- @@ -211,6 +216,7 @@ {{uptime}} {{host}} {{

[GitHub] storm pull request: STORM-541:Clean duplicate dependences in poms

2015-03-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/422#discussion_r26250879 --- Diff: pom.xml --- @@ -521,12 +521,6 @@ test -org.clojars.runa -

[GitHub] storm pull request: STORM-657:make the shutdown-worker sleep time ...

2015-03-12 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/421#issuecomment-78360046 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[jira] [Resolved] (STORM-670) [storm-kafka] Restore Java 1.6 compatibility

2015-03-12 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-670. --- Resolution: Fixed Fix Version/s: 0.10.0 Thanks [~ptgoetz], I merged this into m

RE: [DISCUSS] Release Storm 0.9.4 / 0.10.0

2015-03-12 Thread Richard Kellogg
Suggest we pull in STORM-559 as well. It is strictly an update to documentation and has already been merged to trunk. -Original Message- From: P. Taylor Goetz [mailto:ptgo...@gmail.com] Sent: Wednesday, March 11, 2015 4:51 PM To: dev@storm.apache.org Subject: Re: [DISCUSS] Release Storm

[jira] [Commented] (STORM-650) Storm-Kafka Refactoring and Improvements

2015-03-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358844#comment-14358844 ] Sriharsha Chintalapani commented on STORM-650: -- Thanks for summarizing [~wurst

Re: [DISCUSS] Release Storm 0.9.4 / 0.10.0

2015-03-12 Thread T B
+1 for releasing 0.9.4 Thomas On 11 March 2015 at 21:39, Richard Kellogg wrote: > Suggest we pull in STORM-559 as well. It is strictly an update to > documentation and has already been merged to trunk. > > -Original Message- > From: P. Taylor Goetz [mailto:ptgo...@gmail.com] > Sent: We

[GitHub] storm pull request: STORM-446: Allow superusers to impersonate oth...

2015-03-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/448 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-446) secure Impersonation in storm

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358985#comment-14358985 ] ASF GitHub Bot commented on STORM-446: -- Github user asfgit closed the pull request at:

[jira] [Resolved] (STORM-496) task.clj missing debug for logging spout and bolt emit values

2015-03-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani resolved STORM-496. -- Resolution: Fixed > task.clj missing debug for logging spout and bolt emit values

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359194#comment-14359194 ] ASF GitHub Bot commented on STORM-634: -- Github user Parth-Brahmbhatt commented on the

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-03-12 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/414#discussion_r26334368 --- Diff: storm-core/src/jvm/backtype/storm/serialization/DefaultSerializationDelegate.java --- @@ -17,11 +17,7 @@ */ package backtype.sto

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359192#comment-14359192 ] ASF GitHub Bot commented on STORM-634: -- Github user Parth-Brahmbhatt commented on a di

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-03-12 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/414#issuecomment-78574474 @revans2 All comments addressed and I really appreciate the time you are taking to review this. --- If your project is set up for it, you can reply to this emai

[GitHub] storm pull request: STORM-615. Add REST API to upload topology.

2015-03-12 Thread harshach
GitHub user harshach opened a pull request: https://github.com/apache/storm/pull/464 STORM-615. Add REST API to upload topology. You can merge this pull request into a Git repository by running: $ git pull https://github.com/harshach/incubator-storm STORM-615-V2 Alternatively

[jira] [Commented] (STORM-615) Add REST API to upload topology

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359397#comment-14359397 ] ASF GitHub Bot commented on STORM-615: -- GitHub user harshach opened a pull request:

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-03-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/414#issuecomment-78618488 @revans2 I agree that it would be great to test forward/backward compatibility, but testing that in an automated way would be really difficult since it would likely requir

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359420#comment-14359420 ] ASF GitHub Bot commented on STORM-634: -- Github user ptgoetz commented on the pull requ

[GitHub] storm pull request: STORM-689. SimpleACLAuthorizer should provide ...

2015-03-12 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/445#issuecomment-78663596 @Parth-Brahmbhatt @revans2 Thanks for the review. I updated the PR to include nimbus.groups as well and added doc under SECURITY.md. Please take a look. --- If your pro

[jira] [Commented] (STORM-689) SimpleACLAuthorizer should provide a way to restrict who can submit topologies

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359557#comment-14359557 ] ASF GitHub Bot commented on STORM-689: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-689. SimpleACLAuthorizer should provide ...

2015-03-12 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/445#issuecomment-78667664 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[jira] [Commented] (STORM-689) SimpleACLAuthorizer should provide a way to restrict who can submit topologies

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359564#comment-14359564 ] ASF GitHub Bot commented on STORM-689: -- Github user Parth-Brahmbhatt commented on the

[GitHub] storm pull request: STORM-682: supervisor should handle worker sta...

2015-03-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-682) Supervisor local worker state corrupted and failing to start.

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359579#comment-14359579 ] ASF GitHub Bot commented on STORM-682: -- Github user asfgit closed the pull request at:

[jira] [Created] (STORM-704) Apply Travis CI

2015-03-12 Thread Jungtaek Lim (JIRA)
Jungtaek Lim created STORM-704: -- Summary: Apply Travis CI Key: STORM-704 URL: https://issues.apache.org/jira/browse/STORM-704 Project: Apache Storm Issue Type: Improvement Environment:

[jira] [Comment Edited] (STORM-704) Apply Travis CI

2015-03-12 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359730#comment-14359730 ] Jungtaek Lim edited comment on STORM-704 at 3/13/15 1:12 AM: - I

[jira] [Assigned] (STORM-704) Apply Travis CI

2015-03-12 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim reassigned STORM-704: -- Assignee: Jungtaek Lim > Apply Travis CI > --- > > Key: STORM-704 >

[jira] [Commented] (STORM-704) Apply Travis CI

2015-03-12 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359730#comment-14359730 ] Jungtaek Lim commented on STORM-704: I'm trying this now. > Apply Travis CI >

[GitHub] storm pull request: STORM-702: Exhibitor support

2015-03-12 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/432#issuecomment-78750701 @atdixon @revans2 with this patch can a user who doesn't want use exhibitor avoid it by not having the config or the user must have the config in their storm.yaml. ---

[jira] [Commented] (STORM-702) Apache Exhibitor support

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359806#comment-14359806 ] ASF GitHub Bot commented on STORM-702: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-541:Clean duplicate dependences in poms

2015-03-12 Thread caofangkun
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/422#discussion_r26361833 --- Diff: pom.xml --- @@ -521,12 +521,6 @@ test -org.clojars.runa -

[jira] [Commented] (STORM-541) Build produces maven warnings

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359836#comment-14359836 ] ASF GitHub Bot commented on STORM-541: -- Github user caofangkun commented on a diff in

[GitHub] storm pull request: STORM-702: Exhibitor support

2015-03-12 Thread atdixon
Github user atdixon commented on the pull request: https://github.com/apache/storm/pull/432#issuecomment-78764060 The config is optional. If not present, everything works as usual. On Thu, Mar 12, 2015 at 9:18 PM, Harsha wrote: > @atdixon @revans2 with this patch can

[jira] [Commented] (STORM-702) Apache Exhibitor support

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359840#comment-14359840 ] ASF GitHub Bot commented on STORM-702: -- Github user atdixon commented on the pull requ

[GitHub] storm pull request: STORM-532:Supervisor should restart worker imm...

2015-03-12 Thread caofangkun
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/296#discussion_r26362192 --- Diff: storm-core/src/clj/backtype/storm/util.clj --- @@ -392,6 +392,15 @@ (.addArgument command a)) (.execute (DefaultExecutor.) comm

[jira] [Commented] (STORM-532) Supervisor should restart worker immediately, if the worker process does not exist any more

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359847#comment-14359847 ] ASF GitHub Bot commented on STORM-532: -- Github user caofangkun commented on a diff in

[GitHub] storm pull request: STORM-638:UI should show up process-id of the ...

2015-03-12 Thread caofangkun
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/396#discussion_r26362269 --- Diff: storm-core/src/storm.thrift --- @@ -205,7 +205,8 @@ struct ExecutorSummary { 2: required string component_id; 3: required string host

[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359852#comment-14359852 ] ASF GitHub Bot commented on STORM-638: -- Github user caofangkun commented on a diff in

[GitHub] storm pull request: STORM-689. SimpleACLAuthorizer should provide ...

2015-03-12 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/445#issuecomment-78814683 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[jira] [Commented] (STORM-689) SimpleACLAuthorizer should provide a way to restrict who can submit topologies

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359973#comment-14359973 ] ASF GitHub Bot commented on STORM-689: -- Github user vesense commented on the pull requ

[jira] [Commented] (STORM-704) Apply Travis CI

2015-03-12 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359987#comment-14359987 ] Jungtaek Lim commented on STORM-704: It's first success build of Apache Storm from Trav

[jira] [Issue Comment Deleted] (STORM-704) Apply Travis CI

2015-03-12 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-704: --- Comment: was deleted (was: It's first success build of Apache Storm from Travis CI. [https://travis-ci

[jira] [Commented] (STORM-704) Apply Travis CI

2015-03-12 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359994#comment-14359994 ] Jungtaek Lim commented on STORM-704: Sorry I have mistaken. egrep consumes maven's retu

[jira] [Updated] (STORM-704) Apply Travis CI

2015-03-12 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-704: --- Description: Now Apache Storm takes advantage of Github, we can apply Travis CI to some more advantage

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-03-12 Thread 2new
Github user 2new commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-78835043 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[jira] [Commented] (STORM-643) KafkaUtils repeat fetch messages which offset is out of range

2015-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360022#comment-14360022 ] ASF GitHub Bot commented on STORM-643: -- Github user 2new commented on the pull request