[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200040#comment-15200040 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on a diff in the pull request:

[GitHub] storm pull request: STORM-1616: Add RAS API for Trident

2016-03-19 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1199#issuecomment-197539412 @arunmahadevan @satishd @ptgoetz, Would like your comments on the builder pattern. There are +1's but I believe there were some concerns. --- If your project is

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199693#comment-15199693 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on a diff in the pull request:

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-19 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r56387329 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -0,0 +1,517 @@ +/* + * Licensed to the

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-19 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r56462751 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -0,0 +1,298 @@ +/* + * Licensed to the

[jira] [Created] (STORM-1634) Minor Refactoring Resource Aware Scheduler

2016-03-19 Thread Boyang Jerry Peng (JIRA)
Boyang Jerry Peng created STORM-1634: Summary: Minor Refactoring Resource Aware Scheduler Key: STORM-1634 URL: https://issues.apache.org/jira/browse/STORM-1634 Project: Apache Storm

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-19 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r56390890 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -0,0 +1,298 @@ +/* + *

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-19 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r56409148 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -0,0 +1,298 @@ +/* + * Licensed to

[GitHub] storm pull request: STORM-1637: Correct the master version of stor...

2016-03-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1231#issuecomment-198389354 BTW, I think @revans2 's main concern is **why JDK7 builds pass while JDK8 builds fail with** in JIRA [STORM-1637](https://issues.apache.org/jira/browse/STORM-1637).

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-19 Thread roshannaik
Github user roshannaik commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-197551650 @abhishekagarwal87 This perf hit of 7-9% exists even if user does not enable logging from the UI. With logging enabled, it should be even higher.

[GitHub] storm pull request: STORM-1537: Upgrade to kryo 3

2016-03-19 Thread abhishekagarwal87
GitHub user abhishekagarwal87 opened a pull request: https://github.com/apache/storm/pull/1223 STORM-1537: Upgrade to kryo 3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/abhishekagarwal87/storm kryo3-1.x Alternatively you

[GitHub] storm pull request: STORM-1483: add storm-mongodb connector

2016-03-19 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1219#issuecomment-197625582 Thanks @vesense merged into 1.x-branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (STORM-1300) port backtype.storm.scheduler.resource-aware-scheduler-test to java

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202168#comment-15202168 ] ASF GitHub Bot commented on STORM-1300: --- GitHub user zhuoliu opened a pull request:

[jira] [Assigned] (STORM-1234) port backtype.storm.security.auth.DefaultHttpCredentialsPlugin-test to java

2016-03-19 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Agarwal reassigned STORM-1234: --- Assignee: Abhishek Agarwal > port

[jira] [Commented] (STORM-584) LoggingMetricsConsumer metrics.log file is shared by multiple topologies.

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197210#comment-15197210 ] ASF GitHub Bot commented on STORM-584: -- GitHub user jnioche opened a pull request:

[jira] [Commented] (STORM-1611) port org.apache.storm.pacemaker.pacemaker to java

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197776#comment-15197776 ] ASF GitHub Bot commented on STORM-1611: --- Github user redsanket commented on a diff in the pull

[jira] [Resolved] (STORM-1602) Blobstore UTs are failing on Windows

2016-03-19 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1602. - Resolution: Fixed Fix Version/s: 1.0.0 Merged into master and 1.x-branch > Blobstore UTs

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1602) Blobstore UTs are failing on Windows

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203051#comment-15203051 ] ASF GitHub Bot commented on STORM-1602: --- Github user asfgit closed the pull request at:

[jira] [Commented] (STORM-1602) Blobstore UTs are failing on Windows

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203050#comment-15203050 ] ASF GitHub Bot commented on STORM-1602: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1227 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Closed] (STORM-1629) Files/move doesn't work properly with non-empty directory in Windows

2016-03-19 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim closed STORM-1629. --- Resolution: Fixed Fix Version/s: 1.0.0 Merged into master and 1.x-branch. > Files/move

[jira] [Commented] (STORM-1629) Files/move doesn't work properly with non-empty directory in Windows

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203048#comment-15203048 ] ASF GitHub Bot commented on STORM-1629: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-19 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1230 [STORM-1573] Add batch support for MongoInsertBolt https://issues.apache.org/jira/browse/STORM-1573 You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197446#comment-15197446 ] ASF GitHub Bot commented on STORM-1057: --- Github user d2r commented on the pull request:

[jira] [Commented] (STORM-1629) Files/move doesn't work properly with non-empty directory in Windows

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203046#comment-15203046 ] ASF GitHub Bot commented on STORM-1629: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-1629 Files/move doesn't work properly wi...

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: Fix logging for LoggingMetricsConsumer on bran...

2016-03-19 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1222#issuecomment-198042109 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-1637: Correct the master version of stor...

2016-03-19 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1231#issuecomment-197915314 This build error is definitely unrelated (intermittent failure in storm-kafka) --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198035#comment-15198035 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on a diff in the pull request:

[jira] [Commented] (STORM-584) LoggingMetricsConsumer metrics.log file is shared by multiple topologies.

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197215#comment-15197215 ] ASF GitHub Bot commented on STORM-584: -- GitHub user jnioche opened a pull request:

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-19 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r56396492 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -0,0 +1,298 @@ +/* + * Licensed to the

[GitHub] storm pull request: hotfix: parent version for pom.xml in storm-mo...

2016-03-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1228#issuecomment-197857053 +1 Good catch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1229#issuecomment-197760319 #1227 is based on 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-19 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r56408115 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -0,0 +1,298 @@ +/* + *

[GitHub] storm pull request: STORM-1637: Correct the master version of stor...

2016-03-19 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1231#issuecomment-198401568 Yes. It is weird. I am taking a look at it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199960#comment-15199960 ] ASF GitHub Bot commented on STORM-822: -- Github user hmcl commented on the pull request:

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1227#issuecomment-198153364 @revans2 Very odd indeed... It should give us error because of storm-mongo module. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (STORM-1602) Blobstore UTs are failing on Windows

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200772#comment-15200772 ] ASF GitHub Bot commented on STORM-1602: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: [STORM-1611] port org.apache.storm.pacemaker.p...

2016-03-19 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1195#discussion_r56557159 --- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj --- @@ -1,242 +0,0 @@ -;; Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1636) Supervisor shutdown with worker id pass in being nil

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198730#comment-15198730 ] ASF GitHub Bot commented on STORM-1636: --- GitHub user jerrypeng opened a pull request:

[jira] [Commented] (STORM-1279) port backtype.storm.daemon.supervisor to java

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198734#comment-15198734 ] ASF GitHub Bot commented on STORM-1279: --- Github user jerrypeng commented on the pull request:

[jira] [Created] (STORM-1637) MongoDB pom.xml fails on JDK8 Travis

2016-03-19 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-1637: -- Summary: MongoDB pom.xml fails on JDK8 Travis Key: STORM-1637 URL: https://issues.apache.org/jira/browse/STORM-1637 Project: Apache Storm Issue

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-19 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r56469003 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaRecordTupleBuilder.java --- @@ -0,0 +1,44 @@ +/* + *

[GitHub] storm pull request: hotfix: parent version for pom.xml in storm-mo...

2016-03-19 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1228#issuecomment-198152909 +1 good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-1611] port org.apache.storm.pacemaker.p...

2016-03-19 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/1195#discussion_r56659070 --- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/Pacemaker.java --- @@ -0,0 +1,372 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197978#comment-15197978 ] ASF GitHub Bot commented on STORM-822: -- Github user abhishekagarwal87 commented on a diff in the pull

[jira] [Commented] (STORM-1629) Files/move doesn't work properly with non-empty directory in Windows

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198713#comment-15198713 ] ASF GitHub Bot commented on STORM-1629: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1624) add maven central status in README

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198514#comment-15198514 ] ASF GitHub Bot commented on STORM-1624: --- Github user asfgit closed the pull request at:

[jira] [Commented] (STORM-1616) Add RAS API for Trident

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200278#comment-15200278 ] ASF GitHub Bot commented on STORM-1616: --- Github user ptgoetz commented on the pull request:

[GitHub] storm pull request: STORM-1616: Add RAS API for Trident

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: Hbasemapstate

2016-03-19 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1225 Hbasemapstate Add HBaseMapState demo You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm hbasemapstate Alternatively you can

[GitHub] storm pull request: [STORM-1623] fix bug about nimbus.clj

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1227 STORM-1602 Blobstore UTs are failed on Windows * ensures objects of InputStream / OutputStream are closed after used * clojure: with-open * java: try-with-resource * skip

[GitHub] storm pull request: hotfix: parent version for pom.xml in storm-mo...

2016-03-19 Thread dossett
Github user dossett commented on the pull request: https://github.com/apache/storm/pull/1228#issuecomment-197833762 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Updated] (STORM-1602) Blobstore UTs are failing on Windows

2016-03-19 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-1602: Summary: Blobstore UTs are failing on Windows (was: Blobstore UTs are failed on Windows) >

[GitHub] storm pull request: hotfix: parent version for pom.xml in storm-mo...

2016-03-19 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1228 hotfix: parent version for pom.xml in storm-mongo is not properly set You can merge this pull request into a Git repository by running: $ git pull https://github.com/HeartSaVioR/storm

[GitHub] storm pull request: [STORM-1636] - Supervisor shutdown with worker...

2016-03-19 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1226#issuecomment-197706290 nice catch. I have considered this when I port supervisor.clj to java. Than you @jerrypeng --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: STORM-1549: Add support for resetting tuple ti...

2016-03-19 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1107#issuecomment-197358536 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-1611] port org.apache.storm.pacemaker.p...

2016-03-19 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1195#issuecomment-197645359 @redsanket @abhishekagarwal87 I have addressed your comments, thank you. @redsanket I also am curious where is the jmx related code implemented. But I don't found, so

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198097#comment-15198097 ] ASF GitHub Bot commented on STORM-822: -- Github user harshach commented on a diff in the pull request:

[jira] [Commented] (STORM-1602) Blobstore UTs are failed on Windows

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199155#comment-15199155 ] ASF GitHub Bot commented on STORM-1602: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1616) Add RAS API for Trident

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198742#comment-15198742 ] ASF GitHub Bot commented on STORM-1616: --- Github user arunmahadevan commented on the pull request:

[jira] [Commented] (STORM-1616) Add RAS API for Trident

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198136#comment-15198136 ] ASF GitHub Bot commented on STORM-1616: --- Github user d2r commented on a diff in the pull request:

[jira] [Commented] (STORM-584) LoggingMetricsConsumer metrics.log file is shared by multiple topologies.

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200191#comment-15200191 ] ASF GitHub Bot commented on STORM-584: -- Github user ptgoetz commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-19 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-197534417 I agree with @arunmahadevan. You can also show an alert message in UI, when user turns on the event logging for a topology e.g. "Event logging may degrade the

[GitHub] storm pull request: STORM-1616: Add RAS API for Trident

2016-03-19 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1199#issuecomment-197702133 @knusbaum I guess the main concern against builder is that we want to maintain compatibility between core and trident. If so I am fine to change both the apis

[jira] [Commented] (STORM-1634) Minor Refactoring of Resource Aware Scheduler

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198672#comment-15198672 ] ASF GitHub Bot commented on STORM-1634: --- Github user jerrypeng commented on the pull request:

[GitHub] storm pull request: [STORM-1611] port org.apache.storm.pacemaker.p...

2016-03-19 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/1195#discussion_r56658785 --- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/Pacemaker.java --- @@ -0,0 +1,372 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197976#comment-15197976 ] ASF GitHub Bot commented on STORM-822: -- Github user harshach commented on a diff in the pull request:

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197947#comment-15197947 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on a diff in the pull request:

[jira] [Commented] (STORM-1464) storm-hdfs should support writing to multiple files

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201176#comment-15201176 ] ASF GitHub Bot commented on STORM-1464: --- Github user arunmahadevan commented on the pull request:

[jira] [Commented] (STORM-1637) MongoDB pom.xml fails on JDK8 Travis

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201596#comment-15201596 ] ASF GitHub Bot commented on STORM-1637: --- Github user abhishekagarwal87 commented on the pull

[jira] [Commented] (STORM-1629) Files/move doesn't work properly with non-empty directory in Windows

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200201#comment-15200201 ] ASF GitHub Bot commented on STORM-1629: --- Github user ptgoetz commented on the pull request:

[jira] [Commented] (STORM-1229) port backtype.storm.metric.testing to java

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202935#comment-15202935 ] ASF GitHub Bot commented on STORM-1229: --- GitHub user abhishekagarwal87 opened a pull request:

[GitHub] storm pull request: STORM-1229: port backtype.storm.metric.testing...

2016-03-19 Thread abhishekagarwal87
GitHub user abhishekagarwal87 opened a pull request: https://github.com/apache/storm/pull/1238 STORM-1229: port backtype.storm.metric.testing to java You can merge this pull request into a Git repository by running: $ git pull https://github.com/abhishekagarwal87/storm

[GitHub] storm pull request: hotfix: parent version for pom.xml in storm-mo...

2016-03-19 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1228#issuecomment-198039817 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-1614) Clean backpressure zk node in do-cleanup

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200224#comment-15200224 ] ASF GitHub Bot commented on STORM-1614: --- Github user ptgoetz commented on the pull request:

[jira] [Commented] (STORM-1636) Supervisor shutdown with worker id pass in being nil

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200093#comment-15200093 ] ASF GitHub Bot commented on STORM-1636: --- Github user redsanket commented on the pull request:

[jira] [Resolved] (STORM-1615) Update state checkpointing doc with bolt's acking contract

2016-03-19 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz resolved STORM-1615. Resolution: Fixed Merged to asf-site. > Update state checkpointing doc with bolt's acking

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-19 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r56399639 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -0,0 +1,298 @@ +/* + *

[GitHub] storm pull request: [STORM-1611] port org.apache.storm.pacemaker.p...

2016-03-19 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1195#issuecomment-197508158 Most of the changes look good, just a question about jmx reporter implementation --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199563#comment-15199563 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on a diff in the pull request:

[jira] [Commented] (STORM-1617) storm.apache.org has no release specific documentation

2016-03-19 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202895#comment-15202895 ] Robert Joseph Evans commented on STORM-1617: I know this is a lot but I think I have things

[GitHub] storm pull request: STORM-1614: backpressure init and cleanup chan...

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1464: Support multiple file outputs

2016-03-19 Thread dossett
Github user dossett commented on the pull request: https://github.com/apache/storm/pull/1044#issuecomment-198393099 @arunmahadevan Writers should never be writing to the same file. `getBasePathForNextFile` will increment the rotation value before opening the file. File name also

[jira] [Commented] (STORM-1617) storm.apache.org has no release specific documentation

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202886#comment-15202886 ] ASF GitHub Bot commented on STORM-1617: --- GitHub user revans2 opened a pull request:

[jira] [Commented] (STORM-1617) storm.apache.org has no release specific documentation

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202894#comment-15202894 ] ASF GitHub Bot commented on STORM-1617: --- GitHub user revans2 opened a pull request:

[GitHub] storm pull request: STORM-1617: Versioned Docs 0.10.x

2016-03-19 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1236 STORM-1617: Versioned Docs 0.10.x This is intended to be merged and used with https://svn.apache.org/repos/asf/storm/branches/bobby-versioned-site You can merge this pull request into a Git

[jira] [Commented] (STORM-1617) storm.apache.org has no release specific documentation

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202887#comment-15202887 ] ASF GitHub Bot commented on STORM-1617: --- GitHub user revans2 opened a pull request:

[GitHub] storm pull request: STORM-1617: Versioned Docs 1.x

2016-03-19 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1235 STORM-1617: Versioned Docs 1.x This is intended to be merged and used with https://svn.apache.org/repos/asf/storm/branches/bobby-versioned-site You can merge this pull request into a Git

[GitHub] storm pull request: STORM-1617: Versioned Docs

2016-03-19 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1234 STORM-1617: Versioned Docs This is intended to be merged and used with https://svn.apache.org/repos/asf/storm/branches/bobby-versioned-site You can merge this pull request into a Git repository by

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199971#comment-15199971 ] ASF GitHub Bot commented on STORM-822: -- Github user harshach commented on a diff in the pull request:

[jira] [Assigned] (STORM-1251) port backtype.storm.serialization.SerializationFactory-test to java

2016-03-19 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Agarwal reassigned STORM-1251: --- Assignee: Abhishek Agarwal > port

[GitHub] storm pull request: [STORM-1623] fix bug about nimbus.clj

2016-03-19 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/1211#issuecomment-197672345 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Updated] (STORM-1634) Minor Refactoring of Resource Aware Scheduler

2016-03-19 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-1634: - Summary: Minor Refactoring of Resource Aware Scheduler (was: Minor Refactoring Resource

[GitHub] storm pull request: Optimized wipeZeros() in SlotBasedCounter.

2016-03-19 Thread hukun01
Github user hukun01 commented on the pull request: https://github.com/apache/storm/pull/1233#issuecomment-198758260 It was failing before I did git clone. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-19 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-197700388 Thanks @roshannaik for detailed explanation. I wasn't expecting this. We should fix the perf hit in the check. --- If your project is set up for it, you can

[jira] [Commented] (STORM-1616) Add RAS API for Trident

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200292#comment-15200292 ] ASF GitHub Bot commented on STORM-1616: --- Github user knusbaum commented on the pull request:

[jira] [Commented] (STORM-1629) Files/move doesn't work properly with non-empty directory in Windows

2016-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200202#comment-15200202 ] ASF GitHub Bot commented on STORM-1629: --- Github user ptgoetz commented on the pull request:

  1   2   3   >