Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1665
Oh, I missed it. Will update. Thanks @priyank5485
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
I would love to see it part of storm/external and can volunteer to provide
any help if required during the migration.
-SG
On Fri, Sep 2, 2016 at 12:59 PM, P. Taylor Goetz wrote:
> I’d like to start a discussion around adding storm-jms as an external
> module. I’ve gotten a
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/1642
I was able to review most of the code. I skimmed the tests and didn't see
anything strange.
@revans2 knows that I will not be able to log on again for awhile. I want
to leave a note for
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77421416
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77421346
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77421324
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77421128
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainerLauncher.java
---
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77419710
--- Diff: storm-core/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -353,25 +350,21 @@ public LocalState nimbusTopoHistoryStateImpl(Map
conf) throws
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77418874
--- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java
---
@@ -0,0 +1,420 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77418692
--- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java
---
@@ -0,0 +1,420 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77418682
--- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java
---
@@ -0,0 +1,420 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77418598
--- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java
---
@@ -0,0 +1,420 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77418561
--- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java
---
@@ -0,0 +1,420 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77418422
--- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java
---
@@ -0,0 +1,420 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
@HeartSaVioR Yes it looks like I need to think through recovery and any
races with the AsyncLocalizer a bit more. I'll try to reproduce your error.
---
If your project is set up for it, you can
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77418240
--- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java
---
@@ -0,0 +1,420 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77418129
--- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java
---
@@ -0,0 +1,420 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77417627
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainerLauncher.java
---
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77417198
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77417265
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorUtils.java ---
@@ -159,7 +162,7 @@ public static void addBlobReferences(Localizer
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77416935
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77416395
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77416200
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77415816
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77415710
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77415373
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,484 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77415016
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1990,31 +1995,26 @@ protected void forceDeleteImpl(String path) throws
IOException {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77414257
--- Diff:
storm-core/test/jvm/org/apache/storm/daemon/supervisor/BasicContainerTest.java
---
@@ -0,0 +1,459 @@
+package
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77413129
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,766 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77411245
--- Diff: storm-core/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -353,25 +350,21 @@ public LocalState nimbusTopoHistoryStateImpl(Map
conf) throws
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77407551
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,493 @@
+/**
+ * Licensed to the Apache Software
I’d like to start a discussion around adding storm-jms as an external module.
I’ve gotten a few request to do so and the only thing that’s held me back is
tracking down contributors and having them submit ICLAs.
The code can be found here:
https://github.com/ptgoetz/storm-jms
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77403662
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,766 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
This is a call to vote on releasing Apache Storm 0.10.2 (rc2)
Full list of changes in this release:
https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHANGELOG.md;hb=d8e4a3b59e6a97165ff769f11c9d4d2d3ecbb9dc
The tag/commit to be voted upon is v0.10.2:
Github user priyank5485 commented on the issue:
https://github.com/apache/storm/pull/1665
@vesense Not sure if you saw my comment about exiting with a code of 1 in
getOldConsumerOffsetsFromZk. Can you check that comment and address it?
---
If your project is set up for it, you can
We have benefited greatly from being downstream from SQE in powering our
data driven solutions.
I am excited to see this repo grow in breadth and depth.
On Fri, Sep 2, 2016 at 11:16 AM, Kamil Sindi wrote:
> Our data science efforts rely on SQE to power our recommendations
Thanks to all the JW Player folks who joined this thread, and welcome to the
Storm community! It’s good to see that the code donation comes with a community
ready and willing to help out.
I’m +1 for accepting the code donation.
-Taylor
> On Sep 2, 2016, at 12:07 PM, Abhishek Agarwal
+1 for the merge. Apart from code contributions, helping users run and
troubleshoot SQE is equally important and it seems that quite a number of
folks are ready to help.
On Fri, Sep 2, 2016 at 8:46 PM, Kamil Sindi wrote:
> Our data science efforts rely on SQE to power our
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77369914
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,766 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77369714
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,766 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77367840
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,766 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77365678
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainerLauncher.java
---
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77364277
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainer.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed to the Apache Software
Our data science efforts rely on SQE to power our recommendations engine. I
am also excited to contribute to it especially as we continue to implement
predictive models at larger scales.
On Fri, Sep 2, 2016 at 10:57 AM, Sahil Shah wrote:
> I would like to throw my support
I would also like to voice my strong support for SQE. This SQL like query
engine empowers our streaming infrastructure and makes it extremely easy to
write production code. Being fairly new to storm, I could pick up and add
SQE queries fairly quickly and enrich our real-time products and services.
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77361882
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainer.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77361623
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainer.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed to the Apache Software
I would like to throw my support behind SQE. Having working with it in a
production environment, I have seen the many benefits in testing new
topologies and quickly understanding what a topology is doing. As our data
needs have grown, we have only increased our reliance on SQE and it stands
the
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77357693
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77356337
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77355840
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77355233
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
I too want to voice my support for SQE and our commitment to the initiative
going forward. We've been working on adapting Storm to our needs for most
of two years. It was thoughtfully designed and supports our production
needs. We have a long list of features we want to build out and we'd love
to
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77353254
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
It's really cool to see this discussion about Storm SQE - it's a project
we put a lot of love and sweat into!
You can put me on the list of people who are interested in contributing as
part of
the Storm community. I've been excited about working with Storm ever since
reading
Nathan Marz's book,
Being relatively new to Storm before I came to jwplayer, SQE has made it
extremely easy for me to pick up and hit the ground running. The code is
robust, and I look forward to contributing to the project to ensure its
continued success.
On Fri, Sep 2, 2016 at 9:49 AM, Lee Morris
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77350298
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,484 @@
+/**
+ * Licensed to the Apache Software Foundation
Hi, Storm Dev!
I wanted to chime in to show support for SQE and show how committed we are
to SQE. *StormSQL looks awesome and has some real potential! *
We use SQE in production. It has been tested, code reviewed, load tested,
maintained, and processing an average of 8 million tuples per minute
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1665
@HeartSaVioR OK, have a good time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1665
I'd like to wait for @priyank5485 and @abellina to finish reviewing. I'm
now reviewing and testing Supervisor V2 and it could take some times.
FYI: I'm on vacation on next week, and will be
Yeah that would be nice. Thanks for the suggestion Xin.
- Jungtaek Lim (HeartSaVioR)
2016년 9월 2일 (금) 오후 6:47, Xin Wang 님이 작성:
> how about move storm-sql-kafka to a new directory like storm-sql-external
> which contains various storm-sql data sources?
>
> 2016-09-02 10:31
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1642
I found another issue:
When I rebalance 3 workers into 1 worker, all workers are killed first
(expected) and AsyncLocalizer clear out topology codes since all workers are
killed.
But
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1642
With my patch (symlink issue and NPE issue) I can see workers launched and
killed by Supervisor V2. (remote)
Tested:
- kill worker process with -9
- rebalance with different
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1642
Found other issue:
Constructor of BasicContainer (in fact constructor of Container) throws FNF
when topology dist files are deleted. So even though Slot is creating with
recover mode,
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1642
I merged this in my local, and do some tests, and see:
1. integration test fails from my dev. machine
- I'm using OSX 10.11, Java 1.8.0_66
- I got wrong IP address from
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77321291
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1990,31 +1995,26 @@ protected void forceDeleteImpl(String path) throws
IOException
how about move storm-sql-kafka to a new directory like storm-sql-external
which contains various storm-sql data sources?
2016-09-02 10:31 GMT+08:00 Jungtaek Lim :
> Hi devs,
>
> I just created epic issue for Storm SQL phase 3 which tracks efforts for
> adding available data
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1665
@HeartSaVioR Can we merge this in? and, it's very easy to cherry-pick to
1.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1665#discussion_r77310159
--- Diff:
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java
---
@@ -89,6 +89,10 @@ public static void main
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1565
Thanks @HeartSaVioR I see. Will update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/STORM-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457702#comment-15457702
]
Manu Zhang commented on STORM-2077:
---
[~tobiasmaier], have you turned on acker ?
> KafkaSpout doesn't
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77299756
--- Diff:
storm-core/test/jvm/org/apache/storm/daemon/supervisor/BasicContainerTest.java
---
@@ -0,0 +1,459 @@
+package
72 matches
Mail list logo