[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-09-02 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 Oh, I missed it. Will update. Thanks @priyank5485 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [DISCUSS] storm-jms Code Donation

2016-09-02 Thread S G
I would love to see it part of storm/external and can volunteer to provide any help if required during the migration. -SG On Fri, Sep 2, 2016 at 12:59 PM, P. Taylor Goetz wrote: > I’d like to start a discussion around adding storm-jms as an external > module. I’ve gotten a

[GitHub] storm issue #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on the issue: https://github.com/apache/storm/pull/1642 I was able to review most of the code. I skimmed the tests and didn't see anything strange. @revans2 knows that I will not be able to log on again for awhile. I want to leave a note for

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77421416 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77421346 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77421324 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77421128 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainerLauncher.java --- @@ -0,0 +1,71 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77419710 --- Diff: storm-core/src/jvm/org/apache/storm/utils/ConfigUtils.java --- @@ -353,25 +350,21 @@ public LocalState nimbusTopoHistoryStateImpl(Map conf) throws

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77418874 --- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java --- @@ -0,0 +1,420 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77418692 --- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java --- @@ -0,0 +1,420 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77418682 --- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java --- @@ -0,0 +1,420 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77418598 --- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java --- @@ -0,0 +1,420 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77418561 --- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java --- @@ -0,0 +1,420 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77418422 --- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java --- @@ -0,0 +1,420 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm issue #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1642 @HeartSaVioR Yes it looks like I need to think through recovery and any races with the AsyncLocalizer a bit more. I'll try to reproduce your error. --- If your project is set up for it, you can

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77418240 --- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java --- @@ -0,0 +1,420 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77418129 --- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java --- @@ -0,0 +1,420 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77417627 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainerLauncher.java --- @@ -0,0 +1,71 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77417198 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77417265 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorUtils.java --- @@ -159,7 +162,7 @@ public static void addBlobReferences(Localizer

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77416935 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77416395 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77416200 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77415816 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77415710 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77415373 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,484 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77415016 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -1990,31 +1995,26 @@ protected void forceDeleteImpl(String path) throws IOException {

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77414257 --- Diff: storm-core/test/jvm/org/apache/storm/daemon/supervisor/BasicContainerTest.java --- @@ -0,0 +1,459 @@ +package

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77413129 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,766 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77411245 --- Diff: storm-core/src/jvm/org/apache/storm/utils/ConfigUtils.java --- @@ -353,25 +350,21 @@ public LocalState nimbusTopoHistoryStateImpl(Map conf) throws

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77407551 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,493 @@ +/** + * Licensed to the Apache Software

[DISCUSS] storm-jms Code Donation

2016-09-02 Thread P. Taylor Goetz
I’d like to start a discussion around adding storm-jms as an external module. I’ve gotten a few request to do so and the only thing that’s held me back is tracking down contributors and having them submit ICLAs. The code can be found here: https://github.com/ptgoetz/storm-jms

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77403662 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,766 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[VOTE] Release Apache Storm 0.10.2 (rc2)

2016-09-02 Thread P. Taylor Goetz
This is a call to vote on releasing Apache Storm 0.10.2 (rc2) Full list of changes in this release: https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHANGELOG.md;hb=d8e4a3b59e6a97165ff769f11c9d4d2d3ecbb9dc The tag/commit to be voted upon is v0.10.2:

[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-09-02 Thread priyank5485
Github user priyank5485 commented on the issue: https://github.com/apache/storm/pull/1665 @vesense Not sure if you saw my comment about exiting with a code of 1 in getOldConsumerOffsetsFromZk. Can you check that comment and address it? --- If your project is set up for it, you can

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-09-02 Thread Douglas Shore
We have benefited greatly from being downstream from SQE in powering our data driven solutions. I am excited to see this repo grow in breadth and depth. On Fri, Sep 2, 2016 at 11:16 AM, Kamil Sindi wrote: > Our data science efforts rely on SQE to power our recommendations

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-09-02 Thread P. Taylor Goetz
Thanks to all the JW Player folks who joined this thread, and welcome to the Storm community! It’s good to see that the code donation comes with a community ready and willing to help out. I’m +1 for accepting the code donation. -Taylor > On Sep 2, 2016, at 12:07 PM, Abhishek Agarwal

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-09-02 Thread Abhishek Agarwal
+1 for the merge. Apart from code contributions, helping users run and troubleshoot SQE is equally important and it seems that quite a number of folks are ready to help. On Fri, Sep 2, 2016 at 8:46 PM, Kamil Sindi wrote: > Our data science efforts rely on SQE to power our

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77369914 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,766 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77369714 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,766 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77367840 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,766 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77365678 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainerLauncher.java --- @@ -0,0 +1,71 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77364277 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainer.java --- @@ -0,0 +1,107 @@ +/** + * Licensed to the Apache Software

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-09-02 Thread Kamil Sindi
Our data science efforts rely on SQE to power our recommendations engine. I am also excited to contribute to it especially as we continue to implement predictive models at larger scales. On Fri, Sep 2, 2016 at 10:57 AM, Sahil Shah wrote: > I would like to throw my support

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-09-02 Thread Priyanka Singh
I would also like to voice my strong support for SQE. This SQL like query engine empowers our streaming infrastructure and makes it extremely easy to write production code. Being fairly new to storm, I could pick up and add SQE queries fairly quickly and enrich our real-time products and services.

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77361882 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainer.java --- @@ -0,0 +1,107 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77361623 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainer.java --- @@ -0,0 +1,107 @@ +/** + * Licensed to the Apache Software

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-09-02 Thread Sahil Shah
I would like to throw my support behind SQE. Having working with it in a production environment, I have seen the many benefits in testing new topologies and quickly understanding what a topology is doing. As our data needs have grown, we have only increased our reliance on SQE and it stands the

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77357693 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77356337 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77355840 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77355233 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-09-02 Thread Alex Halter
I too want to voice my support for SQE and our commitment to the initiative going forward. We've been working on adapting Storm to our needs for most of two years. It was thoughtfully designed and supports our production needs. We have a long list of features we want to build out and we'd love to

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77353254 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -0,0 +1,318 @@ +/** + * Licensed to the Apache Software

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-09-02 Thread Donato Borrello
It's really cool to see this discussion about Storm SQE - it's a project we put a lot of love and sweat into! You can put me on the list of people who are interested in contributing as part of the Storm community. I've been excited about working with Storm ever since reading Nathan Marz's book,

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-09-02 Thread Kelvin Shek
Being relatively new to Storm before I came to jwplayer, SQE has made it extremely easy for me to pick up and hit the ground running. The code is robust, and I look forward to contributing to the project to ensure its continued success. On Fri, Sep 2, 2016 at 9:49 AM, Lee Morris

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77350298 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,484 @@ +/** + * Licensed to the Apache Software Foundation

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-09-02 Thread Lee Morris
Hi, Storm Dev! I wanted to chime in to show support for SQE and show how committed we are to SQE. *StormSQL looks awesome and has some real potential! * We use SQE in production. It has been tested, code reviewed, load tested, maintained, and processing an average of 8 million tuples per minute

[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-09-02 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 @HeartSaVioR OK, have a good time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-09-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1665 I'd like to wait for @priyank5485 and @abellina to finish reviewing. I'm now reviewing and testing Supervisor V2 and it could take some times. FYI: I'm on vacation on next week, and will be

Re: Storm SQL Phase 3 created

2016-09-02 Thread Jungtaek Lim
Yeah that would be nice. Thanks for the suggestion Xin. - Jungtaek Lim (HeartSaVioR) 2016년 9월 2일 (금) 오후 6:47, Xin Wang 님이 작성: > how about move storm-sql-kafka to a new directory like storm-sql-external > which contains various storm-sql data sources? > > 2016-09-02 10:31

[GitHub] storm issue #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1642 I found another issue: When I rebalance 3 workers into 1 worker, all workers are killed first (expected) and AsyncLocalizer clear out topology codes since all workers are killed. But

[GitHub] storm issue #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1642 With my patch (symlink issue and NPE issue) I can see workers launched and killed by Supervisor V2. (remote) Tested: - kill worker process with -9 - rebalance with different

[GitHub] storm issue #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1642 Found other issue: Constructor of BasicContainer (in fact constructor of Container) throws FNF when topology dist files are deleted. So even though Slot is creating with recover mode,

[GitHub] storm issue #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1642 I merged this in my local, and do some tests, and see: 1. integration test fails from my dev. machine - I'm using OSX 10.11, Java 1.8.0_66 - I got wrong IP address from

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77321291 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -1990,31 +1995,26 @@ protected void forceDeleteImpl(String path) throws IOException

Re: Storm SQL Phase 3 created

2016-09-02 Thread Xin Wang
how about move storm-sql-kafka to a new directory like storm-sql-external which contains various storm-sql data sources? 2016-09-02 10:31 GMT+08:00 Jungtaek Lim : > Hi devs, > > I just created epic issue for Storm SQL phase 3 which tracks efforts for > adding available data

[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-09-02 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 @HeartSaVioR Can we merge this in? and, it's very easy to cherry-pick to 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] storm pull request #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-09-02 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1665#discussion_r77310159 --- Diff: external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java --- @@ -89,6 +89,10 @@ public static void main

[GitHub] storm issue #1565: STORM-1970: external project examples refator

2016-09-02 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 Thanks @HeartSaVioR I see. Will update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-2077) KafkaSpout doesn't retry failed tuples

2016-09-02 Thread Manu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457702#comment-15457702 ] Manu Zhang commented on STORM-2077: --- [~tobiasmaier], have you turned on acker ? > KafkaSpout doesn't

[GitHub] storm pull request #1642: STORM-2018: Supervisor V2.

2016-09-02 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r77299756 --- Diff: storm-core/test/jvm/org/apache/storm/daemon/supervisor/BasicContainerTest.java --- @@ -0,0 +1,459 @@ +package