[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1922#discussion_r99760968 --- Diff: storm-core/src/ui/public/flux.html --- @@ -0,0 +1,139 @@ + --- End diff -- If we can have icon then we can place it to the left

[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1922#discussion_r99760485 --- Diff: storm-core/src/ui/public/flux.html --- @@ -0,0 +1,139 @@ + --- End diff -- No it shouldn't be only for Ambari. I'll see where's

[GitHub] storm pull request #1925: STORM-2346: Files with unapproved licenses: downlo...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1925 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1926: STORM-2350: Storm-HDFS's listFilesByModificationTime is b...

Github user vesense commented on the issue: https://github.com/apache/storm/pull/1926 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI

Github user ambud commented on a diff in the pull request: https://github.com/apache/storm/pull/1922#discussion_r99747044 --- Diff: storm-core/src/ui/public/flux.html --- @@ -0,0 +1,139 @@ + --- End diff -- Sorry I misunderstood. @HeartSaVioR not sure what location

[GitHub] storm pull request #1926: STORM-2350: Storm-HDFS's listFilesByModificationTi...

GitHub user tibkiss opened a pull request: https://github.com/apache/storm/pull/1926 STORM-2350: Storm-HDFS's listFilesByModificationTime is broken You can merge this pull request into a Git repository by running: $ git pull https://github.com/tibkiss/storm STORM-2350

[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1922#discussion_r99745970 --- Diff: storm-core/src/ui/public/flux.html --- @@ -0,0 +1,139 @@ + --- End diff -- I think @vesense means that Storm UI index page

[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI

Github user ambud commented on a diff in the pull request: https://github.com/apache/storm/pull/1922#discussion_r99745686 --- Diff: storm-core/src/ui/public/flux.html --- @@ -0,0 +1,139 @@ + --- End diff -- Also, should we plan on back porting this to 0.10.x and

[GitHub] storm pull request #1914: STORM-2334 - Join Bolt implementation with unit te...

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1914#discussion_r99744103 --- Diff: docs/Joins.md --- @@ -0,0 +1,102 @@ +--- +title: Joining Streams in Storm Core +layout: documentation +documentation: true

[GitHub] storm pull request #1914: STORM-2334 - Join Bolt implementation with unit te...

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1914#discussion_r99744125 --- Diff: docs/Joins.md --- @@ -0,0 +1,102 @@ +--- +title: Joining Streams in Storm Core +layout: documentation +documentation: true

Re: [CANCELED] [VOTE] Release Apache Storm 1.0.3 (rc1)

FYI: I just handled backporting all listed, so just reverting release and rerunning release would be fine to go ahead RC2. 2017년 2월 7일 (화) 오전 3:36, P. Taylor Goetz 님이 작성: > Canceling this rc in order to include a number of additional patches. > > -Taylor > > > On Jan 31, 2017,

[GitHub] storm pull request #1917: STORM-2338: Subprocess exception handling is broke...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1917 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1693: [STORM-1961] Stream api for storm core use cases

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1693 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1693 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1914: STORM-2334 - Join Bolt implementation with unit te...

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/1914#discussion_r99724571 --- Diff: docs/Joins.md --- @@ -0,0 +1,102 @@ +--- +title: Joining Streams in Storm Core +layout: documentation +documentation: true

[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI

Github user ambud commented on a diff in the pull request: https://github.com/apache/storm/pull/1922#discussion_r99719977 --- Diff: storm-core/src/ui/public/flux.html --- @@ -0,0 +1,139 @@ + --- End diff -- @vesense I thought someone will ask for that :D

[GitHub] storm issue #1914: STORM-2334 - Join Bolt implementation with unit tests

Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/1914 @arunmahadevan yes.. good idea... i will add an example into storm-starter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request #1914: STORM-2334 - Join Bolt implementation with unit te...

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/1914#discussion_r99713201 --- Diff: docs/Joins.md --- @@ -0,0 +1,102 @@ +--- +title: Joining Streams in Storm Core +layout: documentation +documentation: true

[GitHub] storm pull request #1914: STORM-2334 - Join Bolt implementation with unit te...

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/1914#discussion_r99711705 --- Diff: docs/Joins.md --- @@ -0,0 +1,102 @@ +--- +title: Joining Streams in Storm Core +layout: documentation +documentation: true

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1693 @HeartSaVioR and @arunmahadevan sorry I have been busy with other things. I have not seen anything that I would consider to be blocking and since the API is marked as changing I am +1 to merge it

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1693 @arunmahadevan I'm just waiting for other committers' review, and IMO once @revans2 is OK to merge we can merge this. --- If your project is set up for it, you can reply to this email and have

[GitHub] storm issue #1919: STORM-2340: fix At-Most-Once issue in KafkaSpout

Github user XuMingmin commented on the issue: https://github.com/apache/storm/pull/1919 @revans2 updated. thanks for the notes! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[CANCELED] [VOTE] Release Apache Storm 1.0.3 (rc1)

Canceling this rc in order to include a number of additional patches. -Taylor > On Jan 31, 2017, at 3:55 PM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.0.3 (rc1) > > Full list of changes in this release: > >

[GitHub] storm pull request #1832: STORM-2250: Kafka Spout Refactoring to Increase Mo...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1832#discussion_r99652257 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -347,9 +345,15 @@ private void

[GitHub] storm pull request #1832: STORM-2250: Kafka Spout Refactoring to Increase Mo...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1832#discussion_r99650222 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -58,27 +56,26 @@ public class KafkaSpout

[GitHub] storm pull request #1832: STORM-2250: Kafka Spout Refactoring to Increase Mo...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1832#discussion_r99650180 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/SingleTopicKafkaSpoutTest.java --- @@ -28,21 +28,36 @@ import

[GitHub] storm pull request #1832: STORM-2250: Kafka Spout Refactoring to Increase Mo...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1832#discussion_r99649582 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -87,13 +84,14 @@ public

[GitHub] storm issue #1919: fix: KafkaSpout is blocked in AutoCommitMode

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1919 @XuMingmin does this PR make the initial [PR](https://github.com/apache/storm/pull/1863) obsolete? If so, can you please close that one? If not, I suggest that we have only one PR (compatible with

[GitHub] storm pull request #1832: STORM-2250: Kafka Spout Refactoring to Increase Mo...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1832#discussion_r99643526 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/SingleTopicKafkaSpoutTest.java --- @@ -28,21 +28,36 @@ import

[GitHub] storm pull request #1832: STORM-2250: Kafka Spout Refactoring to Increase Mo...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1832#discussion_r99643483 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/SingleTopicKafkaSpoutTest.java --- @@ -28,21 +28,36 @@ import

[GitHub] storm pull request #1832: STORM-2250: Kafka Spout Refactoring to Increase Mo...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1832#discussion_r99643242 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -347,9 +345,15 @@ private void

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99642608 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -240,7 +240,9 @@ private boolean commit() {

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99642616 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -289,6 +293,13 @@ private void

[GitHub] storm pull request #1832: STORM-2250: Kafka Spout Refactoring to Increase Mo...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1832#discussion_r99641734 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -87,13 +84,14 @@ public

[GitHub] storm pull request #1832: STORM-2250: Kafka Spout Refactoring to Increase Mo...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1832#discussion_r99641837 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -58,27 +56,26 @@ public class KafkaSpout

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99641026 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -289,6 +293,13 @@ private void

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99640360 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -240,7 +240,9 @@ private boolean commit() {

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99639454 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -329,11 +328,13 @@ private Builder(Builder

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99639068 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -78,7 +78,7 @@ private transient

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99638909 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java --- @@ -54,59 +56,92 @@

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99638933 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -78,7 +78,7 @@ private transient

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99638011 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java --- @@ -54,59 +56,92 @@

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99637679 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java --- @@ -27,13 +27,15 @@ import

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99635403 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -78,7 +78,7 @@ private transient

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99635118 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -329,11 +328,13 @@ private Builder(Builder

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99634538 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java --- @@ -54,59 +56,92 @@

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99634404 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java --- @@ -54,59 +56,92 @@

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1693 @revans2 @HeartSaVioR any further comments on the patch? I think it would be nice to get it merged soon and get feedback from potential users. The apis are marked unstable right now. Will

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r99624959 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java --- @@ -27,13 +27,15 @@ import

Re: [VOTE] Release Apache Storm 1.0.3 (rc1)

+1 I ran some sample tests. LGTM. -Kishor On Saturday, February 4, 2017 12:15 PM, Alexandre Vermeerbergen wrote: Hello again, I confirm +1 (non binding), with the following setup (modifed yesterday to use Kafka Brokers 0.10.1 instead of Kafka Brokers 0.9.2

[GitHub] storm pull request #1914: STORM-2334 - Join Bolt implementation with unit te...

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1914#discussion_r99572676 --- Diff: docs/Joins.md --- @@ -0,0 +1,102 @@ +--- +title: Joining Streams in Storm Core +layout: documentation +documentation: true