Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2363
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2363
OK. Thanks for quick addressing. +1 again.
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2386
Thanks @revans2 for pointing it out. I made stupid mistakes. I am still
fixing it. Please don't merge yet.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2379
@kevpeek yes the JVM can be very dumb when it comes to arrays vs Lists.
That sounds great if we can be within a few percentage points I would be
happy to merge this in.
---
Github user kevpeek commented on the issue:
https://github.com/apache/storm/pull/2379
heh. It crossed my mind to change those to arrays, but I figured the jvm
would render the difference negligible. A quick test proves that I was very
wrong. I'll tweak that tomorrow and run some more
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2365
@liu-zhaokun You are correct I had forgotten the ThriftClient establishes
the connection then initializes the _protocol member and then finally the
Client itself is created which will read from the
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2379
@kevpeek I agree that it might not be worth merging it right now. But
there is room for improvement.
The first thing I would do is to pre-allocate the possible return values as
lists. We
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2363
@HeartSaVioR I addressed your review comments. I didn't change the name of
shouldLogLeader, but I added javadocs to make it clear what it does.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2386
I am getting the UI crashing on startup, but with no stacktrace in the
logs. Could you look into it?
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147236780
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -664,6 +722,9 @@ private double calculateSharedOffHeapMemory(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147237164
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/TopologyDetails.java ---
@@ -168,6 +172,15 @@ private void initResourceList() {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147234270
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -240,6 +240,12 @@
public static final String TOPOLOGY_TASKS = "topology.tasks";
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147234853
--- Diff: storm-client/src/jvm/org/apache/storm/Constants.java ---
@@ -56,5 +58,20 @@
public static final String STORM_ACTIVE_ATOM =
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147235417
--- Diff:
storm-client/src/jvm/org/apache/storm/scheduler/SupervisorDetails.java ---
@@ -17,12 +17,10 @@
*/
package org.apache.storm.scheduler;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147233694
--- Diff:
examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/CaptureLoad.java
---
@@ -430,37 +427,37 @@ public static void main(String[] args)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147235680
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/BaseConfigurationDeclarer.java
---
@@ -79,8 +81,18 @@ public T setMemoryLoad(Number onHeap, Number
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147237442
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
---
@@ -189,13 +201,20 @@ private static void
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147236218
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -503,62 +553,70 @@ public boolean wouldFit(
WorkerSlot ws,
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147236953
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -993,6 +1054,31 @@ public WorkerResources getWorkerResources(WorkerSlot
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147237298
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
---
@@ -18,22 +18,24 @@
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147235287
--- Diff:
storm-client/src/jvm/org/apache/storm/generated/WorkerResources.java ---
@@ -1,21 +1,4 @@
/**
- * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147236417
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -503,62 +553,70 @@ public boolean wouldFit(
WorkerSlot ws,
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147234354
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -1272,6 +1278,12 @@
public static final String SUPERVISOR_CPU_CAPACITY =
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147236577
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -503,62 +553,70 @@ public boolean wouldFit(
WorkerSlot ws,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2363#discussion_r147159038
--- Diff: storm-client/src/jvm/org/apache/storm/utils/NimbusClient.java ---
@@ -86,7 +86,22 @@ public static NimbusClient
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2363#discussion_r145321214
--- Diff: storm-client/src/jvm/org/apache/storm/utils/NimbusClient.java ---
@@ -86,7 +86,18 @@ public static NimbusClient
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2363#discussion_r145322043
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/SupervisorUtils.java
---
@@ -69,11 +69,22 @@ public static void
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@revans2
I try to fix this bug follow your advice,but I found the original bug
occurred in line 41
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2388
See https://issues.apache.org/jira/browse/STORM-2607
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2380
+1, good work.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147053713
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void
31 matches
Mail list logo
