Re: Ask for review on Storm 2.0.0 items

2017-12-30 Thread Satish Duggana
Hi Alexendre, Event time windowing is already supported in Storm, you can go through http://storm.apache.org/releases/2.0.0-SNAPSHOT/Windowing.html here. Thanks, Satish. On Sat, Dec 30, 2017 at 3:24 PM, Alexandre Vermeerbergen < avermeerber...@gmail.com> wrote: > Hello, > > Unless I am mistaking

Re: Ask for review on Storm 2.0.0 items

2017-12-30 Thread Stig Rohde Døssing
The unit tests pass on Java 9 except for those modules. I haven't tried running the integration test or booting a distributed mode cluster on 9. We also haven't done any work to use the module system yet (though this is of course not a requirement for being compatible with Java 9). Trying out one

Re: Ask for review on Storm 2.0.0 items

2017-12-30 Thread Alexandre Vermeerbergen
Hi Stig, Thank for the reference. Does it means that if one doesn't need Hive not Cassandra support, then Storm 2 current snapshot should already be Java 9-compatible? Best regards, Alexandre Vermeerbergen 2017-12-30 11:28 GMT+01:00 Stig Rohde Døssing : > Alexandre, > > Java 9 support should be

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r159120269 --- Diff: external/storm-solr/README.md --- @@ -97,6 +97,29 @@ field separates each value with the token % instead of the default | . To use th

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r159121022 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/schema/builder/RestJsonSchemaBuilderV2.java --- @@ -0,0 +1,127 @@ +/** + * Licensed t

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r159120398 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -153,4 +160,15 @@ private void failQueuedTuples(List failedT

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r159120315 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -88,9 +92,11 @@ private int capacity() { @Override

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r159120430 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/schema/SolrFieldTypeFinder.java --- @@ -70,13 +73,22 @@ public String toString() { /

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r159120311 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -88,9 +92,11 @@ private int capacity() { @Override

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r159120406 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/config/SolrConfig.java --- @@ -54,4 +65,7 @@ public int getTickTupleInterval() {

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r159120320 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -128,6 +134,7 @@ private void fail(Tuple tuple, Exception e)

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r159120287 --- Diff: external/storm-solr/README.md --- @@ -171,7 +194,7 @@ Querying Solr for these patterns, you will see the values that have been indexe curl

[GitHub] storm issue #2488: STORM-2874: Minor refactoring of some backpressure code

2017-12-30 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2488 A couple of the changes were applicable, closing this. ---

[GitHub] storm pull request #2488: STORM-2874: Minor refactoring of some backpressure...

2017-12-30 Thread srdo
Github user srdo closed the pull request at: https://github.com/apache/storm/pull/2488 ---

[GitHub] storm pull request #2489: STORM-2874 1.x: Minor refactoring of backpressure ...

2017-12-30 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2489 STORM-2874 1.x: Minor refactoring of backpressure test code See https://issues.apache.org/jira/browse/STORM-2874. A couple of the changes weren't applicable to 1.x. You can merge this pull req

Re: Ask for review on Storm 2.0.0 items

2017-12-30 Thread Stig Rohde Døssing
Alexandre, Java 9 support should be tracked here https://issues.apache.org/jira/browse/STORM-2798. Once the Hive and Cassandra projects support Java 9, I hope we can add Java 9 as one of the build targets for Travis, like we currently have 7 and 8 as targets for 1.x 2017-12-30 10:54 GMT+01:00 Ale

Re: [NOTICE] Sorted out versions in Apache JIRA

2017-12-30 Thread Stig Rohde Døssing
Thanks. 2017-12-28 6:27 GMT+01:00 Jungtaek Lim : > Hi devs, > > Just FYI, I have sorted out versions in Apache JIRA - marked all versions > which are already released as released with actual release date. > I also remove fix version in some issues which are open but version is > already released.

[GitHub] storm issue #2488: STORM-2874: Minor refactoring of some backpressure code

2017-12-30 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2488 Makes sense, I'll check if this applies to 1.x ---

[GitHub] storm pull request #2480: STORM-2867: Add consumer lag metrics to KafkaSpout

2017-12-30 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2480#discussion_r159120385 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java --- @@ -0,0 +1,118 @@ +/** + * Licensed

Re: Ask for review on Storm 2.0.0 items

2017-12-30 Thread Alexandre Vermeerbergen
Hello, Unless I am mistaking, one of the Storm 2's targets includes a convergence with JStorm. JStorm seems to have neat window-processing features and it is part of Apache Beam ecosystem, see: https://beam.apache.org/documentation/runners/capability-matrix/ Will Storm 2.0.0 include JStorm window

[GitHub] storm pull request #2480: STORM-2867: Add consumer lag metrics to KafkaSpout

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2480#discussion_r159119938 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java --- @@ -0,0 +1,118 @@ +/** + * Licensed

[GitHub] storm pull request #2480: STORM-2867: Add consumer lag metrics to KafkaSpout

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2480#discussion_r159119896 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java --- @@ -0,0 +1,118 @@ +/** + * Licensed

[GitHub] storm pull request #2480: STORM-2867: Add consumer lag metrics to KafkaSpout

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2480#discussion_r159119878 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java --- @@ -0,0 +1,118 @@ +/** + * Licensed

[GitHub] storm pull request #2480: STORM-2867: Add consumer lag metrics to KafkaSpout

2017-12-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2480#discussion_r159119706 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -739,4 +764,9 @@ public boolean shouldPoll() {