[GitHub] storm issue #2441: [STORM-2838] Replace log4j-over-slf4j with log4j-1.2-api

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2441 @srdo Thanks for the review. We decided to set the configs to only point to the existing hadoop config files (no jars from existing hadoop) to avoid this issue for now. Closing this until any

[GitHub] storm pull request #2441: [STORM-2838] Replace log4j-over-slf4j with log4j-1...

Github user Ethanlm closed the pull request at: https://github.com/apache/storm/pull/2441 ---

[GitHub] storm issue #2449: [STORM-2846] Add extra classpath for nimbus and superviso...

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2449 @HeartSaVioR Thanks for the review. We decided to set the configs to only point to the existing hadoop config files (no jars from existing hadoop) to avoid this issue for now. Closing this

[GitHub] storm pull request #2449: [STORM-2846] Add extra classpath for nimbus and su...

Github user Ethanlm closed the pull request at: https://github.com/apache/storm/pull/2449 ---

[GitHub] storm issue #2589: [STORM-2989] LogCleaner should preserve current worker.lo...

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2589 The test failures should be unrelated. ---

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173232562 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4215,7 +4474,48 @@ public boolean isTopologyNameAllowed(String name)

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173232056 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -234,6 +295,60 @@ public void launchDaemon() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173219240 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -319,14 +344,17 @@ private static StormBase make(TopologyStatus

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173220578 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -293,14 +268,15 @@ public synchronized void run() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173216785 --- Diff: storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java --- @@ -295,7 +295,11 @@ private Scope calculateScope(Map

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173218011 --- Diff: storm-client/src/jvm/org/apache/storm/utils/SupervisorClient.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173213537 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -233,23 +249,11 @@ * @return the id of the topology or null

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173217779 --- Diff: storm-client/src/jvm/org/apache/storm/utils/SupervisorClient.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173213078 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -94,6 +108,8 @@ @Deprecated List

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173207181 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/InMemoryAssignmentBackend.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173214066 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java --- @@ -745,6 +828,7 @@ public void disconnect() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173210647 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/InMemoryAssignmentBackend.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173213324 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -233,23 +249,11 @@ * @return the id of the topology or null

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173215759 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -392,6 +401,30 @@ public void establishLogSettingCallback() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173215187 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -392,6 +401,30 @@ public void establishLogSettingCallback() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173212518 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -44,6 +44,16 @@ Assignment assignmentInfo(String

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173217461 --- Diff: storm-client/src/jvm/org/apache/storm/utils/SupervisorClient.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173215685 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -392,6 +401,30 @@ public void establishLogSettingCallback() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173211013 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173202043 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173201619 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2433 @revans2 Really thx for your contributions and refactoring work, i will follow in timely if i have time. ---

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173179815 --- Diff: conf/defaults.yaml --- @@ -182,7 +195,7 @@ worker.log.level.reset.poll.secs: 30 # control how many worker receiver threads we need per

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2433 I decided against refactoring here. The changes I want to make go a lot deeper than just this patch. and this patch is following the conventions in the code already. I'll spend some time

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173177188 --- Diff: conf/defaults.yaml --- @@ -182,7 +195,7 @@ worker.log.level.reset.poll.secs: 30 # control how many worker receiver threads we need per worker