Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1977
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1974
STORM-2038: Disable symlinks with a config option
This is built on top of #1972 but I have not ported it to other branches
yet, so I would like to keep the two separate. Once reviews are done
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1973
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1972
STORM-2038: No symlinks for local cluster
This is a clean cherry-pick back to 1.x and 1.0.x too.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1934
@jerrypeng Fixed the issue. We were only checking if the SybSystem was
enabled, but not if it was mounted.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1934
@jerrypeng Actually just found a bug working on a fix now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1959
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1958
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1959
@hmcl This code has not been released yet, or if it was we need to fix this
bug in it. This particular Func class was created specifically to make it
simple to override specific places in the Kafka
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1959
OK Now I understand what is happening. I think what we really want is to
mark Func as Serializable. Could you try the following patch instead?
```
diff --git
a/external/storm-kafka
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1958#discussion_r102534351
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/test/KafkaSpoutTopologyMainNamedTopics.java
---
@@ -96,13 +98,6
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1959
I am OK with the change but if this is really causing issues then we need
to update the docs too.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1959#discussion_r102533777
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/test/KafkaSpoutTopologyMainNamedTopics.java
---
@@ -94,10 +98,10
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1934
@jerrypeng I added in the extra documentation you wanted, and I spell
checked the whole thing.
I also updated the CGroupCpuGuarantee metric to let the parent handle the
exception
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r102484623
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupMemoryUsage.java ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r102484597
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupMemoryLimit.java ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r102484535
--- Diff: storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupCpu.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1934
@jerrypeng Please take another look. I refactored the code to reuse the
CgroupManager and such.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r101369654
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupMemoryLimit.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r101368038
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupMemoryLimit.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r101365418
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupMemoryLimit.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1832
@srdo for Time and Timer for a pure correctness perspective the changes
look good to me. I don't see any issues.
I took a quick look at the rest of the patch and it too looks good, but I
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1919#discussion_r100547347
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -314,15 +316,26 @@ private boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1919#discussion_r100546788
--- Diff: docs/storm-kafka-client.md ---
@@ -345,3 +345,27 @@ Currently the Kafka spout has has the following
default values, which have shown
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1919#discussion_r100547080
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -314,15 +316,26 @@ private boolean
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1934
STORM-2333: CGroup memory and CPU metrics
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2333
Alternatively you
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1932
+1 although I really would like to see someone else review this too.
Also the test failure is unrelated.
---
If your project is set up for it, you can reply to this email and have your
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1832
@srdo Sorry I am kind of coming into this half way through.
History: System.nanoTime and System.currentTimeMillis have different uses
and are not on the same time line. nanoTime
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1919#discussion_r99891846
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -107,7 +107,8 @@ public void open(Map conf
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1919
This is the thing with auto-commit. auto-commit removes some of the
overhead of tracking outstanding messages, but also violates a lot of the
guarantees that storm has in place.
To truly
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1919#discussion_r99888764
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -319,8 +320,10 @@ private boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1919#discussion_r99868716
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -319,8 +320,10 @@ private boolean
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1693
@HeartSaVioR and @arunmahadevan sorry I have been busy with other things.
I have not seen anything that I would consider to be blocking and since the API
is marked as changing I am +1 to merge
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1909
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1910
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1911
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1868
@HeartSaVioR I removed the unneeded annotation and rebuilt with JDK7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1868
It was two jdk8 annotations that I didn't remove as part of
rework/upmerging. I'll get them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1868
This branch is also in sync with #1808 now tabs are removed and code is
squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1808
@hmcl github like to truncate long messages.
```
$ git log STORM-2225
commit c9f9348e3de0917020a8c903f4c9d026b7dc6204
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1808
Everyone,
Sorry this took so long. I kept getting pulled off on critical issues. I
have rebased/squashed everything (except the code revert) and also fixed the
issue with tabs vs spaces
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1868
@harshach I am happy to once I get a +1 on #1808 too. It has almost
identical code, but is for master.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97565415
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/TypedTupleExample.java
---
@@ -0,0 +1,64 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97418597
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/BranchExample.java
---
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97423628
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/StatefulWordCount.java
---
@@ -0,0 +1,87 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97424063
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/TypedTupleExample.java
---
@@ -0,0 +1,64 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97422636
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/JoinExample.java
---
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97427695
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/StateQueryExample.java
---
@@ -0,0 +1,110 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97423227
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/StateQueryExample.java
---
@@ -0,0 +1,110 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97423023
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/StateQueryExample.java
---
@@ -0,0 +1,110 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97424682
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/WordCountToBolt.java
---
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97420280
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/GroupByKeyAndWindowExample.java
---
@@ -0,0 +1,109 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97419171
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/GroupByKeyAndWindowExample.java
---
@@ -0,0 +1,109 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97424356
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/TypedTupleExample.java
---
@@ -0,0 +1,64 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97420102
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/GroupByKeyAndWindowExample.java
---
@@ -0,0 +1,109 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r9741
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/GroupByKeyAndWindowExample.java
---
@@ -0,0 +1,109 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1693#discussion_r97424491
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/streams/WindowedWordCount.java
---
@@ -0,0 +1,80 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r97334512
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -447,7 +440,10 @@ private void shutdown
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r97333183
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/FieldNameTopicSelector.java
---
@@ -0,0 +1,49
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r97331194
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicPartitionComparator.java
---
@@ -1,16 +1,35
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r97332427
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/bolt/KafkaBolt.java ---
@@ -51,7 +51,9 @@
* This bolt uses 0.8.2 Kafka Producer API
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1693
@arunmahadevan I will try to find time to take a look at it soon. Sorry
for the delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96951710
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1808
The travis test failures are unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1808
@hmcl I think I addressed all of your review comments. I also re-based to
deal with the merge conflict. If everything looks good I will squash some of
the commits. There are a lot.
---
If your
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96925318
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/mapper/FieldNameBasedTupleToKafkaMapper.java
---
@@ -0,0 +1,41
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96925159
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/KafkaTopicSelector.java
---
@@ -0,0 +1,26
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96925279
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/mapper/FieldNameBasedTupleToKafkaMapper.java
---
@@ -0,0 +1,41
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96924990
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96923940
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96923481
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutManager.java
---
@@ -44,29 +43,30
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96911529
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/RoundRobinManualPartitioner.java
---
@@ -15,14 +15,26 @@
* See
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96909498
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaTuple.java
---
@@ -15,22 +15,33 @@
* See the License
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96908491
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedSubscription.java
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96908178
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicPartitionComparator.java
---
@@ -1,16 +1,35
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96907232
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -325,15 +310,19 @@ private boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96897291
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -325,15 +310,19 @@ private boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96894587
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/ByTopicRecordTranslator.java
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96893867
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/ByTopicRecordTranslator.java
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96891568
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/FieldIndexTopicSelector.java
---
@@ -0,0 +1,52
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96891946
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/FieldNameTopicSelector.java
---
@@ -0,0 +1,49
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96889563
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/bolt/KafkaBolt.java ---
@@ -51,7 +51,9 @@
* This bolt uses 0.8.2 Kafka Producer API
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96889298
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/Subscription.java
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96887342
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -61,129 +66,244 @@
* If no offset
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96886556
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -61,129 +66,244 @@
* If no offset
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96884451
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,11 +213,7 @@ public void nextTuple
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96879498
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96879307
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96879248
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96877333
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96877744
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96875424
--- Diff: docs/storm-kafka-client.md ---
@@ -1,90 +1,232 @@
-#Storm Kafka Spout with New Kafka Consumer API
+#Storm Apache Kafka integration using
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1808
The test failures are unrelated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1808
@srdo @harshach sorry to do this to you, but I just fixed the conflicts
with STORM-2236. Sadly the fastest way I could do it was to revert the
original code and implement similar functionality
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1868
@harshach and @ppoulosk I just pushed fixes for your review comments.
@harshach you were right I could and did remove StormStringDeserializer. I
think this made the code much better.
---
If your
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1878
+1 the change looks good to me. Great catch @pasalkarsachin1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1868#discussion_r96432779
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/StormStringDeserializer.java
---
@@ -15,22 +15,11 @@
* See
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1808
The test failures are unrelated and are around the integration tests that
always seem to fail lately.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1868
The test failures are unrelated and are around the integration tests that
always seem to fail lately.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1862
@HeartSaVioR I rebased and I think I addressed your review comments.
Please have a look and see if it is what you wanted.
---
If your project is set up for it, you can reply to this email and have
1101 - 1200 of 3470 matches
Mail list logo
