Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57167482
--- Diff:
storm-core/src/jvm/org/apache/storm/transactional/TransactionalSpoutCoordinator.java
---
@@ -71,7 +72,7 @@ public ITransactionalSpout getSpout
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57167305
--- Diff: storm-core/src/jvm/org/apache/storm/grouping/ShuffleGrouping.java
---
@@ -35,7 +36,7 @@
@Override
public void prepare
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57167152
--- Diff:
storm-core/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -36,7 +37,7 @@
@Override
public void
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57167003
--- Diff:
storm-core/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -36,7 +37,7 @@
@Override
public void
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57166843
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -698,7 +699,7 @@
executor-stats (:stats executor-data
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57166147
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -508,7 +509,7 @@
^Integer max-spout-pending (if max-spout-pending (int
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1250#issuecomment-200363377
How does the performance compare to
http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadLocalRandom.html
which is also not thread safe
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1121#issuecomment-24821
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1239#issuecomment-22535
I don't think that it is actually a fat jar, but I have not run the code so
I don't really know for sure.
Everything in the JAR comes from
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1202#issuecomment-199984513
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1216#issuecomment-199978373
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1221#issuecomment-199970293
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1222#issuecomment-199970338
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1226#issuecomment-199959156
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1239#issuecomment-199958977
How does the storm sql worker processes get access to the sql jars? Do the
workers need access to the jars? With a name like runtime I would expect that
it would need
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1240#issuecomment-199957592
+1 looks OK to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56534191
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaRecordTupleBuilder.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56387329
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,517 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56396492
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1107#issuecomment-197358536
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1236
STORM-1617: Versioned Docs 0.10.x
This is intended to be merged and used with
https://svn.apache.org/repos/asf/storm/branches/bobby-versioned-site
You can merge this pull request into a Git
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1235
STORM-1617: Versioned Docs 1.x
This is intended to be merged and used with
https://svn.apache.org/repos/asf/storm/branches/bobby-versioned-site
You can merge this pull request into a Git
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1234
STORM-1617: Versioned Docs
This is intended to be merged and used with
https://svn.apache.org/repos/asf/storm/branches/bobby-versioned-site
You can merge this pull request into a Git repository
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/753#issuecomment-197349450
I agree with @unsleepy22 +1 except for some unneeded indentation changes
(but I can look past them).
The big issue now is that we need a patch for both 1.0
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56399116
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56414932
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56403733
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56521036
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaRecordTupleBuilder.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56517067
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56507684
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56546945
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1174#issuecomment-197358212
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56377111
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1227#issuecomment-197885702
I assume they all pass on windows so +1
The test failure looks like it is a bug with the mongodb pom.xml that JDK8
does not like but JDK7 seems OK with. Very
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56402570
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56701828
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56548912
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56239392
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,517 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56239098
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,517 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56239019
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,517 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56238105
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,517 @@
+/*
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56237896
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -0,0 +1,517 @@
+/*
+ * Licensed
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1108#issuecomment-197010319
For the most part is looks really good, just a few comments about the test,
and a few minor comments about a cast that we are doing.
---
If your project is set up
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1108#discussion_r56236015
--- Diff: storm-core/test/clj/org/apache/storm/scheduler_test.clj ---
@@ -262,20 +262,15 @@
(deftest test-sort-slots
;; test supervisor2 has
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1108#discussion_r56235924
--- Diff: storm-core/test/clj/org/apache/storm/scheduler_test.clj ---
@@ -262,20 +262,15 @@
(deftest test-sort-slots
;; test supervisor2 has
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1108#discussion_r56234415
--- Diff: storm-core/src/jvm/org/apache/storm/scheduler/EvenScheduler.java
---
@@ -0,0 +1,168 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56232096
--- Diff: external/storm-kafka-client/pom.xml ---
@@ -0,0 +1,86 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56228825
--- Diff: external/storm-kafka-client/pom.xml ---
@@ -0,0 +1,86 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r56225575
--- Diff: storm-core/src/jvm/org/apache/storm/trident/planner/Node.java ---
@@ -25,7 +26,7 @@
import org.apache.commons.lang.builder.ToStringStyle
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r56225424
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/operation/DefaultResourceDeclarer.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r56223967
--- Diff: storm-core/src/jvm/org/apache/storm/trident/TridentState.java ---
@@ -23,18 +23,33 @@
public class TridentState {
TridentTopology
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r56223827
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -124,6 +124,31 @@ public Stream parallelismHint(int hint
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1199#issuecomment-196979666
I am not really sure that we are going to need a Builder interface for
setting resources, and for me consistency between the trident and regular storm
APIs is more
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1108#discussion_r5621
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/DefaultScheduler.java ---
@@ -0,0 +1,111 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1147#issuecomment-196943739
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1203#issuecomment-196529163
Sounds good I will go ahead with doing all of this in subversion, and put
up pull requests in git for release specific docs that we would copy to
subversion when we do
Github user revans2 closed the pull request at:
https://github.com/apache/storm/pull/1203
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1147#issuecomment-196482345
@unsleepy22 sorry I had a minor personal emergency come up last Friday. It
is fixed now, but I am still trying to catch up on everything that happened
Friday and over
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1190#issuecomment-196450856
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1203
!!! DO NOT MERGE !!! STORM-1617 preview !!! DO NOT MERGE !!!
This is intended to be a preview of STORM-1617. It is by no means done,
but I wanted to get some feedback on this.
Adding
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55712301
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncProcessEvent.java ---
@@ -0,0 +1,669 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55697815
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorUtils.java ---
@@ -0,0 +1,273 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r55694717
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutStreams.java
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-194880255
@kishorvpatil I think you are confusing our internal code with open source
code. We have been using an early patch of kafka with security, that supported
security
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1196#issuecomment-194870129
+1 looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55601506
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorUtils.java ---
@@ -0,0 +1,273 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55601229
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorUtils.java ---
@@ -0,0 +1,273 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55599650
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorUtils.java ---
@@ -0,0 +1,273 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1178#issuecomment-194507988
oops I missed that org.apache.storm.security.auth.auth-test / testname:
digest-authentication-test is failing thinking that it want plane.
---
If your project is set
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1178#issuecomment-194507679
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55585701
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55585748
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55585655
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55585426
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55585379
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55585316
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55585266
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584846
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584866
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584755
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584817
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584718
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584667
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584589
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584436
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584469
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584354
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584398
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55584050
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorData.java ---
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55583857
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55583753
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55583696
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55583591
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55573977
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/timer/SupervisorHeartbeat.java
---
@@ -0,0 +1,89 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55573829
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/timer/SupervisorHeartbeat.java
---
@@ -0,0 +1,89 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55571026
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/State.java
---
@@ -0,0 +1,22 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55568307
--- Diff: storm-core/src/clj/org/apache/storm/daemon/local_supervisor.clj
---
@@ -0,0 +1,61 @@
+;; Licensed to the Apache Software Foundation (ASF) under
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-194443713
The code looks really good an I am +1 for merging it in as is. There are
still a few nits though. one with CommonInstaller and another that
@arunmahadevan pointed out
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55565851
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1156#issuecomment-194358768
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
1701 - 1800 of 3470 matches
Mail list logo
