[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

2017-01-06 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1767 @sathyafmt sorry I have taken so long to respond December was a really crazy month for me. From STORM-2194 I see that the SocketTimeoutException goes through the code being changed. The RMI code

[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

2016-12-02 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1767 We should be able to fix this with code like. ``` (if (or (exception-cause? InterruptedException error) (and (exception-cause?

[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

2016-12-02 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1767 @chawco Okay so I understand the issue better now. SocketTimeoutException is a subclass of InterruptedIOException.

[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

2016-12-01 Thread chawco
Github user chawco commented on the issue: https://github.com/apache/storm/pull/1767 So, there's some ambiguity in place here that would need to get resolved. Basically, there's two sources for InterruptedException/InterruptedIOException -- one from Storm itself, and one from the

[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

2016-12-01 Thread sathyafmt
Github user sathyafmt commented on the issue: https://github.com/apache/storm/pull/1767 @revans2 - His change in storm-1.0.2 is in the report-error-and-die function, so it should shutdown, correct ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

2016-11-21 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1767 -1. InterruptedException we often use to indicate that the process is shutting down, and we want to not blow up when we see them. Perhaps what we want to do is to better document it. ---