Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1074
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52516379
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -98,10 +104,26 @@ public static long currentTimeMillis() {
return System
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/1074#issuecomment-182550643
OK looks good I am +1 again. I would like other +1s since I contributed
some of this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52514265
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Runtim
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52511158
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Runtim
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52506255
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static R
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52503476
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52504042
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52503690
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52502528
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52503293
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Ru
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52503180
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static R
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/1074#issuecomment-182514941
OK, looked again and noticed some things that might be good to address now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52499915
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Runtim
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52499679
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1354,6 +1427,7 @@ public static TopologyInfo getTopologyInfo(String
name, String asUser, Ma
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52499408
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -884,26 +955,8 @@ private static void unTarUsingJava(File inFile, File
untarDir,
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52499008
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -86,8 +119,27 @@
import java.util.zip.GZIPOutputStream;
import java.util.zip.ZipEnt
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52498942
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -73,11 +102,15 @@
import java.util.HashMap;
import java.util.HashSet;
import j
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52498731
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Runtim
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52498283
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Runtim
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52498090
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Runtim
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52497959
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Runtim
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52497759
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Runtim
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52497495
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,820 @@ public static int toPositive(int number) {
public static Runtim
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1074#issuecomment-182495649
One minor nit with the logging and then I am +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52492415
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -98,10 +104,26 @@ public static long currentTimeMillis() {
return System.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52492166
--- Diff:
storm-core/src/jvm/org/apache/storm/logging/ThriftAccessLogger.java ---
@@ -24,4 +26,10 @@
public void log(String logMessage) {
LOG.
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52417994
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,821 @@ public static int toPositive(int number) {
public
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52370558
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,821 @@ public static int toPositive(int number) {
public static R
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52364169
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,821 @@ public static int toPositive(int number) {
public
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52363530
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,821 @@ public static int toPositive(int number) {
public
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52363496
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,821 @@ public static int toPositive(int number) {
public
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52363260
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1444,821 @@ public static int toPositive(int number) {
public
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52361320
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -262,13 +266,17 @@
:task->component (:task->component worker)
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1074#issuecomment-182005188
@abhishekagarwal87 @revans2
I believe I've addressed all of the concerns.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52354678
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52352080
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static R
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52345901
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static R
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52236125
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static R
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52235385
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52234801
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52234553
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52233784
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static R
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52233483
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52233202
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52232812
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52232176
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52232017
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52231711
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52231609
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52231544
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52231575
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52229215
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52229159
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52228101
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52228058
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52227215
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52227014
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52226803
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static R
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52226190
--- Diff: storm-core/src/clj/org/apache/storm/command/dev_zookeeper.clj ---
@@ -14,6 +14,7 @@
;; See the License for the specific language governing perm
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52226076
--- Diff: storm-core/pom.xml ---
@@ -42,6 +42,10 @@
This is here as a work around to place it at the beginning of
the classpath
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52225923
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52225007
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52225730
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52224848
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -580,20 +655,23 @@ public static void restrictPermissions(String
baseDir) {
}
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52224728
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52224267
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r5323
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r5254
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r5124
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52221821
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52221752
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52220933
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52220675
--- Diff: storm-core/src/clj/org/apache/storm/command/dev_zookeeper.clj ---
@@ -14,6 +14,7 @@
;; See the License for the specific language governing perm
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52220553
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52219103
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52219772
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52219674
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52219613
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52218721
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52218449
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52218371
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52218283
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52218195
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52217989
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52217691
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52217526
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52217262
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52217269
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52216875
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52216501
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -580,20 +655,23 @@ public static void restrictPermissions(String
baseDir) {
}
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52216072
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -106,8 +158,23 @@
public static Object newInstance(String klass) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52216050
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -106,8 +158,23 @@
public static Object newInstance(String klass) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215990
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -106,8 +158,23 @@
public static Object newInstance(String klass) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215816
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -106,8 +158,23 @@
public static Object newInstance(String klass) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215606
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -98,10 +104,25 @@ public static long currentTimeMillis() {
return System.
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215700
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215246
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -98,10 +104,25 @@ public static long currentTimeMillis() {
return System.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215149
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -98,10 +104,25 @@ public static long currentTimeMillis() {
return System.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215061
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -98,10 +104,25 @@ public static long currentTimeMillis() {
return System.
1 - 100 of 115 matches
Mail list logo
