Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-156884789
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-63134028
+1 (again)
@harshach The problem you saw was due to two of the `storm.rb` files being
out of sync. I will correct that at merge time.
---
If your project is set
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-63094779
@HeartSaVioR I am working on doing some tests on this PR. I tried to build
the storm with your changes in and I am getting these failures. Can you please
check if you se
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-62298800
AFAIK, there was a discussion about moving documents (containing website)
to git, started by @ptgoetz, and +1 by many committers.
But it's actually not applied, so
Github user itaifrenkel commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-62296939
@HeartSaVioR I wanted to fix the multilang docs some time ago for nodejs
support, but couldn't find a way to provide a pull request ?
---
If your project is set up fo
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-62296198
We should document this feature to
http://storm.apache.org/documentation/Multilang-protocol.html
In bolts, bolt should handle heartbeat tuple, and send sync respons
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-62295920
Maybe we can have a discussion about multilang from mailing list or other
issue.
There seems to leak documentation / strategy / etc. about multilang. How do
you al
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-62295398
@itaifrenkel OK, I've commented to STORM-528.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-62295379
@itaifrenkel @clockfly
I agree @itaifrenkel because there're more implementations (but it doesn't
exist on Storm project) on multilang.
I saw php implementatio
Github user itaifrenkel commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-62295232
@HeartSaVioR @clockfly I think we need to keep the multilang protocl
implementation as simple as possible. A full roundtrip of heartbeat messages is
not that bad, as
Github user itaifrenkel commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-62295127
Please comment on STORM-528 if you resolved the py files divergence problem.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-62294914
@harshach @ptgoez @clockfly
Could we merge upmerged PR now, or PR should take care of additional
modification before merge?
---
If your project is set up for it,
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-61720636
OK, I've upmerged.
Btw, I found py files are diverged too so I need to copy and paste one file
to another.
---
If your project is set up for it, you can reply to
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-61719213
I've got a change to discuss about this PR with @clockfly , and he also
stated if subprocess is too busy, subprocess cannot send heartbeat in time,
which I've stated f
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-61715752
@harshach Sure. I'll upmerge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-61669206
@HeartSaVioR Thanks for the patch. can you upmerge the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-61657845
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-60854884
Can PR be included to 0.9.3, or next version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-60438969
Since there were additional commits added to the pull request, we need to
give it more time for others to review before merging, but I am still +1 for
the patch.
---
If
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-60438795
@itaifrenkel No, not that's available for use via the bolt API, but it's an
interesting idea. You could effectively do the same by making the scheduler
static (1 per worke
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r19332243
--- Diff: storm-core/src/jvm/backtype/storm/task/ShellBolt.java ---
@@ -305,4 +283,95 @@ private void die(Throwable exception) {
System.exi
Github user itaifrenkel commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-60365096
@ptgoetz Is there a shared ScheduledExecutor in storm? It seems redundant
that each bolt would dedicate a thread for the scheduler. Especially now, that
the task itsel
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r19330106
--- Diff: storm-core/src/jvm/backtype/storm/task/ShellBolt.java ---
@@ -305,4 +283,95 @@ private void die(Throwable exception) {
System.exi
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r19326747
--- Diff: storm-core/src/jvm/backtype/storm/task/ShellBolt.java ---
@@ -305,4 +283,95 @@ private void die(Throwable exception) {
System.exi
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r19326582
--- Diff: storm-core/src/jvm/backtype/storm/task/ShellBolt.java ---
@@ -305,4 +283,95 @@ private void die(Throwable exception) {
System.exi
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-59983717
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18803104
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +67,18 @@ public void open(Map stormConf, TopologyContext context,
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18747035
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +67,18 @@ public void open(Map stormConf, TopologyContext context,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18746971
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +67,18 @@ public void open(Map stormConf, TopologyContext context,
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18745860
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +67,18 @@ public void open(Map stormConf, TopologyContext context,
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18745857
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -189,9 +207,53 @@ private void handleLog(ShellMsg shellMsg) {
@Overr
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18745322
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -189,9 +207,53 @@ private void handleLog(ShellMsg shellMsg) {
@Overr
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18745301
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +66,18 @@ public void open(Map stormConf, TopologyContext context,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18745292
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +66,18 @@ public void open(Map stormConf, TopologyContext context,
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18742262
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -189,9 +207,53 @@ private void handleLog(ShellMsg shellMsg) {
@Overr
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18742240
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +66,18 @@ public void open(Map stormConf, TopologyContext context,
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-58752058
@itaifrenkel Thanks for pointing out missed spots and points to improve!
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741698
--- Diff: storm-core/src/dev/resources/storm.js ---
@@ -243,6 +243,12 @@ BasicBolt.prototype.__emit = function(commandDetails) {
BasicBolt.prototype.ha
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741678
--- Diff: storm-core/src/dev/resources/storm.js ---
@@ -243,6 +243,12 @@ BasicBolt.prototype.__emit = function(commandDetails) {
BasicBolt.prototype.ha
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741577
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +64,18 @@ public void open(Map stormConf, TopologyContext context,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741514
--- Diff: storm-core/src/dev/resources/storm.js ---
@@ -243,6 +243,12 @@ BasicBolt.prototype.__emit = function(commandDetails) {
BasicBolt.prototype.ha
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741463
--- Diff: storm-core/src/dev/resources/storm.js ---
@@ -243,6 +243,12 @@ BasicBolt.prototype.__emit = function(commandDetails) {
BasicBolt.prototype.ha
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741401
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -189,9 +205,52 @@ private void handleLog(ShellMsg shellMsg) {
@Overr
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741389
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -189,9 +205,52 @@ private void handleLog(ShellMsg shellMsg) {
@Overr
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741231
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +64,18 @@ public void open(Map stormConf, TopologyContext context,
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741220
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +64,18 @@ public void open(Map stormConf, TopologyContext context,
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741213
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +64,18 @@ public void open(Map stormConf, TopologyContext context,
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741196
--- Diff: storm-core/src/dev/resources/storm.js ---
@@ -243,6 +243,12 @@ BasicBolt.prototype.__emit = function(commandDetails) {
BasicBolt.prototype.ha
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741189
--- Diff: storm-core/src/dev/resources/storm.js ---
@@ -243,6 +243,12 @@ BasicBolt.prototype.__emit = function(commandDetails) {
BasicBolt.prototype.ha
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741180
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -189,9 +205,52 @@ private void handleLog(ShellMsg shellMsg) {
@Overr
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741104
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -189,9 +205,52 @@ private void handleLog(ShellMsg shellMsg) {
@Overr
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18741096
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -189,9 +205,52 @@ private void handleLog(ShellMsg shellMsg) {
@Overr
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-58366793
@dan-blanchard You're welcome!
Actually it doesn't let subprocess sends heartbeat periodically, so it
can't cover some situations.
ex) subprocess is alive
Github user dan-blanchard commented on the pull request:
https://github.com/apache/storm/pull/286#issuecomment-58363290
As the person who filed the issue. Thanks for coming up with a solution so
quickly!
---
If your project is set up for it, you can reply to this email and have your
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/286
STORM-513 check heartbeat from multilang subprocess
Related issue link : https://issues.apache.org/jira/browse/STORM-513
It seems that ShellSpout and ShellBolt doesn't check subprocess, a
56 matches
Mail list logo
