Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-67672726
@nathanmarz Yes previously it used keep retrying but this is causing too
many logs being generated by kafka due to the failed requests. This is fixed in
https://issues.a
Github user nathanmarz commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-67615349
Can you elaborate? It should just keep trying that last offset repeatedly.
This is a case I tested repeatedly when I originally wrote this, so if this is
the case it's
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-67593637
@nathanmarz there is another case where your topology is running and
processed all the existing data and there is no new data came into kafka topic
which could cause off
Github user nathanmarz commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-67589509
Yea, most of this can be addressed by allocating more resources so Kafka
has enough retention to not truncate the data before the topology can be fixed.
+1
--
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-67582859
@nathanmarz the re-emit can hit this issue in many pathological cases , bad
kafka config, transient network failure causing storm batches to fail
repeatedly whil
Github user nathanmarz commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-67581552
Once this code is no longer applied to the transactional spout, I'll be +1.
I'd still like to know why that exception is happening though.
---
If your project is set u
Github user nathanmarz commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-67581379
-1
Why are offset out of range exceptions happening when re-emitting a batch?
That shouldn't be possible so I'd like to know why this is happening.
Emi
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-67557355
Thanks for the quick fix @Parth-Brahmbhatt . +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-6720
I had a chat with @harshach and he pointed out that we will hit
https://github.com/apache/storm/pull/321 if we just use KafkaUtil.getOffset
method. I have modifie
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-67527319
Thanks @Parth-Brahmbhatt overall it looks good to me. +1. I'll give a day
or two before I merge this in.
---
If your project is set up for it, you can reply to this em
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-67436156
@harshach added exceptions to throws declaration and upmerged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/339#discussion_r21874150
--- Diff: external/storm-kafka/src/jvm/storm/kafka/KafkaUtils.java ---
@@ -155,7 +155,7 @@ public void refreshPartitions(Set
partitions) {
}
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-66829121
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user Parth-Brahmbhatt closed the pull request at:
https://github.com/apache/storm/pull/339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user Parth-Brahmbhatt reopened a pull request:
https://github.com/apache/storm/pull/339
STORM-586: TridentKafkaEmitter should catch updateOffsetException.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Parth-Brahmbhatt/i
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/339#issuecomment-66206449
I also tested this locally and it works fine for OpaqueTridentSpout. The
TransactionalSpout tries to reemit a batch and when the offset is out of range
there is n
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/339#discussion_r21495048
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/UpdateOffsetException.java ---
@@ -17,6 +17,9 @@
*/
package storm.kafka;
-publ
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/339#discussion_r21414360
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/UpdateOffsetException.java ---
@@ -17,6 +17,9 @@
*/
package storm.kafka;
-public class
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/storm/pull/339
STORM-586: TridentKafkaEmitter should catch updateOffsetException.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Parth-Brahmbhatt/inc
20 matches
Mail list logo
